2022-01-21 20:12:27

by Alistair Delva

Subject: [PATCH] remoteproc: Fix count check in rproc_coredump_write()

Check count for 0, to avoid a potential underflow. Make the check the
same as the one in rproc_recovery_write().

Fixes: 3afdc59e4390 ("remoteproc: Add coredump debugfs entry")
Signed-off-by: Alistair Delva <[email protected]>
Cc: Rishabh Bhatnagar <[email protected]>
Cc: [email protected]
Cc: Ohad Ben-Cohen <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Mathieu Poirier <[email protected]>
Cc: Sibi Sankar <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
drivers/remoteproc/remoteproc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
index b5a1e3b697d9..581930483ef8 100644
--- a/drivers/remoteproc/remoteproc_debugfs.c
+++ b/drivers/remoteproc/remoteproc_debugfs.c
@@ -76,7 +76,7 @@ static ssize_t rproc_coredump_write(struct file *filp,
int ret, err = 0;
char buf[20];

- if (count > sizeof(buf))
+ if (count < 1 || count > sizeof(buf))
return -EINVAL;

ret = copy_from_user(buf, user_buf, count);
--
2.30.2

2022-01-21 20:18:25

by Bjorn Andersson

Subject: Re: [PATCH] remoteproc: Fix count check in rproc_coredump_write()

On Wed 19 Jan 15:21 PST 2022, Alistair Delva wrote:

> Check count for 0, to avoid a potential underflow. Make the check the
> same as the one in rproc_recovery_write().
>
> Fixes: 3afdc59e4390 ("remoteproc: Add coredump debugfs entry")
> Signed-off-by: Alistair Delva <[email protected]>
> Cc: Rishabh Bhatnagar <[email protected]>
> Cc: [email protected]
> Cc: Ohad Ben-Cohen <[email protected]>
> Cc: Bjorn Andersson <[email protected]>
> Cc: Mathieu Poirier <[email protected]>
> Cc: Sibi Sankar <[email protected]>
> Cc: [email protected]
> Cc: [email protected]

Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> ---
> drivers/remoteproc/remoteproc_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
> index b5a1e3b697d9..581930483ef8 100644
> --- a/drivers/remoteproc/remoteproc_debugfs.c
> +++ b/drivers/remoteproc/remoteproc_debugfs.c
> @@ -76,7 +76,7 @@ static ssize_t rproc_coredump_write(struct file *filp,
> int ret, err = 0;
> char buf[20];
>
> - if (count > sizeof(buf))
> + if (count < 1 || count > sizeof(buf))
> return -EINVAL;
>
> ret = copy_from_user(buf, user_buf, count);
> --
> 2.30.2
>

2022-02-08 04:27:10

by Bjorn Andersson

Subject: Re: [PATCH] remoteproc: Fix count check in rproc_coredump_write()

On Wed, 19 Jan 2022 23:21:39 +0000, Alistair Delva wrote:
> Check count for 0, to avoid a potential underflow. Make the check the
> same as the one in rproc_recovery_write().
>
>

Applied, thanks!

[1/1] remoteproc: Fix count check in rproc_coredump_write()
commit: 09dc6efba9088a84ac00bd25be36c50d0a01a4df

Best regards,
--
Bjorn Andersson <[email protected]>