2022-01-22 02:04:48

by Justin Iurman

Subject: [PATCH net] selftests: net: ioam: Fixes b63c5478e9

The IOAM queue-depth data field was added a few weeks ago, but the test unit
was not updated accordingly. Here is the fix, thanks for the report.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Justin Iurman <[email protected]>
---
tools/testing/selftests/net/ioam6_parser.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tools/testing/selftests/net/ioam6_parser.c b/tools/testing/selftests/net/ioam6_parser.c
index 8f6997d35816..d9d1d4190126 100644
--- a/tools/testing/selftests/net/ioam6_parser.c
+++ b/tools/testing/selftests/net/ioam6_parser.c
@@ -240,11 +240,8 @@ static int check_ioam6_data(__u8 **p, struct ioam6_trace_hdr *ioam6h,
*p += sizeof(__u32);
}

- if (ioam6h->type.bit6) {
- if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
- return 1;
+ if (ioam6h->type.bit6)
*p += sizeof(__u32);
- }

if (ioam6h->type.bit7) {
if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
--
2.25.1

2022-01-23 00:14:30

by Jakub Kicinski

Subject: Re: [PATCH net] selftests: net: ioam: Fixes b63c5478e9

On Fri, 21 Jan 2022 18:34:49 +0100 Justin Iurman wrote:
> Subject: [PATCH net] selftests: net: ioam: Fixes b63c5478e9

selftests: net: ioam: expect support for Queue depth data

> Date: Fri, 21 Jan 2022 18:34:49 +0100
> X-Mailer: git-send-email 2.25.1
>
> The IOAM queue-depth data field was added a few weeks ago, but the test unit
> was not updated accordingly. Here is the fix, thanks for the report.

s/Here.*//

> Reported-by: kernel test robot <[email protected]>

Fixes: b63c5478e9cb ("ipv6: ioam: Support for Queue depth data field")

> Signed-off-by: Justin Iurman <[email protected]>

Applied, thanks!