2022-01-23 15:01:59

by Dongliang Mu

Subject: [PATCH] hid: elo: fix memory leak in elo_probe

From: Dongliang Mu <[email protected]>

When hid_parse in elo_probe fails, it forgets to call usb_put_dev to
decrease the refcount.

Fix this by adding usb_put_dev in the error handling code of elo_probe

Fixes: fbf42729d0e9 ("HID: elo: update the reference count of the usb device structure")
Reported-by: syzkaller <[email protected]>
Signed-off-by: Dongliang Mu <[email protected]>
---
drivers/hid/hid-elo.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hid/hid-elo.c b/drivers/hid/hid-elo.c
index 8e960d7b233b..9b42b0cdeef0 100644
--- a/drivers/hid/hid-elo.c
+++ b/drivers/hid/hid-elo.c
@@ -262,6 +262,7 @@ static int elo_probe(struct hid_device *hdev, const struct hid_device_id *id)

return 0;
err_free:
+ usb_put_dev(udev);
kfree(priv);
return ret;
}
--
2.25.1

2022-01-24 18:50:05

by Jiri Kosina

Subject: Re: [PATCH] hid: elo: fix memory leak in elo_probe

On Sat, 22 Jan 2022, Dongliang Mu wrote:

> From: Dongliang Mu <[email protected]>
>
> When hid_parse in elo_probe fails, it forgets to call usb_put_dev to
> decrease the refcount.
>
> Fix this by adding usb_put_dev in the error handling code of elo_probe
>
> Fixes: fbf42729d0e9 ("HID: elo: update the reference count of the usb device structure")
> Reported-by: syzkaller <[email protected]>
> Signed-off-by: Dongliang Mu <[email protected]>
> ---
> drivers/hid/hid-elo.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-elo.c b/drivers/hid/hid-elo.c
> index 8e960d7b233b..9b42b0cdeef0 100644
> --- a/drivers/hid/hid-elo.c
> +++ b/drivers/hid/hid-elo.c
> @@ -262,6 +262,7 @@ static int elo_probe(struct hid_device *hdev, const struct hid_device_id *id)
>
> return 0;
> err_free:
> + usb_put_dev(udev);
> kfree(priv);
> return ret;

Applied, thank you.

--
Jiri Kosina
SUSE Labs