2022-01-25 09:12:17

by Guangbin Huang

Subject: [PATCH net] net: hns3: handle empty unknown interrupt for VF

From: Yufeng Mo <[email protected]>

Since some interrupt states may be cleared by hardware, the driver
may receive an empty interrupt. Currently, the VF driver directly
disables the vector0 interrupt in this case. As a result, the VF
is unavailable. Therefore, the vector0 interrupt should be enabled
in this case.

Fixes: b90fcc5bd904 ("net: hns3: add reset handling for VF when doing Core/Global/IMP reset")
Signed-off-by: Yufeng Mo <[email protected]>
Signed-off-by: Guangbin Huang <[email protected]>
---
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
index 7df87610ad96..21442a9bb996 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
@@ -2043,8 +2043,7 @@ static irqreturn_t hclgevf_misc_irq_handle(int irq, void *data)
break;
}

- if (event_cause != HCLGEVF_VECTOR0_EVENT_OTHER)
- hclgevf_enable_vector(&hdev->misc_vector, true);
+ hclgevf_enable_vector(&hdev->misc_vector, true);

return IRQ_HANDLED;
}
--
2.33.0

2022-01-25 22:51:42

by Jakub Kicinski

Subject: Re: [PATCH net] net: hns3: handle empty unknown interrupt for VF

On Tue, 25 Jan 2022 15:03:12 +0800 Guangbin Huang wrote:
> From: Yufeng Mo <[email protected]>
>
> Since some interrupt states may be cleared by hardware, the driver
> may receive an empty interrupt. Currently, the VF driver directly
> disables the vector0 interrupt in this case. As a result, the VF
> is unavailable. Therefore, the vector0 interrupt should be enabled
> in this case.
>
> Fixes: b90fcc5bd904 ("net: hns3: add reset handling for VF when doing Core/Global/IMP reset")
> Signed-off-by: Yufeng Mo <[email protected]>
> Signed-off-by: Guangbin Huang <[email protected]>

Applied, thanks:

2f61353cd2f7 ("net: hns3: handle empty unknown interrupt for VF")