2022-01-26 12:38:54

by Florian Fainelli

Subject: [PATCH] mtd: rawnand: brcmnand: Fix sparse warnings in bcma_nand

sparse was unhappy about the way we woulc call cpu_to_be32/be32_to_cpu,
apply the appropriate casting to silence the warnings.

Reported-by: kernel test robot <[email protected]>
Link: https://lists.01.org/hyperkitty/list/[email protected]/thread/ZNHPJFYLO64EGI5QUT7HZ63J7O5J2G7N/
Signed-off-by: Florian Fainelli <[email protected]>
---
drivers/mtd/nand/raw/brcmnand/bcma_nand.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/raw/brcmnand/bcma_nand.c b/drivers/mtd/nand/raw/brcmnand/bcma_nand.c
index d7c62988c452..dd27977919fb 100644
--- a/drivers/mtd/nand/raw/brcmnand/bcma_nand.c
+++ b/drivers/mtd/nand/raw/brcmnand/bcma_nand.c
@@ -58,7 +58,7 @@ static u32 brcmnand_bcma_read_reg(struct brcmnand_soc *soc, u32 offset)

/* Swap if necessary */
if (brcmnand_bcma_needs_swapping(offset))
- val = be32_to_cpu(val);
+ val = be32_to_cpu((__force __be32)val);
return val;
}

@@ -75,7 +75,7 @@ static void brcmnand_bcma_write_reg(struct brcmnand_soc *soc, u32 val,

/* Swap if necessary */
if (brcmnand_bcma_needs_swapping(offset))
- val = cpu_to_be32(val);
+ val = (__force u32)cpu_to_be32(val);

bcma_cc_write32(sc->cc, offset, val);
}
--
2.25.1

2022-01-26 21:05:40

by Miquel Raynal

Subject: Re: [PATCH] mtd: rawnand: brcmnand: Fix sparse warnings in bcma_nand

On Tue, 2022-01-25 at 22:52:43 UTC, Florian Fainelli wrote:
> sparse was unhappy about the way we woulc call cpu_to_be32/be32_to_cpu,
> apply the appropriate casting to silence the warnings.
>
> Reported-by: kernel test robot <[email protected]>
> Link: https://lists.01.org/hyperkitty/list/[email protected]/thread/ZNHPJFYLO64EGI5QUT7HZ63J7O5J2G7N/
> Signed-off-by: Florian Fainelli <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel