2022-01-26 15:15:38

by Yin Xiujiang

[permalink] [raw]
Subject: [PATCH] scsi: bnx2fc: Make use of the helper macro kthread_run()

Repalce kthread_create/wake_up_process() with kthread_run()
to simplify the code.

Signed-off-by: Yin Xiujiang <[email protected]>
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 71fa62bd3083..5edc2b812646 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
@@ -2723,14 +2723,13 @@ static int __init bnx2fc_mod_init(void)

bg = &bnx2fc_global;
skb_queue_head_init(&bg->fcoe_rx_list);
- l2_thread = kthread_create(bnx2fc_l2_rcv_thread,
+ l2_thread = kthread_run(bnx2fc_l2_rcv_thread,
(void *)bg,
"bnx2fc_l2_thread");
if (IS_ERR(l2_thread)) {
rc = PTR_ERR(l2_thread);
goto free_wq;
}
- wake_up_process(l2_thread);
spin_lock_bh(&bg->fcoe_rx_list.lock);
bg->kthread = l2_thread;
spin_unlock_bh(&bg->fcoe_rx_list.lock);
--
2.30.0


2022-02-08 08:48:53

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: bnx2fc: Make use of the helper macro kthread_run()

On Wed, 26 Jan 2022 09:42:48 +0800, Yin Xiujiang wrote:

> Repalce kthread_create/wake_up_process() with kthread_run()
> to simplify the code.
>
>

Applied to 5.18/scsi-queue, thanks!

[1/1] scsi: bnx2fc: Make use of the helper macro kthread_run()
https://git.kernel.org/mkp/scsi/c/687ba48e16e4

--
Martin K. Petersen Oracle Linux Engineering