2022-01-26 20:45:23

by Leo Li

[permalink] [raw]
Subject: [PATCH] arm64: dts: ls1028a-qds: define mdio slots for networking options

The ls1028a QDS board support different pluggable PHY cards. Define the
nodes for these slots to be updated at boot time with overlay according
to board setup.

Signed-off-by: Alex Marginean <[email protected]>
Signed-off-by: Li Yang <[email protected]>
---
.../boot/dts/freescale/fsl-ls1028a-qds.dts | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
index 177bc1405f0f..19d3952dbffe 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
@@ -107,6 +107,30 @@ qds_phy1: ethernet-phy@5 {
reg = <5>;
};
};
+
+ mdio_slot1: mdio@4 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <4>;
+ };
+
+ mdio_slot2: mdio@5 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <5>;
+ };
+
+ mdio_slot3: mdio@6 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <6>;
+ };
+
+ mdio_slot4: mdio@7 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <7>;
+ };
};
};

--
2.25.1


2022-01-26 21:20:24

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: ls1028a-qds: define mdio slots for networking options

On Wed, Jan 26, 2022 at 03:26:50AM -0600, Li Yang wrote:
> The ls1028a QDS board support different pluggable PHY cards. Define the
> nodes for these slots to be updated at boot time with overlay according
> to board setup.
>
> Signed-off-by: Alex Marginean <[email protected]>
> Signed-off-by: Li Yang <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2022-01-28 11:11:06

by Vladimir Oltean

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: ls1028a-qds: define mdio slots for networking options

On Wed, Jan 26, 2022 at 03:26:50AM -0600, Li Yang wrote:
> The ls1028a QDS board support different pluggable PHY cards. Define the
> nodes for these slots to be updated at boot time with overlay according
> to board setup.
>
> Signed-off-by: Alex Marginean <[email protected]>
> Signed-off-by: Li Yang <[email protected]>
> ---

Tested-by: Vladimir Oltean <[email protected]>

This fixes:
=> tftp $fdt_addr_r fsl-ls1028a-qds.dtb && tftp $fdt_ovr_addr_r fsl-ls1028a-qds-85bb.dtb
=> fdt addr $fdt_addr_r && fdt resize 0x100000 && fdt apply $fdt_ovr_addr_r
failed on fdt_overlay_apply(): FDT_ERR_NOTFOUND

> .../boot/dts/freescale/fsl-ls1028a-qds.dts | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> index 177bc1405f0f..19d3952dbffe 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> @@ -107,6 +107,30 @@ qds_phy1: ethernet-phy@5 {
> reg = <5>;
> };
> };
> +
> + mdio_slot1: mdio@4 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <4>;
> + };
> +
> + mdio_slot2: mdio@5 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <5>;
> + };
> +
> + mdio_slot3: mdio@6 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <6>;
> + };
> +
> + mdio_slot4: mdio@7 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <7>;
> + };
> };
> };
>
> --
> 2.25.1
>

2022-01-31 23:11:42

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: ls1028a-qds: define mdio slots for networking options

On Wed, Jan 26, 2022 at 03:26:50AM -0600, Li Yang wrote:
> The ls1028a QDS board support different pluggable PHY cards. Define the
> nodes for these slots to be updated at boot time with overlay according
> to board setup.
>
> Signed-off-by: Alex Marginean <[email protected]>
> Signed-off-by: Li Yang <[email protected]>

Applied, thanks!