2022-02-05 11:12:55

by Tomohito Esaki

[permalink] [raw]
Subject: [PATCH] drm/sprd: remove allow_fb_modifiers setting

Remove allow_fb_modifiers setting in this driver. The allow_fb_modifiers
flag was removed.

Signed-off-by: Tomohito Esaki <[email protected]>
Fixes: 3d082157a242 ("drm: remove allow_fb_modifiers")
Reported-by: kernel test robot <[email protected]>
---
drivers/gpu/drm/sprd/sprd_drm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sprd/sprd_drm.c b/drivers/gpu/drm/sprd/sprd_drm.c
index a077e2d4d721..54c851bccf5b 100644
--- a/drivers/gpu/drm/sprd/sprd_drm.c
+++ b/drivers/gpu/drm/sprd/sprd_drm.c
@@ -43,7 +43,6 @@ static void sprd_drm_mode_config_init(struct drm_device *drm)
drm->mode_config.min_height = 0;
drm->mode_config.max_width = 8192;
drm->mode_config.max_height = 8192;
- drm->mode_config.allow_fb_modifiers = true;

drm->mode_config.funcs = &sprd_drm_mode_config_funcs;
drm->mode_config.helper_private = &sprd_drm_mode_config_helper;
--
2.17.1



2022-02-07 18:25:07

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH] drm/sprd: remove allow_fb_modifiers setting

Hi Tomohito,

On Fri, Feb 04, 2022 at 11:36:35AM +0900, Tomohito Esaki wrote:
> Remove allow_fb_modifiers setting in this driver. The allow_fb_modifiers
> flag was removed.
>
> Signed-off-by: Tomohito Esaki <[email protected]>
> Fixes: 3d082157a242 ("drm: remove allow_fb_modifiers")
> Reported-by: kernel test robot <[email protected]>
> ---
> drivers/gpu/drm/sprd/sprd_drm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sprd/sprd_drm.c b/drivers/gpu/drm/sprd/sprd_drm.c
> index a077e2d4d721..54c851bccf5b 100644
> --- a/drivers/gpu/drm/sprd/sprd_drm.c
> +++ b/drivers/gpu/drm/sprd/sprd_drm.c
> @@ -43,7 +43,6 @@ static void sprd_drm_mode_config_init(struct drm_device *drm)
> drm->mode_config.min_height = 0;
> drm->mode_config.max_width = 8192;
> drm->mode_config.max_height = 8192;
> - drm->mode_config.allow_fb_modifiers = true;
>
> drm->mode_config.funcs = &sprd_drm_mode_config_funcs;
> drm->mode_config.helper_private = &sprd_drm_mode_config_helper;

Thanks, this partially fixed my arm build.
Pushed to drm-misc-next and should appear in -next within some days.

Sam