tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: dfd42facf1e4ada021b939b4e19c935dcdd55566
commit: 770b1d216d7371c94c88713824da4be4bc39a4e0 md/raid5: play nice with PREEMPT_RT
date: 5 weeks ago
config: x86_64-rhel-8.3-kselftests (https://download.01.org/0day-ci/archive/20220207/[email protected]/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=770b1d216d7371c94c88713824da4be4bc39a4e0
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 770b1d216d7371c94c88713824da4be4bc39a4e0
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
sparse warnings: (new ones prefixed by >>)
drivers/md/raid5.c: note: in included file:
drivers/md/raid5.h:271:14: sparse: sparse: array of flexible structures
drivers/md/raid5.c:641:40: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:641:40: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:641:40: sparse: struct md_rdev *
drivers/md/raid5.c:643:32: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:643:32: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:643:32: sparse: struct md_rdev *
drivers/md/raid5.c:667:40: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:667:40: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:667:40: sparse: struct md_rdev *
drivers/md/raid5.c:669:32: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:669:32: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:669:32: sparse: struct md_rdev *
drivers/md/raid5.c:1101:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:1101:25: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:1101:25: sparse: struct md_rdev *
drivers/md/raid5.c:1103:24: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:1103:24: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:1103:24: sparse: struct md_rdev *
drivers/md/raid5.c:3563:32: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:3563:32: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:3563:32: sparse: struct md_rdev *
drivers/md/raid5.c:3689:48: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:3689:48: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:3689:48: sparse: struct md_rdev *
drivers/md/raid5.c:3696:32: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:3696:32: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:3696:32: sparse: struct md_rdev *
drivers/md/raid5.c:3718:16: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:3718:16: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:3718:16: sparse: struct md_rdev *
drivers/md/raid5.c:4646:24: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:4646:24: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:4646:24: sparse: struct md_rdev *
drivers/md/raid5.c:4657:32: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:4657:32: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:4657:32: sparse: struct md_rdev *
drivers/md/raid5.c:4704:49: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:4704:49: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:4704:49: sparse: struct md_rdev *
drivers/md/raid5.c:4717:49: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:4717:49: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:4717:49: sparse: struct md_rdev *
drivers/md/raid5.c:4726:49: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:4726:49: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:4726:49: sparse: struct md_rdev *
drivers/md/raid5.c:4748:40: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:4748:40: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:4748:40: sparse: struct md_rdev *
drivers/md/raid5.c:5419:16: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:5419:16: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:5419:16: sparse: struct md_rdev *
drivers/md/raid5.c:5422:24: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:5422:24: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:5422:24: sparse: struct md_rdev *
>> drivers/md/raid5.c:7055:9: sparse: sparse: cast removes address space '__percpu' of expression
>> drivers/md/raid5.c:7055:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct lockdep_map *lock @@ got struct lockdep_map [noderef] __percpu * @@
drivers/md/raid5.c:7055:9: sparse: expected struct lockdep_map *lock
drivers/md/raid5.c:7055:9: sparse: got struct lockdep_map [noderef] __percpu *
>> drivers/md/raid5.c:7055:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct local_lock_t [usertype] *l @@ got struct local_lock_t [noderef] __percpu * @@
drivers/md/raid5.c:7055:9: sparse: expected struct local_lock_t [usertype] *l
drivers/md/raid5.c:7055:9: sparse: got struct local_lock_t [noderef] __percpu *
drivers/md/raid5.c:7808:40: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:7808:40: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:7808:40: sparse: struct md_rdev *
drivers/md/raid5.c:8021:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:8021:25: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:8021:25: sparse: struct md_rdev *
drivers/md/raid5.c:8037:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
drivers/md/raid5.c:8037:25: sparse: struct md_rdev [noderef] __rcu *
drivers/md/raid5.c:8037:25: sparse: struct md_rdev *
drivers/md/raid5.c:1476:16: sparse: sparse: dereference of noderef expression
drivers/md/raid5.c:1476:39: sparse: sparse: dereference of noderef expression
drivers/md/raid5.c:2208:54: sparse: sparse: dereference of noderef expression
drivers/md/raid5.c:2419:16: sparse: sparse: dereference of noderef expression
drivers/md/raid5.c:2421:9: sparse: sparse: dereference of noderef expression
drivers/md/raid5.c:2422:9: sparse: sparse: dereference of noderef expression
drivers/md/raid5.c:7031:23: sparse: sparse: dereference of noderef expression
drivers/md/raid5.c:7031:23: sparse: sparse: dereference of noderef expression
drivers/md/raid5.c:7032:9: sparse: sparse: dereference of noderef expression
drivers/md/raid5.c:7033:16: sparse: sparse: dereference of noderef expression
drivers/md/raid5.c:7034:9: sparse: sparse: dereference of noderef expression
drivers/md/raid5.c:7039:34: sparse: sparse: dereference of noderef expression
drivers/md/raid5.c:7040:17: sparse: sparse: dereference of noderef expression
drivers/md/raid5.c:7041:22: sparse: sparse: dereference of noderef expression
drivers/md/raid5.c:97:9: sparse: sparse: context imbalance in 'raid5_quiesce' - different lock contexts for basic block
vim +/__percpu +7055 drivers/md/raid5.c
7036
7037 static int alloc_scratch_buffer(struct r5conf *conf, struct raid5_percpu *percpu)
7038 {
7039 if (conf->level == 6 && !percpu->spare_page) {
7040 percpu->spare_page = alloc_page(GFP_KERNEL);
7041 if (!percpu->spare_page)
7042 return -ENOMEM;
7043 }
7044
7045 if (scribble_alloc(percpu,
7046 max(conf->raid_disks,
7047 conf->previous_raid_disks),
7048 max(conf->chunk_sectors,
7049 conf->prev_chunk_sectors)
7050 / RAID5_STRIPE_SECTORS(conf))) {
7051 free_scratch_buffer(conf, percpu);
7052 return -ENOMEM;
7053 }
7054
> 7055 local_lock_init(&percpu->lock);
7056 return 0;
7057 }
7058
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
Move out the nested declaration of the percpu bits of struct r5conf and
silence sparse complaining about address spaces:
drivers/md/raid5.c:7070:9: sparse: sparse: cast removes address space '__percpu' of expression
drivers/md/raid5.c:7070:9: warning: incorrect type in argument 1 (different address spaces)
drivers/md/raid5.c:7070:9: expected struct lockdep_map *lock
drivers/md/raid5.c:7070:9: got struct lockdep_map [noderef] __percpu *
drivers/md/raid5.c:7070:9: warning: incorrect type in argument 1 (different address spaces)
drivers/md/raid5.c:7070:9: expected struct local_lock_t [usertype] *l
drivers/md/raid5.c:7070:9: got struct local_lock_t [noderef] __percpu *
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Davidlohr Bueso <[email protected]>
---
drivers/md/raid5.h | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/md/raid5.h b/drivers/md/raid5.h
index 9e8486a9e445..125b925e2b0c 100644
--- a/drivers/md/raid5.h
+++ b/drivers/md/raid5.h
@@ -560,6 +560,17 @@ struct r5pending_data {
struct bio_list bios;
};
+/* per cpu variables */
+struct raid5_percpu {
+ struct page *spare_page; /* Used when checking P/Q in raid6 */
+ void *scribble; /* space for constructing buffer
+ * lists and performing address
+ * conversions
+ */
+ int scribble_obj_size;
+ local_lock_t lock;
+};
+
struct r5conf {
struct hlist_head *stripe_hashtbl;
/* only protect corresponding hash list and inactive_list */
@@ -634,16 +645,7 @@ struct r5conf {
* Cleared when a sync completes.
*/
int recovery_disabled;
- /* per cpu variables */
- struct raid5_percpu {
- struct page *spare_page; /* Used when checking P/Q in raid6 */
- void *scribble; /* space for constructing buffer
- * lists and performing address
- * conversions
- */
- int scribble_obj_size;
- local_lock_t lock;
- } __percpu *percpu;
+ struct raid5_percpu __percpu *percpu;
int scribble_disks;
int scribble_sectors;
struct hlist_node node;
--
2.35.1