The led is used as front flash of BQ Aquaris M5.
https://github.com/bq/aquaris-M5/blob/901d0b2ca05c0b0af49786fb548eb0fc289867ff/arch/arm/boot/dts/qcom/piccolo-msm8939-camera-sensor-qrd.dtsi#L16
v2: Reorder patches
André Apitzsch (3):
dt-bindings: vendor-prefixes: Add ocs prefix
dt-bindings: leds: sgm3140: Document ocp8110 compatible
leds: sgm3140: Add ocs,ocp8110 compatible
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++-
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
drivers/leds/flash/leds-sgm3140.c | 1 +
3 files changed, 6 insertions(+), 1 deletion(-)
base-commit: 2ade8eef993c37a2a43e51a9b1f6c25509a2acce
--
2.35.1
Orient-Chip's ocp8110 has the same pin configuration as the sgm3140.
The data sheet can be found at:
https://cdn.datasheetspdf.com/pdf-down/O/C/P/OCP8110-OrientChip.pdf
Signed-off-by: André Apitzsch <[email protected]>
---
drivers/leds/flash/leds-sgm3140.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/flash/leds-sgm3140.c b/drivers/leds/flash/leds-sgm3140.c
index f4f831570f11..d3a30ad94ac4 100644
--- a/drivers/leds/flash/leds-sgm3140.c
+++ b/drivers/leds/flash/leds-sgm3140.c
@@ -290,6 +290,7 @@ static int sgm3140_remove(struct platform_device *pdev)
}
static const struct of_device_id sgm3140_dt_match[] = {
+ { .compatible = "ocs,ocp8110" },
{ .compatible = "sgmicro,sgm3140" },
{ /* sentinel */ }
};
--
2.35.1
Signed-off-by: André Apitzsch <[email protected]>
---
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
index f68259619488..1c345cf16d08 100644
--- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
@@ -18,7 +18,9 @@ description: |
properties:
compatible:
- const: sgmicro,sgm3140
+ enum:
+ - ocs,ocp8110
+ - sgmicro,sgm3140
enable-gpios:
maxItems: 1
--
2.35.1
Am Freitag, dem 11.02.2022 um 10:34 -0600 schrieb Rob Herring:
> On Tue, Feb 08, 2022 at 12:06:37AM +0100, André Apitzsch wrote:
> > Signed-off-by: André Apitzsch <[email protected]>
>
> Commit msg? What's this h/w?
>
Thanks for the feedback.
Would the following message be sufficient?
"""
dt-bindings: leds: sgm3140: Document ocp8110 compatible
Add devicetree binding for Orient Chip OCP8110 charge pump used for
camera flash LEDs.
"""
> > ---
> > Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > index f68259619488..1c345cf16d08 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> > @@ -18,7 +18,9 @@ description: |
> >
> > properties:
> > compatible:
> > - const: sgmicro,sgm3140
> > + enum:
> > + - ocs,ocp8110
> > + - sgmicro,sgm3140
> >
> > enable-gpios:
> > maxItems: 1
> > --
> > 2.35.1
> >
> >
On Sat 2022-02-12 14:13:32, Andr? Apitzsch wrote:
> Am Freitag, dem 11.02.2022 um 10:34 -0600 schrieb Rob Herring:
> > On Tue, Feb 08, 2022 at 12:06:37AM +0100, Andr? Apitzsch wrote:
> > > Signed-off-by: Andr? Apitzsch <[email protected]>
> >
> > Commit msg? What's this h/w?
> >
> Thanks for the feedback.
>
> Would the following message be sufficient?
>
> """
> dt-bindings: leds: sgm3140: Document ocp8110 compatible
>
> Add devicetree binding for Orient Chip OCP8110 charge pump used for
> camera flash LEDs.
> """
Sounds good to me.
Pavel
--
http://www.livejournal.com/~pavelmachek
Hi!
> The led is used as front flash of BQ Aquaris M5.
>
> https://github.com/bq/aquaris-M5/blob/901d0b2ca05c0b0af49786fb548eb0fc289867ff/arch/arm/boot/dts/qcom/piccolo-msm8939-camera-sensor-qrd.dtsi#L16
Thanks for patches, I took 1 and 3/3, waiting for some kind of
changelog on 2/.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
On Tue, Feb 08, 2022 at 12:06:37AM +0100, Andr? Apitzsch wrote:
> Signed-off-by: Andr? Apitzsch <[email protected]>
Commit msg? What's this h/w?
> ---
> Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> index f68259619488..1c345cf16d08 100644
> --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> @@ -18,7 +18,9 @@ description: |
>
> properties:
> compatible:
> - const: sgmicro,sgm3140
> + enum:
> + - ocs,ocp8110
> + - sgmicro,sgm3140
>
> enable-gpios:
> maxItems: 1
> --
> 2.35.1
>
>