2022-02-09 05:53:54

by Paul Menzel

Subject: [PATCH] rcutorture: Add missing - to `--do-allmodconfig` in usage

The usage currently lists `--doallmodconfig`, resulting in:

$ tools/testing/selftests/rcutorture/bin/torture.sh --doallmodconfig
Unknown argument --doallmodconfig
[…]

Add the missing dash for `--do-allmodconfig`.

Fixes: a115a775a8d5 ("torture: Add "make allmodconfig" to torture.sh")
Signed-off-by: Paul Menzel <[email protected]>
---
tools/testing/selftests/rcutorture/bin/torture.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/rcutorture/bin/torture.sh b/tools/testing/selftests/rcutorture/bin/torture.sh
index eae88aacca2a..3adcc83dd55d 100755
--- a/tools/testing/selftests/rcutorture/bin/torture.sh
+++ b/tools/testing/selftests/rcutorture/bin/torture.sh
@@ -72,7 +72,7 @@ usage () {
echo " --configs-locktorture \"config-file list w/ repeat factor (10*LOCK01)\""
echo " --configs-scftorture \"config-file list w/ repeat factor (2*CFLIST)\""
echo " --doall"
- echo " --doallmodconfig / --do-no-allmodconfig"
+ echo " --do-allmodconfig / --do-no-allmodconfig"
echo " --do-clocksourcewd / --do-no-clocksourcewd"
echo " --do-kasan / --do-no-kasan"
echo " --do-kcsan / --do-no-kcsan"
--
2.34.1

2022-02-09 07:16:46

by Paul E. McKenney

Subject: Re: [PATCH] rcutorture: Add missing - to `--do-allmodconfig` in usage

On Tue, Feb 08, 2022 at 07:17:37PM +0100, Paul Menzel wrote:
> Dear Paul,
>
>
> Am 08.02.22 um 19:05 schrieb Paul E. McKenney:
> > On Tue, Feb 08, 2022 at 11:52:40AM +0100, Paul Menzel wrote:
> > > The usage currently lists `--doallmodconfig`, resulting in:
> > >
> > > $ tools/testing/selftests/rcutorture/bin/torture.sh --doallmodconfig
> > > Unknown argument --doallmodconfig
> > > […]
> > >
> > > Add the missing dash for `--do-allmodconfig`.
> > >
> > > Fixes: a115a775a8d5 ("torture: Add "make allmodconfig" to torture.sh")
> > > Signed-off-by: Paul Menzel <[email protected]>
> >
> > Good eyes, thank you!
> >
> > I will add your Reported-by and your Fixes line (with attribution) to
> > this commit in -rcu:
> >
> > dbc3fa1ffb4b ("torture: Make torture.sh help message match reality")
>
> Oh, I missed that. No need to amend, and sorry for the noise.

No problem, I had to do a rebase to make a bunch of other adjustments
anyway. The updated commit should be showing up on a kernel.org mirror
near you in the near future. ;-)

Thanx, Paul