2022-02-09 13:58:39

by Kavyasree Kotagiri

Subject: [PATCH] ARM: at91: debug: add lan966 support

Add support for low-level debugging on FLEXCOM3 USART of
LAN966 SoC.

Signed-off-by: Kavyasree Kotagiri <[email protected]>
---
arch/arm/Kconfig.debug | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 976315dea958..7989d0633188 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -210,6 +210,14 @@ choice
Say Y here if you want kernel low-level debugging support
on the FLEXCOM3 port of SAMA7G5.

+ config DEBUG_AT91_LAN966_FLEXCOM3
+ bool "Kernel low-level debugging on LAN966 FLEXCOM3 USART"
+ select DEBUG_AT91_UART
+ depends on SOC_LAN966
+ help
+ Say Y here if you want kernel low-level debugging support
+ on the FLEXCOM3 port of LAN966.
+
config DEBUG_BCM2835
bool "Kernel low-level debugging on BCM2835 PL011 UART"
depends on ARCH_BCM2835 && ARCH_MULTI_V6
@@ -1685,6 +1693,7 @@ config DEBUG_UART_PHYS
default 0xd4017000 if DEBUG_MMP_UART2
default 0xd4018000 if DEBUG_MMP_UART3
default 0xe0000000 if DEBUG_SPEAR13XX
+ default 0xe0040200 if DEBUG_AT91_LAN966_FLEXCOM3
default 0xe1824200 if DEBUG_AT91_SAMA7G5_FLEXCOM3
default 0xe4007000 if DEBUG_HIP04_UART
default 0xe6c40000 if DEBUG_RMOBILE_SCIFA0
@@ -1805,6 +1814,7 @@ config DEBUG_UART_VIRT
default 0xfb10c000 if DEBUG_REALVIEW_PB1176_PORT
default 0xfcfe8600 if DEBUG_BCM63XX_UART
default 0xfd000000 if DEBUG_SPEAR3XX || DEBUG_SPEAR13XX
+ default 0xfd040200 if DEBUG_AT91_LAN966_FLEXCOM3
default 0xfd531000 if DEBUG_STIH41X_SBC_ASC1
default 0xfd883000 if DEBUG_ALPINE_UART0
default 0xfdd32000 if DEBUG_STIH41X_ASC2
--
2.17.1

2022-02-15 16:56:32

by Michael Walle

Subject: Re: [PATCH] ARM: at91: debug: add lan966 support

Hi,

> Add support for low-level debugging on FLEXCOM3 USART of
> LAN966 SoC.
>
> Signed-off-by: Kavyasree Kotagiri <[email protected]>
> ---
> arch/arm/Kconfig.debug | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 976315dea958..7989d0633188 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -210,6 +210,14 @@ choice
> Say Y here if you want kernel low-level debugging support
> on the FLEXCOM3 port of SAMA7G5.
>
> + config DEBUG_AT91_LAN966_FLEXCOM3

Can we use DEBUG_AT91_LAN966_FLEXCOM here and provide a table with
all the different offsets for all flexcoms, and maybe default to flexcom0
(or flexcom3, I'm not sure).

> + bool "Kernel low-level debugging on LAN966 FLEXCOM3 USART"
> + select DEBUG_AT91_UART
> + depends on SOC_LAN966
> + help
> + Say Y here if you want kernel low-level debugging support
> + on the FLEXCOM3 port of LAN966.
> +
> config DEBUG_BCM2835
> bool "Kernel low-level debugging on BCM2835 PL011 UART"
> depends on ARCH_BCM2835 && ARCH_MULTI_V6
> @@ -1685,6 +1693,7 @@ config DEBUG_UART_PHYS
> default 0xd4017000 if DEBUG_MMP_UART2
> default 0xd4018000 if DEBUG_MMP_UART3
> default 0xe0000000 if DEBUG_SPEAR13XX
> + default 0xe0040200 if DEBUG_AT91_LAN966_FLEXCOM3

This is the base address of the flexcom0 uart, not flexcom3.

-michael