2022-02-09 20:51:15

by Leonardo Araujo

Subject: [PATCH] Staging: r8188eu: core: Comparisons should place the constant on the right side of the test

This patch fixes the following checkpatch.pl warning:

WARNING: Comparisons should place the constant on the right side of the test

Signed-off-by: Leonardo Araujo <[email protected]>
---
drivers/staging/r8188eu/core/rtw_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
index c7e8602d2097..a9a5453aa1cc 100644
--- a/drivers/staging/r8188eu/core/rtw_cmd.c
+++ b/drivers/staging/r8188eu/core/rtw_cmd.c
@@ -188,7 +188,7 @@ u32 rtw_enqueue_cmd(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)
cmd_obj->padapter = padapter;

res = rtw_cmd_filter(pcmdpriv, cmd_obj);
- if (_FAIL == res) {
+ if (res == _FAIL) {
rtw_free_cmd_obj(cmd_obj);
goto exit;
}
--
2.29.0

2022-02-09 23:38:36

by Pavel Skripkin

Subject: Re: [PATCH] Staging: r8188eu: core: Comparisons should place the constant on the right side of the test

Hi Leonardo,

On 2/9/22 23:27, Leonardo Araujo wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: Comparisons should place the constant on the right side of the test
>
> Signed-off-by: Leonardo Araujo <[email protected]>
> ---
> drivers/staging/r8188eu/core/rtw_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
> index a9a5453aa1cc..e236316188c1 100644
> --- a/drivers/staging/r8188eu/core/rtw_cmd.c
> +++ b/drivers/staging/r8188eu/core/rtw_cmd.c
> @@ -618,7 +618,7 @@ u8 rtw_disassoc_cmd(struct adapter *padapter, u32 deauth_timeout_ms, bool enqueu
> res = rtw_enqueue_cmd(cmdpriv, cmdobj);
> } else {
> /* no need to enqueue, do the cmd hdl directly and free cmd parameter */
> - if (H2C_SUCCESS != disconnect_hdl(padapter, (u8 *)param))
> + if (disconnect_hdl(padapter, (u8 *)param) != H2C_SUCCESS)

Actually disconnect_hdl() always return H2C_SUCCESS. Looks like this
check can be dropped completely

Unfortunately, we can't make it return void, since it's used as part of
wlancmds array :(



With regards,
Pavel Skripkin

2022-02-10 08:15:43

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: r8188eu: core: Comparisons should place the constant on the right side of the test

On Wed, Feb 09, 2022 at 05:20:15PM -0300, Leonardo Araujo wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: Comparisons should place the constant on the right side of the test
>
> Signed-off-by: Leonardo Araujo <[email protected]>
> ---
> drivers/staging/r8188eu/core/rtw_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Also you need to properly cc: the relevant maintainers, as
get_maintainer.pl will show you.

I have dropped all of your pending patches from my queue. Please fix
them up and send a patch series.

thanks,

greg k-h