2022-02-10 08:08:04

by Kavyasree Kotagiri

Subject: [PATCH 1/2] mfd: dt-bindings: add bindings for lan966 flexcom shared configurations

This adds LAN966 SoC DT bindings documentation for Flexcom
Shared and chip-select configurations.

Signed-off-by: Kavyasree Kotagiri <[email protected]>
---
.../devicetree/bindings/mfd/atmel-flexcom.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
index 692300117c64..a76622082228 100644
--- a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
+++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
@@ -18,6 +18,15 @@ Required properties:
- <2> for SPI
- <3> for I2C

+Optional properties:
+- Flexcom shared configurations: Each flexcom of lan966 SoC has 2 chip selects.
+ For each chip select, there is a pin configuration register.
+ The width of the configuration register is 21 because there are 21 shared
+ pins on each of which the chip select can be mapped. Each bit of the
+ configuration register represents a different FLEXCOM_SHARED pin.
+ - lan966x-ss-pin: Should be a flexcom shared pin.
+ - lan966x-cs: Should be chip select 0 or 1.
+
Required child:
A single available child device of type matching the "atmel,flexcom-mode"
property.
@@ -41,6 +50,9 @@ flexcom@f8034000 {
#size-cells = <1>;
ranges = <0x0 0xf8034000 0x800>;
atmel,flexcom-mode = <2>;
+ /* Map chip-select index 0 of the flexcom to FLEXCOM_SHARED 9 */
+ lan966x-ss-pin = <9>;
+ lan966x-cs = <0>;

spi@400 {
compatible = "atmel,at91rm9200-spi";
--
2.17.1

2022-02-10 08:31:25

by Tudor Ambarus

Subject: Re: [PATCH 1/2] mfd: dt-bindings: add bindings for lan966 flexcom shared configurations

Hi, Kavya,

On 2/10/22 09:45, Kavyasree Kotagiri wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> This adds LAN966 SoC DT bindings documentation for Flexcom
> Shared and chip-select configurations.
>
> Signed-off-by: Kavyasree Kotagiri <[email protected]>
> ---
> .../devicetree/bindings/mfd/atmel-flexcom.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>

Would you please convert the bindings file to yaml before adding new
properties? You can find some guidelines at:
https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-schema.html

Cheers,
ta

> diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> index 692300117c64..a76622082228 100644
> --- a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> +++ b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
> @@ -18,6 +18,15 @@ Required properties:
> - <2> for SPI
> - <3> for I2C
>
> +Optional properties:
> +- Flexcom shared configurations: Each flexcom of lan966 SoC has 2 chip selects.
> + For each chip select, there is a pin configuration register.
> + The width of the configuration register is 21 because there are 21 shared
> + pins on each of which the chip select can be mapped. Each bit of the
> + configuration register represents a different FLEXCOM_SHARED pin.
> + - lan966x-ss-pin: Should be a flexcom shared pin.
> + - lan966x-cs: Should be chip select 0 or 1.
> +
> Required child:
> A single available child device of type matching the "atmel,flexcom-mode"
> property.
> @@ -41,6 +50,9 @@ flexcom@f8034000 {
> #size-cells = <1>;
> ranges = <0x0 0xf8034000 0x800>;
> atmel,flexcom-mode = <2>;
> + /* Map chip-select index 0 of the flexcom to FLEXCOM_SHARED 9 */
> + lan966x-ss-pin = <9>;
> + lan966x-cs = <0>;
>
> spi@400 {
> compatible = "atmel,at91rm9200-spi";
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel