2022-02-10 05:52:17

by NeilBrown

Subject: [PATCH 10/11] block/bfq-iosched.c: use "false" rather than "BLK_RW_ASYNC"

bfq_get_queue() expects a "bool" for the third arg, so pass "false"
rather than "BLK_RW_ASYNC" which will soon be removed.

Acked-by: Jens Axboe <[email protected]>
Signed-off-by: NeilBrown <[email protected]>
---
block/bfq-iosched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index 0c612a911696..4e645ae1e066 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -5448,7 +5448,7 @@ static void bfq_check_ioprio_change(struct bfq_io_cq *bic, struct bio *bio)
bfqq = bic_to_bfqq(bic, false);
if (bfqq) {
bfq_release_process_ref(bfqd, bfqq);
- bfqq = bfq_get_queue(bfqd, bio, BLK_RW_ASYNC, bic, true);
+ bfqq = bfq_get_queue(bfqd, bio, false, bic, true);
bic_set_bfqq(bic, bfqq, false);
}

2022-02-10 13:30:15

by Jan Kara

Subject: Re: [PATCH 10/11] block/bfq-iosched.c: use "false" rather than "BLK_RW_ASYNC"

On Thu 10-02-22 16:37:52, NeilBrown wrote:
> bfq_get_queue() expects a "bool" for the third arg, so pass "false"
> rather than "BLK_RW_ASYNC" which will soon be removed.
>
> Acked-by: Jens Axboe <[email protected]>
> Signed-off-by: NeilBrown <[email protected]>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> block/bfq-iosched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> index 0c612a911696..4e645ae1e066 100644
> --- a/block/bfq-iosched.c
> +++ b/block/bfq-iosched.c
> @@ -5448,7 +5448,7 @@ static void bfq_check_ioprio_change(struct bfq_io_cq *bic, struct bio *bio)
> bfqq = bic_to_bfqq(bic, false);
> if (bfqq) {
> bfq_release_process_ref(bfqd, bfqq);
> - bfqq = bfq_get_queue(bfqd, bio, BLK_RW_ASYNC, bic, true);
> + bfqq = bfq_get_queue(bfqd, bio, false, bic, true);
> bic_set_bfqq(bic, bfqq, false);
> }
>
>
>
--
Jan Kara <[email protected]>
SUSE Labs, CR