2022-02-11 13:55:38

by Cai Huoqing

Subject: [PATCH v2] usbip: vudc: Make use of the helper macro LIST_HEAD()

Replace "struct list_head head = LIST_HEAD_INIT(head)" with
"LIST_HEAD(head)" to simplify the code.

LIST_HEAD() helps to clean up the code "struct list_head vudc_devices =",
only to care about the variable 'vudc_devices'.

Signed-off-by: Cai Huoqing <[email protected]>
---
v1->v2: update the changelog to explain why this change simplifies the code.

drivers/usb/usbip/vudc_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/usbip/vudc_main.c b/drivers/usb/usbip/vudc_main.c
index 678faa82598c..d43252b77efd 100644
--- a/drivers/usb/usbip/vudc_main.c
+++ b/drivers/usb/usbip/vudc_main.c
@@ -26,7 +26,7 @@ static struct platform_driver vudc_driver = {
},
};

-static struct list_head vudc_devices = LIST_HEAD_INIT(vudc_devices);
+static LIST_HEAD(vudc_devices);

static int __init init(void)
{
--
2.25.1

2022-02-12 18:22:12

by Shuah Khan

Subject: Re: [PATCH v2] usbip: vudc: Make use of the helper macro LIST_HEAD()

On 2/10/22 6:28 PM, Cai Huoqing wrote:
> Replace "struct list_head head = LIST_HEAD_INIT(head)" with
> "LIST_HEAD(head)" to simplify the code.
>
> LIST_HEAD() helps to clean up the code "struct list_head vudc_devices =",
> only to care about the variable 'vudc_devices'.
>
> Signed-off-by: Cai Huoqing <[email protected]>
> ---
> v1->v2: update the changelog to explain why this change simplifies the code.
>
> drivers/usb/usbip/vudc_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/usbip/vudc_main.c b/drivers/usb/usbip/vudc_main.c
> index 678faa82598c..d43252b77efd 100644
> --- a/drivers/usb/usbip/vudc_main.c
> +++ b/drivers/usb/usbip/vudc_main.c
> @@ -26,7 +26,7 @@ static struct platform_driver vudc_driver = {
> },
> };
>
> -static struct list_head vudc_devices = LIST_HEAD_INIT(vudc_devices);
> +static LIST_HEAD(vudc_devices);
>
> static int __init init(void)
> {
>

Hi Greg,

Please pick this up.

Reviewed-by: Shuah Khan <[email protected]>

thanks,
-- Shuah