2022-02-15 08:20:16

by Yang Li

Subject: [PATCH -next] dpaa2-eth: Simplify bool conversion

Fix the following coccicheck warnings:
./drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1199:42-47: WARNING:
conversion to bool not needed here
./drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1218:54-59: WARNING:
conversion to bool not needed here

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
index c4a48e6f1758..3e709c8fb961 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -1196,7 +1196,7 @@ static int dpaa2_eth_build_gso_fd(struct dpaa2_eth_priv *priv,
/* Setup the SG entry for the header */
dpaa2_sg_set_addr(sgt, tso_hdr_dma);
dpaa2_sg_set_len(sgt, hdr_len);
- dpaa2_sg_set_final(sgt, data_left > 0 ? false : true);
+ dpaa2_sg_set_final(sgt, data_left <= 0);

/* Compose the SG entries for each fragment of data */
num_sge = 1;
@@ -1215,7 +1215,7 @@ static int dpaa2_eth_build_gso_fd(struct dpaa2_eth_priv *priv,
}
dpaa2_sg_set_addr(sgt, addr);
dpaa2_sg_set_len(sgt, size);
- dpaa2_sg_set_final(sgt, size == data_left ? true : false);
+ dpaa2_sg_set_final(sgt, size == data_left);

num_sge++;

--
2.20.1.7.g153144c

2022-02-15 15:28:08

by Ioana Ciornei

Subject: Re: [PATCH -next] dpaa2-eth: Simplify bool conversion

On Tue, Feb 15, 2022 at 09:09:13AM +0800, Yang Li wrote:
> Fix the following coccicheck warnings:
> ./drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1199:42-47: WARNING:
> conversion to bool not needed here
> ./drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1218:54-59: WARNING:
> conversion to bool not needed here
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Ioana Ciornei <[email protected]>

2022-02-15 22:50:03

by patchwork-bot+netdevbpf

Subject: Re: [PATCH -next] dpaa2-eth: Simplify bool conversion

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Tue, 15 Feb 2022 09:09:13 +0800 you wrote:
> Fix the following coccicheck warnings:
> ./drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1199:42-47: WARNING:
> conversion to bool not needed here
> ./drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1218:54-59: WARNING:
> conversion to bool not needed here
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
>
> [...]

Here is the summary with links:
- [-next] dpaa2-eth: Simplify bool conversion
https://git.kernel.org/netdev/net-next/c/99cd6a64e128

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html