2022-02-16 00:56:32

by Lino Sanfilippo

[permalink] [raw]
Subject: [PATCH 2 7/9] serial: imx: remove redundant assignment in rs485_config

In uart_set_rs485_config() the serial core already assigns the passed
serial_rs485 struct to the uart port.

So remove the assignment in the drivers rs485_config() function to avoid
reduncancy.

Signed-off-by: Lino Sanfilippo <[email protected]>
---
drivers/tty/serial/imx.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 0b467ce8d737..ab56ff23e8a9 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -1937,8 +1937,6 @@ static int imx_uart_rs485_config(struct uart_port *port,
rs485conf->flags & SER_RS485_RX_DURING_TX)
imx_uart_start_rx(port);

- port->rs485 = *rs485conf;
-
return 0;
}

--
2.34.1


2022-02-16 18:21:04

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH 2 7/9] serial: imx: remove redundant assignment in rs485_config

On Wed, Feb 16, 2022 at 01:18:01AM +0100, Lino Sanfilippo wrote:
> In uart_set_rs485_config() the serial core already assigns the passed
> serial_rs485 struct to the uart port.
>
> So remove the assignment in the drivers rs485_config() function to avoid
> reduncancy.
>
> Signed-off-by: Lino Sanfilippo <[email protected]>
Acked-by: Uwe Kleine-K?nig <[email protected]>

Thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |


Attachments:
(No filename) (572.00 B)
signature.asc (499.00 B)
Download all attachments