This patchset is the second version of my cleanup series for the
debugging macros in the driver. Its approach is as follows:
(1) Remove previously converted DBG_88E_LEVEL calls.
(2) Remove previously converted DBG_88E calls.
(3) Remove all remaining DBG_88E calls.
(4) Remove all aliased DBG_88E calls.
(5) Remove the DBG_88E macro itself, and get rid of the rtw_debug module
parameter.
(6) Fix up remaining issues and remove certain things.
The series is a from scratch re-do, as I considered this easier than
rebasing the previous set. It is rebased onto latest staging-testing tip
as of date (15th February 2022) at the time of writing, so should
hopefully apply with no issues. I've also built/tested the driver
post-modifications and corrected unused or set-but-unsed errors as I
go.
Whilst the patches are new, I've still used the v2 subject prefix to
reflect the fact that the series is related to the previous one. I've
tried to incorporate as much feedback as possible, so apologies if
something is missing. It should be in a much better state though.
In particular, in the earlier deletion patches, where necessary to
keep semantic structure, I replace deleted lines with a single semicolon
statement in if-else cases. This is then cleaned up in later patches, to
allow the review to be easier.
Phillip Potter (15):
staging: r8188eu: remove previously converted DBG_88E_LEVEL calls
staging: r8188eu: remove smaller sets of converted DBG_88E calls
staging: r8188eu: remove converted DBG_88E calls from
core/rtw_mlme_ext.c
staging: r8188eu: remove DBG_88E calls from core subdir
staging: r8188eu: remove DBG_88E calls from hal subdir
staging: r8188eu: remove DBG_88E calls from os_dep/ioctl_linux.c
staging: r8188eu: remove remaining DBG_88E calls from os_dep subdir
staging: r8188eu: remove remaining DBG_88E call from include/usb_ops.h
staging: r8188eu: remove all aliased DBG_88E calls
staging: r8188eu: remove DBG_88E macro definition
staging: r8188eu: remove rtw_debug module parameter
staging: r8188eu: fix lines modified by DBG_88E cleanup
staging: r8188eu: remove rtw_sctx_chk_waring_status function
staging: r8188eu: remove padapter param from aes_decipher function
staging: r8188eu: correct long line warnings near prior DBG_88E calls
drivers/staging/r8188eu/Makefile | 1 -
drivers/staging/r8188eu/core/rtw_ap.c | 69 ---
drivers/staging/r8188eu/core/rtw_br_ext.c | 67 +--
drivers/staging/r8188eu/core/rtw_cmd.c | 14 +-
drivers/staging/r8188eu/core/rtw_fw.c | 23 +-
drivers/staging/r8188eu/core/rtw_ieee80211.c | 37 +-
drivers/staging/r8188eu/core/rtw_ioctl_set.c | 10 -
drivers/staging/r8188eu/core/rtw_iol.c | 12 +-
drivers/staging/r8188eu/core/rtw_mlme.c | 66 +--
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 411 ++----------------
drivers/staging/r8188eu/core/rtw_p2p.c | 69 +--
drivers/staging/r8188eu/core/rtw_pwrctrl.c | 45 +-
drivers/staging/r8188eu/core/rtw_recv.c | 71 +--
drivers/staging/r8188eu/core/rtw_security.c | 19 +-
drivers/staging/r8188eu/core/rtw_sta_mgt.c | 10 +-
drivers/staging/r8188eu/core/rtw_wlan_util.c | 97 +----
drivers/staging/r8188eu/core/rtw_xmit.c | 78 +---
drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 4 +-
drivers/staging/r8188eu/hal/hal_intf.c | 3 -
drivers/staging/r8188eu/hal/odm_debug.c | 6 -
drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 46 +-
.../staging/r8188eu/hal/rtl8188e_hal_init.c | 71 +--
drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 3 -
drivers/staging/r8188eu/hal/rtl8188eu_recv.c | 5 -
drivers/staging/r8188eu/hal/rtl8188eu_xmit.c | 9 +-
drivers/staging/r8188eu/hal/usb_halinit.c | 62 +--
drivers/staging/r8188eu/hal/usb_ops_linux.c | 29 +-
drivers/staging/r8188eu/include/rtw_br_ext.h | 5 -
drivers/staging/r8188eu/include/rtw_debug.h | 8 -
drivers/staging/r8188eu/include/usb_ops.h | 6 +-
drivers/staging/r8188eu/os_dep/ioctl_linux.c | 377 +---------------
drivers/staging/r8188eu/os_dep/mlme_linux.c | 4 -
drivers/staging/r8188eu/os_dep/os_intfs.c | 37 +-
drivers/staging/r8188eu/os_dep/usb_intf.c | 79 +---
.../staging/r8188eu/os_dep/usb_ops_linux.c | 15 +-
drivers/staging/r8188eu/os_dep/xmit_linux.c | 6 +-
36 files changed, 184 insertions(+), 1690 deletions(-)
delete mode 100644 drivers/staging/r8188eu/hal/odm_debug.c
--
2.34.1