2022-02-16 08:12:13

by Oleksij Rempel

Subject: [PATCH v5 4/9] ARM: dts: bcm283x: fix ethernet node name

It should be "ethernet@x" instead of "usbether@x" as required by Ethernet
controller devicetree schema:
Documentation/devicetree/bindings/net/ethernet-controller.yaml

This patch can potentially affect boot loaders patching against full
node path instead of using device aliases.

Signed-off-by: Oleksij Rempel <[email protected]>
---
arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi | 2 +-
arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi b/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
index 967e081cb9c2..882b13807075 100644
--- a/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
+++ b/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
@@ -12,7 +12,7 @@ usb1@1 {
#address-cells = <1>;
#size-cells = <0>;

- ethernet: usbether@1 {
+ ethernet: ethernet@1 {
compatible = "usb424,ec00";
reg = <1>;
};
diff --git a/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi b/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
index dc7ae776db5f..4273b90b53cc 100644
--- a/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
+++ b/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
@@ -11,7 +11,7 @@ usb1@1 {
#address-cells = <1>;
#size-cells = <0>;

- ethernet: usbether@1 {
+ ethernet: ethernet@1 {
compatible = "usb424,ec00";
reg = <1>;
};
--
2.30.2

2022-04-05 02:22:39

by Florian Fainelli

Subject: Re: [PATCH v5 4/9] ARM: dts: bcm283x: fix ethernet node name

On Wed, 16 Feb 2022 08:49:22 +0100, Oleksij Rempel <[email protected]> wrote:
> It should be "ethernet@x" instead of "usbether@x" as required by Ethernet
> controller devicetree schema:
> Documentation/devicetree/bindings/net/ethernet-controller.yaml
>
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.
>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian