2022-02-16 08:33:32

by Xu Wang

Subject: [PATCH net-next] s390/qeth: Remove redundant 'flush_workqueue()' calls

'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

Signed-off-by: Xu Wang <[email protected]>
Acked-by: Alexandra Winter <[email protected]>
---
drivers/s390/net/qeth_l3_main.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
index 9251ad276ee8..d2f422a9a4f7 100644
--- a/drivers/s390/net/qeth_l3_main.c
+++ b/drivers/s390/net/qeth_l3_main.c
@@ -1961,7 +1961,6 @@ static void qeth_l3_remove_device(struct ccwgroup_device *cgdev)
if (card->dev->reg_state == NETREG_REGISTERED)
unregister_netdev(card->dev);

- flush_workqueue(card->cmd_wq);
destroy_workqueue(card->cmd_wq);
qeth_l3_clear_ip_htable(card, 0);
qeth_l3_clear_ipato_list(card);
--
2.25.1

2022-02-18 05:37:43

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] s390/qeth: Remove redundant 'flush_workqueue()' calls

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Wed, 16 Feb 2022 07:51:55 +0000 you wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> Signed-off-by: Xu Wang <[email protected]>
> Acked-by: Alexandra Winter <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] s390/qeth: Remove redundant 'flush_workqueue()' calls
https://git.kernel.org/netdev/net-next/c/129c77b5692d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html