2022-02-16 11:50:20

by Yue Haibing

Subject: [PATCH -next] drm/amdgpu: Remove unused function get_umc_v6_7_channel_index()

This is unused after commit 37ff945f804c ("drm/amdgpu: fix convert bad page retiremt")

Signed-off-by: YueHaibing <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/umc_v6_7.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v6_7.c b/drivers/gpu/drm/amd/amdgpu/umc_v6_7.c
index f5a1ba7db75a..00f87e3c6b0e 100644
--- a/drivers/gpu/drm/amd/amdgpu/umc_v6_7.c
+++ b/drivers/gpu/drm/amd/amdgpu/umc_v6_7.c
@@ -50,13 +50,6 @@ static inline uint32_t get_umc_v6_7_reg_offset(struct amdgpu_device *adev,
return adev->umc.channel_offs * ch_inst + UMC_V6_7_INST_DIST * umc_inst;
}

-static inline uint32_t get_umc_v6_7_channel_index(struct amdgpu_device *adev,
- uint32_t umc_inst,
- uint32_t ch_inst)
-{
- return adev->umc.channel_idx_tbl[umc_inst * adev->umc.channel_inst_num + ch_inst];
-}
-
static void umc_v6_7_ecc_info_query_correctable_error_count(struct amdgpu_device *adev,
uint32_t umc_inst, uint32_t ch_inst,
unsigned long *error_count)
--
2.17.1

2022-02-17 23:53:15

by Alex Deucher

Subject: Re: [PATCH -next] drm/amdgpu: Remove unused function get_umc_v6_7_channel_index()

Acked-by: Alex Deucher <[email protected]>

On Wed, Feb 16, 2022 at 6:58 AM YueHaibing <[email protected]> wrote:
>
> This is unused after commit 37ff945f804c ("drm/amdgpu: fix convert bad page retiremt")
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/umc_v6_7.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v6_7.c b/drivers/gpu/drm/amd/amdgpu/umc_v6_7.c
> index f5a1ba7db75a..00f87e3c6b0e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/umc_v6_7.c
> +++ b/drivers/gpu/drm/amd/amdgpu/umc_v6_7.c
> @@ -50,13 +50,6 @@ static inline uint32_t get_umc_v6_7_reg_offset(struct amdgpu_device *adev,
> return adev->umc.channel_offs * ch_inst + UMC_V6_7_INST_DIST * umc_inst;
> }
>
> -static inline uint32_t get_umc_v6_7_channel_index(struct amdgpu_device *adev,
> - uint32_t umc_inst,
> - uint32_t ch_inst)
> -{
> - return adev->umc.channel_idx_tbl[umc_inst * adev->umc.channel_inst_num + ch_inst];
> -}
> -
> static void umc_v6_7_ecc_info_query_correctable_error_count(struct amdgpu_device *adev,
> uint32_t umc_inst, uint32_t ch_inst,
> unsigned long *error_count)
> --
> 2.17.1
>