2022-02-20 12:47:45

by Souptick Joarder

Subject: [PATCH] bpf: Initialize ret to 0 inside btf_populate_kfunc_set()

From: "Souptick Joarder (HPE)" <[email protected]>

Kernel test robot reported below error ->

kernel/bpf/btf.c:6718 btf_populate_kfunc_set()
error: uninitialized symbol 'ret'.

Initialize ret to 0.

Fixes: dee872e124e8 ("bpf: Populate kfunc BTF ID sets in struct btf")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Souptick Joarder (HPE) <[email protected]>
---
kernel/bpf/btf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
index 02d7014417a0..2c4c5dbe2abe 100644
--- a/kernel/bpf/btf.c
+++ b/kernel/bpf/btf.c
@@ -6706,7 +6706,7 @@ static int btf_populate_kfunc_set(struct btf *btf, enum btf_kfunc_hook hook,
const struct btf_kfunc_id_set *kset)
{
bool vmlinux_set = !btf_is_module(btf);
- int type, ret;
+ int type, ret = 0;

for (type = 0; type < ARRAY_SIZE(kset->sets); type++) {
if (!kset->sets[type])
--
2.25.1

2022-02-21 05:41:09

by Kumar Kartikeya Dwivedi

Subject: Re: [PATCH] bpf: Initialize ret to 0 inside btf_populate_kfunc_set()

On Sat, Feb 19, 2022 at 10:09:15PM IST, Souptick Joarder wrote:
> From: "Souptick Joarder (HPE)" <[email protected]>
>
> Kernel test robot reported below error ->
>
> kernel/bpf/btf.c:6718 btf_populate_kfunc_set()
> error: uninitialized symbol 'ret'.
>
> Initialize ret to 0.
>
> Fixes: dee872e124e8 ("bpf: Populate kfunc BTF ID sets in struct btf")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Souptick Joarder (HPE) <[email protected]>
> ---

Thanks for the fix.

Acked-by: Kumar Kartikeya Dwivedi <[email protected]>

> kernel/bpf/btf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> index 02d7014417a0..2c4c5dbe2abe 100644
> --- a/kernel/bpf/btf.c
> +++ b/kernel/bpf/btf.c
> @@ -6706,7 +6706,7 @@ static int btf_populate_kfunc_set(struct btf *btf, enum btf_kfunc_hook hook,
> const struct btf_kfunc_id_set *kset)
> {
> bool vmlinux_set = !btf_is_module(btf);
> - int type, ret;
> + int type, ret = 0;
>
> for (type = 0; type < ARRAY_SIZE(kset->sets); type++) {
> if (!kset->sets[type])
> --
> 2.25.1
>

--
Kartikeya

2022-02-21 09:53:00

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] bpf: Initialize ret to 0 inside btf_populate_kfunc_set()

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <[email protected]>:

On Sat, 19 Feb 2022 22:09:15 +0530 you wrote:
> From: "Souptick Joarder (HPE)" <[email protected]>
>
> Kernel test robot reported below error ->
>
> kernel/bpf/btf.c:6718 btf_populate_kfunc_set()
> error: uninitialized symbol 'ret'.
>
> [...]

Here is the summary with links:
- bpf: Initialize ret to 0 inside btf_populate_kfunc_set()
https://git.kernel.org/bpf/bpf-next/c/d0b3822902b6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html