2022-02-22 05:56:39

by Vinod Koul

[permalink] [raw]
Subject: [PATCH] arm64: defconfig: Enable Qualcomm GPI DMA Driver

Qualcomm GPI DMA Driver is used for DMA transfers for Serial engines
like Geni I2C and SPI.

Enable this dma driver

Signed-off-by: Vinod Koul <[email protected]>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 30516dc0b70e..d73913f082d7 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -948,6 +948,7 @@ CONFIG_PL330_DMA=y
CONFIG_TEGRA20_APB_DMA=y
CONFIG_TEGRA210_ADMA=m
CONFIG_QCOM_BAM_DMA=y
+CONFIG_QCOM_GPI_DMA=y
CONFIG_QCOM_HIDMA_MGMT=y
CONFIG_QCOM_HIDMA=y
CONFIG_RCAR_DMAC=y
--
2.34.1


2022-02-24 03:35:15

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: defconfig: Enable Qualcomm GPI DMA Driver

On Mon 21 Feb 22:24 CST 2022, Vinod Koul wrote:

> Qualcomm GPI DMA Driver is used for DMA transfers for Serial engines
> like Geni I2C and SPI.
>
> Enable this dma driver
>

Can you please include a motivation in the commit message why this has
to be builtin?

Thanks,
Bjorn

> Signed-off-by: Vinod Koul <[email protected]>
> ---
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 30516dc0b70e..d73913f082d7 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -948,6 +948,7 @@ CONFIG_PL330_DMA=y
> CONFIG_TEGRA20_APB_DMA=y
> CONFIG_TEGRA210_ADMA=m
> CONFIG_QCOM_BAM_DMA=y
> +CONFIG_QCOM_GPI_DMA=y
> CONFIG_QCOM_HIDMA_MGMT=y
> CONFIG_QCOM_HIDMA=y
> CONFIG_RCAR_DMAC=y
> --
> 2.34.1
>

2022-02-24 05:16:40

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] arm64: defconfig: Enable Qualcomm GPI DMA Driver

On 23-02-22, 21:28, Bjorn Andersson wrote:
> On Mon 21 Feb 22:24 CST 2022, Vinod Koul wrote:
>
> > Qualcomm GPI DMA Driver is used for DMA transfers for Serial engines
> > like Geni I2C and SPI.
> >
> > Enable this dma driver
> >
>
> Can you please include a motivation in the commit message why this has
> to be builtin?

Sure, traditionally DMAengine drivers are always initialized early on (typically most
of the drivers are arch init level) so that it is available to users
early on as well..

Current config has many dmaengine drivers as inbuilt...

Will add more details and send

>
> Thanks,
> Bjorn
>
> > Signed-off-by: Vinod Koul <[email protected]>
> > ---
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 30516dc0b70e..d73913f082d7 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -948,6 +948,7 @@ CONFIG_PL330_DMA=y
> > CONFIG_TEGRA20_APB_DMA=y
> > CONFIG_TEGRA210_ADMA=m
> > CONFIG_QCOM_BAM_DMA=y
> > +CONFIG_QCOM_GPI_DMA=y
> > CONFIG_QCOM_HIDMA_MGMT=y
> > CONFIG_QCOM_HIDMA=y
> > CONFIG_RCAR_DMAC=y
> > --
> > 2.34.1
> >

--
~Vinod