2022-02-21 12:37:23

by Michael Walle

Subject: [PATCH v4 20/32] mtd: spi-nor: guard _page_size parameter in S3AN_INFO()

The _page_size marco parameter was missing parentheses around it. Add
them.

Signed-off-by: Michael Walle <[email protected]>
---
drivers/mtd/spi-nor/core.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h
index 446218b0e017..3c37b46d60d5 100644
--- a/drivers/mtd/spi-nor/core.h
+++ b/drivers/mtd/spi-nor/core.h
@@ -469,9 +469,9 @@ struct flash_info {
(_jedec_id) & 0xff \
}, \
.id_len = 3, \
- .sector_size = (8*_page_size), \
+ .sector_size = (8 * (_page_size)), \
.n_sectors = (_n_sectors), \
- .page_size = _page_size, \
+ .page_size = (_page_size), \
.addr_width = 3, \
.flags = SPI_NOR_NO_FR | SPI_NOR_XSR_RDY,

--
2.30.2

2022-02-22 07:30:11

by Pratyush Yadav

Subject: Re: [PATCH v4 20/32] mtd: spi-nor: guard _page_size parameter in S3AN_INFO()

On 21/02/22 01:07PM, Michael Walle wrote:
> The _page_size marco parameter was missing parentheses around it. Add
> them.
>
> Signed-off-by: Michael Walle <[email protected]>

Reviewed-by: Pratyush Yadav <[email protected]>

--
Regards,
Pratyush Yadav
Texas Instruments Inc.