2022-02-23 04:31:18

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: Re: [PATCH v2 15/23] arm64: dts: mt8192: Add m4u and smi nodes

On Fri, Feb 18, 2022 at 05:16:25PM +0800, Allen-KH Cheng wrote:
> + larb16: larb@1a00f000 {
> + compatible = "mediatek,mt8192-smi-larb";
> + reg = <0 0x1a00f000 0 0x1000>;
> + mediatek,larb-id = <16>;
> + mediatek,smi = <&smi_common>;
> + clocks = <&camsys_rawa CLK_CAM_RAWA_CAM>,
> + <&camsys_rawa CLK_CAM_RAWA_LARBX>;
> + clock-names = "apb", "smi";
> + mediatek,smi-id = <16>;

This mediatek,smi-id property isn't handled in the driver or mentioned in the
dt-binding, and seems redundant to mediatek,larb-id. So just drop it.

Other than that,

Reviewed-by: N?colas F. R. A. Prado <[email protected]>