2022-02-23 13:40:29

by Michael Riesch

Subject: [PATCH] arm64: dts: rockchip: set vdd_gpu regulator on rk3568-evb1-v10 to always on

As discussed in [0], the Rockchip power domain driver does not consider
the external supplies (such as VDD_GPU on the RK3568 EVB1). In the scope of
this discussion it has been pointed out that turning this voltage on/off
on the fly is not explicitly supported. This patch follows the other RK356x
boards by example and sets the vdd_gpu regulator to always on.

[0] https://lore.kernel.org/linux-rockchip/[email protected]/

Signed-off-by: Michael Riesch <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
index f3d0bc259166..bb7177ff92ac 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
@@ -219,6 +219,7 @@ regulator-state-mem {

vdd_gpu: DCDC_REG2 {
regulator-name = "vdd_gpu";
+ regulator-always-on;
regulator-init-microvolt = <900000>;
regulator-initial-mode = <0x2>;
regulator-min-microvolt = <500000>;
--
2.30.2

2022-02-24 01:13:52

by Heiko Stuebner

Subject: Re: [PATCH] arm64: dts: rockchip: set vdd_gpu regulator on rk3568-evb1-v10 to always on

On Wed, 23 Feb 2022 12:20:08 +0100, Michael Riesch wrote:
> As discussed in [0], the Rockchip power domain driver does not consider
> the external supplies (such as VDD_GPU on the RK3568 EVB1). In the scope of
> this discussion it has been pointed out that turning this voltage on/off
> on the fly is not explicitly supported. This patch follows the other RK356x
> boards by example and sets the vdd_gpu regulator to always on.
>
> [0] https://lore.kernel.org/linux-rockchip/[email protected]/

Applied, thanks!

[1/1] arm64: dts: rockchip: set vdd_gpu regulator on rk3568-evb1-v10 to always on
commit: bbe5d394c76bd534a0819f78a900ac1a83f3ee9e

Best regards,
--
Heiko Stuebner <[email protected]>