Add device tree bindings for the ADA4250 driver.
Signed-off-by: Antoniu Miclaus <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
changes in v6:
- add space before `{` in the amplifier node example
.../bindings/iio/amplifiers/adi,ada4250.yaml | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
new file mode 100644
index 000000000000..5277479be382
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/amplifiers/adi,ada4250.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ADA4250 Programmable Gain Instrumentation Amplifier
+
+maintainers:
+ - Antoniu Miclaus <[email protected]>
+
+description: |
+ Precision Low Power, 110kHz, 26uA, Programmable Gain Instrumentation Amplifier.
+
+properties:
+ compatible:
+ enum:
+ - adi,ada4250
+
+ reg:
+ maxItems: 1
+
+ avdd-supply: true
+
+ adi,refbuf-enable:
+ description:
+ Enable internal buffer to drive the reference pin.
+ type: boolean
+
+ spi-max-frequency: true
+
+required:
+ - compatible
+ - reg
+ - avdd-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ amplifier@0 {
+ compatible = "adi,ada4250";
+ reg = <0>;
+ avdd-supply = <&avdd>;
+ };
+ };
+...
--
2.35.1
Add myself as maintainer for the ADA4250 driver.
Signed-off-by: Antoniu Miclaus <[email protected]>
---
MAINTAINERS | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index fb18ce7168aa..0410054a7bf5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1075,6 +1075,14 @@ L: [email protected]
S: Maintained
F: drivers/media/i2c/ad9389b*
+ANALOG DEVICES INC ADA4250 DRIVER
+M: Antoniu Miclaus <[email protected]>
+L: [email protected]
+S: Supported
+W: https://ez.analog.com/linux-software-drivers
+F: Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
+F: drivers/iio/amplifiers/ada4250.c
+
ANALOG DEVICES INC ADGS1408 DRIVER
M: Mircea Caprioru <[email protected]>
S: Supported
--
2.35.1
On Wed, 23 Feb 2022 14:01:10 +0200, Antoniu Miclaus wrote:
> Add device tree bindings for the ADA4250 driver.
>
> Signed-off-by: Antoniu Miclaus <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> ---
> changes in v6:
> - add space before `{` in the amplifier node example
> .../bindings/iio/amplifiers/adi,ada4250.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
>
Reviewed-by: Rob Herring <[email protected]>
On Thu, 24 Feb 2022 10:31:17 -0600
Rob Herring <[email protected]> wrote:
> On Wed, 23 Feb 2022 14:01:10 +0200, Antoniu Miclaus wrote:
> > Add device tree bindings for the ADA4250 driver.
> >
> > Signed-off-by: Antoniu Miclaus <[email protected]>
> > Reviewed-by: Krzysztof Kozlowski <[email protected]>
> > ---
> > changes in v6:
> > - add space before `{` in the amplifier node example
> > .../bindings/iio/amplifiers/adi,ada4250.yaml | 50 +++++++++++++++++++
> > 1 file changed, 50 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
> >
>
> Reviewed-by: Rob Herring <[email protected]>
Series applied to the togreg branch of iio.git and pushed out as testing for
0-day to take a quick look before I go making a mess of linux-next.
One side comment though - when there are lots of revisions in a short timescale
and people haven't had time to get back to the intermediate ones, it is particularly
helpful to give a multi version change log.
i.e. tell us what happened in at least the last couple of revisions to save
on having to go find the earlier threads to find out what changed in v5 and v4!
Also, I always prefer a cover letter for a series even if brief. It give somewhere
to reply to if there are discussions covering multiple patches, or if someone wants
to give a tag for the whole series that I can trivially pick up with b4.
Obviously no point for single patch series though!
I don't normally moan about this, but I was moaning anyway so why not get
everything off my chest! :)
Thanks,
Jonathan