2022-02-23 16:46:31

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: Re: [PATCH v2 22/23] arm64: dts: mt8192: Add gce info for display nodes

On Wed, Feb 23, 2022 at 09:12:37PM +0800, allen-kh.cheng wrote:
> On Tue, 2022-02-22 at 18:24 -0500, N?colas F. R. A. Prado wrote:
> > On Fri, Feb 18, 2022 at 05:16:32PM +0800, Allen-KH Cheng wrote:
> > > Add gce info for display nodes.
> > >
> > > Signed-off-by: Allen-KH Cheng <[email protected]>
> > > ---
> > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 16 ++++++++++++++++
> > > 1 file changed, 16 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > > b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > > index 1f1555fd18f5..df884c48669e 100644
> > > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > > @@ -1226,6 +1226,9 @@
> > > mmsys: syscon@14000000 {
> > > compatible = "mediatek,mt8192-mmsys", "syscon";
> > > reg = <0 0x14000000 0 0x1000>;
> > > + mboxes = <&gce 0 CMDQ_THR_PRIO_HIGHEST 1>,
> > > + <&gce 1 CMDQ_THR_PRIO_HIGHEST 1>;
> > > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX
> > > 0 0x1000>;
> >
> > As a side note, the current mmsys dt-binding,
> > Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml,
> > doesn't
> > define mboxes or mediatek,gce-client-reg, but looks like there's
> > already a patch
> > in the ML adding those:
> >
> >
> https://urldefense.com/v3/__https://lore.kernel.org/all/[email protected]/__;!!CTRNKA9wMg0ARbw!zNfQkN-YYjiqPCd5m9DsLhrQDymgEZJoY4oSl24nC3R95P0gIXEmNjyJMhjQZXkWX7mZPa5QS7KIMlGXMbDjDA1_2A$
> >
>
> Hi N?colas,
>
> Thanks for your reminding, Should I need to remove this patch from
> series?
>
> or I can add this ML to base and mention it in cover letter.

I think it should be OK to just mention it in the cover letter.

Thanks,
N?colas