2022-02-24 05:42:56

by Srinivas Neeli

Subject: [PATCH] pinctrl: zynq: use module_platform_driver to simplify the code

module_platform_driver() makes the code simpler by eliminating
boilerplate code.

Signed-off-by: Srinivas Neeli <[email protected]>
---
drivers/pinctrl/pinctrl-zynq.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
index a96af8a76a7a..0e8de27d0de8 100644
--- a/drivers/pinctrl/pinctrl-zynq.c
+++ b/drivers/pinctrl/pinctrl-zynq.c
@@ -8,6 +8,7 @@
*/
#include <linux/io.h>
#include <linux/mfd/syscon.h>
+#include <linux/module.h>
#include <linux/init.h>
#include <linux/of.h>
#include <linux/platform_device.h>
@@ -1210,8 +1211,4 @@ static struct platform_driver zynq_pinctrl_driver = {
.probe = zynq_pinctrl_probe,
};

-static int __init zynq_pinctrl_init(void)
-{
- return platform_driver_register(&zynq_pinctrl_driver);
-}
-arch_initcall(zynq_pinctrl_init);
+module_platform_driver(zynq_pinctrl_driver);
--
2.17.1

2022-03-16 23:28:57

by Linus Walleij

Subject: Re: [PATCH] pinctrl: zynq: use module_platform_driver to simplify the code

On Thu, Feb 24, 2022 at 5:36 AM Srinivas Neeli
<[email protected]> wrote:

> module_platform_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Srinivas Neeli <[email protected]>

Nice, patch applied!

> -static int __init zynq_pinctrl_init(void)
> -{
> - return platform_driver_register(&zynq_pinctrl_driver);
> -}
> -arch_initcall(zynq_pinctrl_init);
> +module_platform_driver(zynq_pinctrl_driver);

This will incidentally also move the initcall from arch_initcall
to driver_initcall but I assume that works so, OK.

Yours,
Linus Walleij