2022-02-25 19:19:41

by Max Kellermann

[permalink] [raw]
Subject: [PATCH 2/4] fs/pipe: remove duplicate "offset" initializer

This code duplication was introduced by commit a194dfe6e6f6 ("pipe:
Rearrange sequence in pipe_write() to preallocate slot"), but since
the pipe's mutex is locked, nobody else can modify the value
meanwhile.

To: Alexander Viro <[email protected]>
To: [email protected]
To: [email protected]
Signed-off-by: Max Kellermann <[email protected]>
---
fs/pipe.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/pipe.c b/fs/pipe.c
index da842d13029d..aca717a89631 100644
--- a/fs/pipe.c
+++ b/fs/pipe.c
@@ -535,7 +535,6 @@ pipe_write(struct kiocb *iocb, struct iov_iter *from)
break;
}
ret += copied;
- buf->offset = 0;
buf->len = copied;

if (!iov_iter_count(from))
--
2.34.0