This patch upstreams the DDCCI driver by Christoph Grenz into
the kernel. The original gitlab page is loacted at https://gitlab
.com/ddcci-driver-linux/ddcci-driver-linux/-/tree/master.
Signed-off-by: Yusuf Khan <[email protected]>
---
drivers/Kconfig | 2 +
drivers/Makefile | 1 +
drivers/ddcci/Kconfig | 5 +
drivers/ddcci/Makefile | 3 +
drivers/ddcci/ddcci-backlight.c | 411 +++++++
drivers/ddcci/ddcci.c | 1887 +++++++++++++++++++++++++++++++
include/linux/ddcci.h | 164 +++
7 files changed, 2473 insertions(+)
create mode 100644 drivers/ddcci/Kconfig
create mode 100644 drivers/ddcci/Makefile
create mode 100644 drivers/ddcci/ddcci-backlight.c
create mode 100644 drivers/ddcci/ddcci.c
create mode 100644 include/linux/ddcci.h
diff --git a/drivers/Kconfig b/drivers/Kconfig
index 0d399ddaa185..3a58a29113f9 100644
--- a/drivers/Kconfig
+++ b/drivers/Kconfig
@@ -236,4 +236,6 @@ source "drivers/interconnect/Kconfig"
source "drivers/counter/Kconfig"
source "drivers/most/Kconfig"
+
+source "drivers/ddcci/Kconfig"
endmenu
diff --git a/drivers/Makefile b/drivers/Makefile
index a110338c860c..c9181f1dc5aa 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -21,6 +21,7 @@ obj-y += pci/
obj-$(CONFIG_PARISC) += parisc/
obj-$(CONFIG_RAPIDIO) += rapidio/
obj-y += video/
+obj-$(CONFIG_DDCCI) += ddcci/
obj-y += idle/
# IPMI must come before ACPI in order to provide IPMI opregion support
diff --git a/drivers/ddcci/Kconfig b/drivers/ddcci/Kconfig
new file mode 100644
index 000000000000..93ceebb3a379
--- /dev/null
+++ b/drivers/ddcci/Kconfig
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0-only
+menuconfig DDCCI
+ tristate "DDCCI display protocol support"
+ help
+ Say Y here if you want to have DDCCI
diff --git a/drivers/ddcci/Makefile b/drivers/ddcci/Makefile
new file mode 100644
index 000000000000..cce606be8038
--- /dev/null
+++ b/drivers/ddcci/Makefile
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0
+obj-$(CONFIG_DDCCI) += ddcci.o
+obj-$(CONFIG_DDCCI) += ddcci-backlight.o
diff --git a/drivers/ddcci/ddcci-backlight.c b/drivers/ddcci/ddcci-backlight.c
new file mode 100644
index 000000000000..8b774620780d
--- /dev/null
+++ b/drivers/ddcci/ddcci-backlight.c
@@ -0,0 +1,411 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * DDC/CI monitor backlight driver
+ *
+ * Copyright (c) 2015 Christoph Grenz
+ */
+
+/*
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the Free
+ * Software Foundation; either version 2 of the License, or (at your option)
+ * any later version.
+ */
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+#include <linux/backlight.h>
+#include <linux/module.h>
+#include <linux/fb.h>
+#include <linux/sysfs.h>
+
+#include <linux/ddcci.h>
+
+
+#define DDCCI_COMMAND_READ 0x01 /* read ctrl value */
+#define DDCCI_REPLY_READ 0x02 /* read ctrl value reply */
+#define DDCCI_COMMAND_WRITE 0x03 /* write ctrl value */
+#define DDCCI_COMMAND_SAVE 0x0c /* save current settings */
+
+#define DDCCI_MONITOR_LUMINANCE 0x10
+#define DDCCI_MONITOR_BACKLIGHT 0x13
+#define DDCCI_MONITOR_BL_WHITE 0x6B
+
+static bool convenience_symlink = true;
+
+struct ddcci_monitor_drv_data {
+ struct ddcci_device *device;
+ struct backlight_device *bl_dev;
+ struct device *fb_dev;
+ unsigned char used_vcp;
+};
+
+static int ddcci_monitor_writectrl(struct ddcci_device *device,
+ unsigned char ctrl, unsigned short value)
+{
+ unsigned char buf[4];
+ int ret;
+
+ buf[0] = DDCCI_COMMAND_WRITE;
+ buf[1] = ctrl;
+ buf[2] = (value >> 8);
+ buf[3] = (value & 255);
+
+ ret = ddcci_device_write(device, true, buf, sizeof(buf));
+
+ return ret;
+}
+
+static int ddcci_monitor_readctrl(struct ddcci_device *device,
+ unsigned char ctrl, unsigned short *value,
+ unsigned short *maximum)
+{
+ int ret;
+ unsigned char buf[10];
+
+ buf[0] = DDCCI_COMMAND_READ;
+ buf[1] = ctrl;
+
+ ret = ddcci_device_writeread(device, true, buf, 2, sizeof(buf));
+ if (ret < 0)
+ return ret;
+
+ if (ret == 0)
+ return -ENOTSUPP;
+
+ if (ret == 8 && buf[0] == DDCCI_REPLY_READ && buf[2] == ctrl) {
+ if (value)
+ *value = buf[6] * 256 + buf[7];
+
+ if (maximum)
+ *maximum = buf[4] * 256 + buf[5];
+
+ if (buf[1] == 1)
+ return -ENOTSUPP;
+ if (buf[1] != 0)
+ return -EIO;
+ return 0;
+ }
+
+ return -EIO;
+}
+
+static int ddcci_backlight_check_fb(struct backlight_device *bl,
+ struct fb_info *info)
+{
+ struct ddcci_monitor_drv_data *drv_data = bl_get_data(bl);
+
+ return drv_data->fb_dev == NULL || drv_data->fb_dev == info->dev;
+}
+
+static int ddcci_backlight_update_status(struct backlight_device *bl)
+{
+ struct ddcci_monitor_drv_data *drv_data = bl_get_data(bl);
+ int brightness = bl->props.brightness;
+ int ret;
+
+ if (bl->props.power != FB_BLANK_UNBLANK ||
+ bl->props.state & BL_CORE_FBBLANK)
+ brightness = 0;
+
+ ret = ddcci_monitor_writectrl(drv_data->device, drv_data->used_vcp,
+ brightness);
+ if (ret > 0)
+ ret = 0;
+ return ret;
+}
+
+static int ddcci_backlight_get_brightness(struct backlight_device *bl)
+{
+ unsigned short value = 0, maxval = 0;
+ int ret;
+ struct ddcci_monitor_drv_data *drv_data = bl_get_data(bl);
+
+ ret = ddcci_monitor_readctrl(drv_data->device, drv_data->used_vcp,
+ &value, &maxval);
+ if (ret < 0)
+ return ret;
+
+ bl->props.brightness = value;
+ bl->props.max_brightness = maxval;
+ ret = value;
+
+ return ret;
+}
+
+static const struct backlight_ops ddcci_backlight_ops = {
+ .options = 0,
+ .update_status = ddcci_backlight_update_status,
+ .get_brightness = ddcci_backlight_get_brightness,
+ .check_fb = ddcci_backlight_check_fb,
+};
+
+static const char *ddcci_monitor_vcp_name(unsigned char vcp)
+{
+ switch (vcp) {
+ case DDCCI_MONITOR_BL_WHITE:
+ return "backlight";
+ case DDCCI_MONITOR_LUMINANCE:
+ return "luminance";
+ default:
+ return "???";
+ }
+}
+
+static const char *ddcci_monitor_next_vcp_item(const char *ptr)
+{
+ int depth = 0;
+
+ /* Sanity check */
+ if (unlikely(ptr == NULL || ptr[0] == '\0'))
+ return NULL;
+
+ /* Find next white space outside of parentheses */
+ while ((ptr = strpbrk(ptr, " ()"))) {
+ if (!ptr || depth == INT_MAX)
+ return NULL;
+ else if (*ptr == '(') {
+ depth++;
+ else if (depth > 0) {
+ if (*ptr == ')')
+ depth--;
+ else
+ break;
+ ++ptr;
+ }
+
+ /* Skip over whitespace */
+ ptr = skip_spaces(ptr);
+
+ /* Check if we're now at the end of the list */
+ if (unlikely(*ptr == '\0' || *ptr == ')'))
+ return NULL;
+
+ return ptr;
+}
+
+static bool ddcci_monitor_find_vcp(unsigned char vcp, const char *s)
+{
+ const char *ptr = s;
+ char vcp_hex[3];
+
+ /* Sanity check */
+ if (unlikely(s == NULL || s[0] == '\0'))
+ return false;
+
+ /* Create hex representation of VCP */
+ if (unlikely(snprintf(vcp_hex, 3, "%02hhX", vcp) != 2)) {
+ pr_err("snprintf failed to convert to hex. This should not happen.\n");
+ return false;
+ }
+
+ /* Search for it */
+ do {
+ if (strncasecmp(vcp_hex, ptr, 2) == 0) {
+ if (ptr[2] == ' ' || ptr[2] == '(' || ptr[2] == ')')
+ return true;
+ }
+ } while ((ptr = ddcci_monitor_next_vcp_item(ptr)));
+
+ return false;
+}
+
+static int ddcci_backlight_create_symlink(struct ddcci_device *ddcci_dev)
+{
+ int i, result;
+ struct device *dev = &ddcci_dev->dev;
+ struct kernfs_node *dirent;
+
+ for (i = 0; i < 3; ++i) {
+ dev = dev->parent;
+ if (!dev) {
+ dev_dbg(&ddcci_dev->dev, "failed to create convenience symlink: ancestor device not found\n");
+ return -ENOENT;
+ }
+ }
+ dirent = sysfs_get_dirent(dev->kobj.sd, "ddcci_backlight");
+ if (dirent) {
+ sysfs_put(dirent);
+ dev_dbg(&ddcci_dev->dev, "failed to create convenience symlink: %s/ddcci_backlight already exists\n", dev_name(dev));
+ return -EEXIST;
+ }
+
+ result = sysfs_create_link(&dev->kobj, &ddcci_dev->dev.kobj, "ddcci_backlight");
+ if (result == 0)
+ dev_dbg(&ddcci_dev->dev, "created symlink %s/ddcci_backlight\n", dev_name(dev));
+ else
+ dev_info(&ddcci_dev->dev, "failed to create convenience symlink: %d\n", result);
+ return result;
+}
+
+static int ddcci_backlight_remove_symlink(struct ddcci_device *ddcci_dev)
+{
+ int i;
+ struct device *dev = &ddcci_dev->dev;
+ struct kernfs_node *dirent;
+
+ for (i = 0; i < 3; ++i) {
+ dev = dev->parent;
+ if (!dev)
+ return -ENOENT;
+ }
+ dirent = sysfs_get_dirent(dev->kobj.sd, "ddcci_backlight");
+ if (!dirent)
+ return -ENOENT;
+
+ if ((dirent->flags & KERNFS_LINK) == 0) {
+ sysfs_put(dirent);
+ dev_dbg(&ddcci_dev->dev, "won't remove %s/ddcci_backlight: not a symlink\n", dev_name(dev));
+ return -EINVAL;
+ }
+
+ if (dirent->symlink.target_kn != ddcci_dev->dev.kobj.sd) {
+ sysfs_put(dirent);
+ dev_dbg(&ddcci_dev->dev, "won't remove %s/ddcci_backlight: we are not the link target\n", dev_name(dev));
+ return -EINVAL;
+ }
+
+ sysfs_put(dirent);
+
+ sysfs_remove_link(&dev->kobj, "ddcci_backlight");
+ dev_dbg(&ddcci_dev->dev, "removed symlink %s/ddcci_backlight\n", dev_name(dev));
+ return 0;
+}
+
+static int ddcci_monitor_probe(struct ddcci_device *dev,
+ const struct ddcci_device_id *id)
+{
+ struct ddcci_monitor_drv_data *drv_data;
+ struct backlight_properties props;
+ struct backlight_device *bl = NULL;
+ int ret = 0;
+ bool support_luminance, support_bl_white;
+ unsigned short brightness = 0, max_brightness = 0;
+ const char *vcps;
+
+ dev_dbg(&dev->dev, "probing monitor backlight device\n");
+
+ /* Get VCP list */
+ vcps = ddcci_find_capstr_item(dev->capabilities, "vcp", NULL);
+ if (IS_ERR(vcps)) {
+ dev_info(&dev->dev,
+ "monitor doesn't provide a list of supported controls.\n");
+ support_bl_white = support_luminance = true;
+ } else {
+ /* Check VCP list for supported VCPs */
+ support_bl_white = ddcci_monitor_find_vcp(DDCCI_MONITOR_BL_WHITE, vcps);
+ support_luminance = ddcci_monitor_find_vcp(DDCCI_MONITOR_LUMINANCE, vcps);
+ /* Fallback to trying if no support is found */
+ if (!support_bl_white && !support_luminance) {
+ dev_info(&dev->dev,
+ "monitor doesn't announce support for backlight or luminance controls.\n");
+ support_bl_white = support_luminance = true;
+ }
+ }
+
+ /* Initialize driver data structure */
+ drv_data = devm_kzalloc(&dev->dev, sizeof(struct ddcci_monitor_drv_data),
+ GFP_KERNEL);
+ if (!drv_data)
+ return -ENOMEM;
+ drv_data->device = dev;
+
+ if (support_bl_white) {
+ /* Try getting backlight level */
+ dev_dbg(&dev->dev,
+ "trying to access \"backlight level white\" control\n");
+ ret = ddcci_monitor_readctrl(drv_data->device, DDCCI_MONITOR_BL_WHITE,
+ &brightness, &max_brightness);
+ if (ret < 0) {
+ if (ret == -ENOTSUPP)
+ dev_info(&dev->dev,
+ "monitor does not support reading backlight level\n");
+ else
+ goto err_free;
+ } else {
+ drv_data->used_vcp = DDCCI_MONITOR_BL_WHITE;
+ }
+ }
+
+ if (support_luminance && !drv_data->used_vcp) {
+ /* Try getting luminance */
+ dev_dbg(&dev->dev,
+ "trying to access \"luminance\" control\n");
+ ret = ddcci_monitor_readctrl(drv_data->device, DDCCI_MONITOR_LUMINANCE,
+ &brightness, &max_brightness);
+ if (ret < 0) {
+ if (ret == -ENOTSUPP)
+ dev_info(&dev->dev,
+ "monitor does not support reading luminance\n");
+ else
+ goto err_free;
+ } else {
+ drv_data->used_vcp = DDCCI_MONITOR_LUMINANCE;
+ }
+ drv_data->used_vcp = DDCCI_MONITOR_LUMINANCE;
+ }
+
+ if (!drv_data->used_vcp)
+ goto err_free;
+
+ /* Create brightness device */
+ memset(&props, 0, sizeof(props));
+ props.type = BACKLIGHT_RAW;
+ props.max_brightness = max_brightness;
+ props.brightness = brightness;
+ bl = devm_backlight_device_register(&dev->dev, dev_name(&dev->dev),
+ &dev->dev, drv_data,
+ &ddcci_backlight_ops, &props);
+ drv_data->bl_dev = bl;
+ if (IS_ERR(bl)) {
+ dev_err(&dev->dev, "failed to register backlight\n");
+ return PTR_ERR(bl);
+ }
+ dev_info(&dev->dev, "registered %s as backlight device %s\n",
+ ddcci_monitor_vcp_name(drv_data->used_vcp),
+ dev_name(&dev->dev));
+
+ if (convenience_symlink)
+ ddcci_backlight_create_symlink(dev);
+
+ goto end;
+err_free:
+ devm_kfree(&dev->dev, drv_data);
+end:
+ return ret;
+}
+
+static int ddcci_monitor_remove(struct ddcci_device *dev)
+{
+ dev_dbg(&dev->dev, "removing device\n");
+ ddcci_backlight_remove_symlink(dev);
+ return 0;
+}
+
+static struct ddcci_device_id ddcci_monitor_idtable[] = {
+ { "monitor", DDCCI_ANY_ID, DDCCI_ANY_ID, DDCCI_ANY_ID, DDCCI_ANY_ID, 0 },
+ {}
+};
+
+static struct ddcci_driver ddcci_backlight_driver = {
+ .driver = {
+ .name = "ddcci-backlight",
+ .owner = THIS_MODULE,
+ },
+
+ .id_table = ddcci_monitor_idtable,
+ .probe = ddcci_monitor_probe,
+ .remove = ddcci_monitor_remove,
+};
+
+module_ddcci_driver(ddcci_backlight_driver);
+
+/* Module parameter description */
+module_param(convenience_symlink, bool, 0644);
+MODULE_PARM_DESC(convenience_symlink, "add convenience symlink \"ddcci_backlight\" to ancestor device in sysfs (default true)");
+
+MODULE_AUTHOR("Christoph Grenz");
+MODULE_DESCRIPTION("DDC/CI generic monitor backlight driver");
+MODULE_VERSION("0.4.2");
+MODULE_LICENSE("GPL");
+
+MODULE_ALIAS("ddcci:monitor-*-*-*-*");
diff --git a/drivers/ddcci/ddcci.c b/drivers/ddcci/ddcci.c
new file mode 100644
index 000000000000..5991e9dc6d18
--- /dev/null
+++ b/drivers/ddcci/ddcci.c
@@ -0,0 +1,1887 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * DDC/CI sub-bus driver
+ *
+ * Copyright (c) 2015 Christoph Grenz
+ */
+
+/*
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the Free
+ * Software Foundation; either version 2 of the License, or (at your option)
+ * any later version.
+ */
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+#include <asm-generic/fcntl.h>
+#include <linux/cdev.h>
+#include <linux/delay.h>
+#include <linux/device.h>
+#include <linux/fs.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/rwsem.h>
+#include <linux/sem.h>
+#include <linux/slab.h>
+#include <linux/uaccess.h>
+#include <linux/version.h>
+
+#include <linux/ddcci.h>
+
+#define DDCCI_RECV_BUFFER_SIZE 130
+#define DEVICE_NAME "ddcci"
+#define DDCCI_MAX_CAP_CHUNKS 200
+
+static unsigned int delay = 60;
+static unsigned short autoprobe_addrs[127] = {0xF0, 0xF2, 0xF4, 0xF6, 0xF8};
+static int autoprobe_addr_count = 5;
+
+static dev_t ddcci_cdev_first;
+static dev_t ddcci_cdev_next;
+static dev_t ddcci_cdev_end;
+static DEFINE_SEMAPHORE(core_lock);
+
+struct bus_type ddcci_bus_type;
+EXPORT_SYMBOL_GPL(ddcci_bus_type);
+
+/* Assert neccessary string array sizes */
+#ifndef sizeof_field
+# define sizeof_field(t, m) FIELD_SIZEOF(t, m)
+#endif
+static_assert(sizeof_field(struct ddcci_device, prot) > 8);
+static_assert(sizeof_field(struct ddcci_device, type) > 8);
+static_assert(sizeof_field(struct ddcci_device, model) > 8);
+static_assert(sizeof_field(struct ddcci_device, vendor) > 8);
+static_assert(sizeof_field(struct ddcci_device, module) > 8);
+
+/* Internal per-i2c-client driver data */
+struct ddcci_bus_drv_data {
+ unsigned long quirks;
+ struct i2c_client *i2c_dev;
+ struct semaphore sem;
+ unsigned char recv_buffer[DDCCI_RECV_BUFFER_SIZE];
+};
+
+/* Replace non-alphanumeric characters in a string (used for modalias) */
+static void ddcci_modalias_clean(char *string, size_t n, char replacement)
+{
+ int i;
+
+ for (i = 0; i < n; ++i) {
+ char c = string[i];
+
+ if (c == 0) {
+ return;
+ else if (c < '0' || (c > '9' && c < 'A') || (c > 'Z' && c < 'a') || c > 'z')
+ string[i] = replacement;
+ }
+}
+
+/* Write a message to the DDC/CI bus using i2c_smbus_write_byte() */
+static int __ddcci_write_bytewise(struct i2c_client *client, unsigned char addr,
+ bool p_flag, const unsigned char *__restrict buf,
+ unsigned char len)
+{
+ int ret = 0;
+ unsigned char outer_addr = (unsigned char)(client->addr << 1);
+ unsigned int xor = outer_addr; /* initial xor value */
+
+ /* Consistency checks */
+ if (len > 127)
+ return -EINVAL;
+
+ /* Special case: sender to 0x6E is always 0x51 */
+ if (addr == DDCCI_DEFAULT_DEVICE_ADDR) {
+ addr = DDCCI_HOST_ADDR_ODD;
+ } else {
+ /* When sending the odd address is used */
+ addr = addr | 1;
+ }
+
+ /* first byte: sender address */
+ xor ^= addr;
+ ret = i2c_smbus_write_byte(client, addr);
+ if (ret < 0)
+ return ret;
+
+ /* second byte: protocol flag and message size */
+ xor ^= ((p_flag << 7) | len);
+ ret = i2c_smbus_write_byte(client, (p_flag << 7)|len);
+ if (ret < 0)
+ return ret;
+
+ /* send payload */
+ while (len--) {
+ xor ^= (*buf);
+ ret = i2c_smbus_write_byte(client, (*buf));
+ if (ret < 0)
+ return ret;
+ buf++;
+ }
+
+ /* send checksum */
+ ret = i2c_smbus_write_byte(client, xor);
+ return ret;
+}
+
+/* Write a message to the DDC/CI bus using i2c_master_send() */
+static int __ddcci_write_block(struct i2c_client *client, unsigned char addr,
+ unsigned char *sendbuf, bool p_flag,
+ const unsigned char *data, unsigned char len)
+{
+ unsigned char outer_addr = (unsigned char)(client->addr << 1);
+ unsigned int xor = outer_addr; /* initial xor value */
+ unsigned char *ptr = sendbuf;
+
+ /* Consistency checks */
+ if (len > 127)
+ return -EINVAL;
+
+ /* Special case: sender to 0x6E is always 0x51 */
+ if (addr == DDCCI_DEFAULT_DEVICE_ADDR) {
+ addr = DDCCI_HOST_ADDR_ODD;
+ } else {
+ /* When sending the odd address is used */
+ addr = addr | 1;
+ }
+
+ /* first byte: sender address */
+ xor ^= addr;
+ *(ptr++) = addr;
+ /* second byte: protocol flag and message size */
+ xor ^= ((p_flag << 7) | len);
+ *(ptr++) = (p_flag << 7)|len;
+ /* payload */
+ while (len--) {
+ xor ^= (*data);
+ *(ptr++) = (*data);
+ data++;
+ }
+ /* checksum */
+ (*ptr) = xor;
+
+ /* Send it */
+ return i2c_master_send(client, sendbuf, ptr - sendbuf + 1);
+}
+
+/*
+ * Write a message to the DDC/CI bus.
+ *
+ * You must hold the bus semaphore when calling this function.
+ */
+static int ddcci_write(struct i2c_client *client, unsigned char addr,
+ bool p_flag, const unsigned char *data,
+ unsigned char len)
+{
+ struct ddcci_bus_drv_data *drv_data;
+ unsigned char *sendbuf;
+ int ret;
+
+ drv_data = i2c_get_clientdata(client);
+
+
+ pr_debug("sending to %d:%02x:%02x: %*ph\n", client->adapter->nr,
+ client->addr << 1, addr, len, data);
+ if (drv_data->quirks & DDCCI_QUIRK_WRITE_BYTEWISE) {
+ ret = __ddcci_write_bytewise(client, addr, p_flag, data, len);
+ } else {
+ sendbuf = drv_data->recv_buffer;
+ ret = __ddcci_write_block(client, addr, sendbuf, p_flag, data, len);
+ }
+
+ return ret;
+}
+
+/*
+ * Read a response from the DDC/CI bus with headers directly into a buffer.
+ * Always check for DDCCI_QUIRK_SKIP_FIRST_BYTE when using this function.
+ * The returned length contains the whole unmodified response.
+ * If -EMSGSIZE is returned, the buffer contains the response up to `len`.
+ * If any other negative error code is returned, the buffer content is
+ * unspecified.
+ */
+static int __ddcci_read(struct i2c_client *client, unsigned char addr,
+ bool p_flag, unsigned long quirks, unsigned char *buf,
+ unsigned char len)
+{
+ int i, payload_len, packet_length, ret;
+ unsigned char xor = DDCCI_HOST_ADDR_EVEN;
+
+ /* Consistency checks */
+ if (len < 3)
+ return -EINVAL;
+
+ /* Read frame */
+ ret = i2c_master_recv(client, buf, len);
+ if (ret < 0)
+ goto out_err;
+ packet_length = ret;
+
+ /* Skip first byte if quirk active */
+ if ((quirks & DDCCI_QUIRK_SKIP_FIRST_BYTE) && ret > 0 && len > 0) {
+ ret--;
+ len--;
+ buf++;
+ }
+
+ /* If answer too short (= incomplete) break out */
+ if (ret < 3) {
+ ret = -EIO;
+ goto out_err;
+ }
+
+ /* validate first byte */
+ if (unlikely(buf[0] != addr)) {
+ ret = (buf[0] == '\0') ? -EAGAIN : -EIO;
+ goto out_err;
+ }
+
+ /* validate second byte (protocol flag) */
+ if (unlikely((buf[1] & 0x80) != (p_flag << 7))) {
+ if (!p_flag || !(quirks & DDCCI_QUIRK_NO_PFLAG)) {
+ ret = -EIO;
+ goto out_err;
+ }
+ }
+
+ /* get and check payload length */
+ payload_len = buf[1] & 0x7F;
+ if (3+payload_len > packet_length)
+ return -EBADMSG;
+ if (3+payload_len > len)
+ return -EMSGSIZE;
+
+ /* calculate checksum */
+ for (i = 0; i < 3+payload_len; i++)
+ xor ^= buf[i];
+
+ /* verify checksum */
+ if (xor != 0) {
+ dev_err(&client->dev, "invalid DDC/CI response, corrupted data - xor is 0x%02x, length 0x%02x\n",
+ xor, payload_len);
+ ret = -EBADMSG;
+ goto out_err;
+ }
+
+ /* return result */
+ ret = payload_len+3+((quirks & DDCCI_QUIRK_SKIP_FIRST_BYTE)?1:0);
+
+out_err:
+ return ret;
+}
+
+/*
+ * Read a response from the DDC/CI bus
+ *
+ * You must hold the bus semaphore when calling this function.
+ */
+static int ddcci_read(struct i2c_client *client, unsigned char addr,
+ bool p_flag, unsigned char *buf, unsigned char len)
+{
+ struct ddcci_bus_drv_data *drv_data;
+ unsigned char *recvbuf;
+ int ret;
+
+ drv_data = i2c_get_clientdata(client);
+ recvbuf = drv_data->recv_buffer;
+
+ /* Read frame */
+ ret = __ddcci_read(client, addr, p_flag,
+ drv_data->quirks, recvbuf, DDCCI_RECV_BUFFER_SIZE);
+ if (ret < 0)
+ return ret;
+
+ if (drv_data->quirks & DDCCI_QUIRK_SKIP_FIRST_BYTE)
+ recvbuf++;
+
+ /* return result */
+ if (buf) {
+ if (ret > 3) {
+ ret = ret-3;
+ /* copy to caller buffer */
+ memcpy(buf, &recvbuf[2], (ret < len) ? ret : len);
+
+ if (ret > len) {
+ /* if message was truncated, return -EMSGSIZE */
+ pr_debug("received from %d:%02x:%02x: [%u/%u] %*ph ...\n",
+ client->adapter->nr, client->addr << 1,
+ addr, ret, len, len, buf);
+ ret = -EMSGSIZE;
+ } else {
+ pr_debug("received from %d:%02x:%02x: [%u/%u] %*ph\n",
+ client->adapter->nr, client->addr << 1,
+ addr, ret, len, ret, buf);
+ }
+ }
+ }
+ if (!(drv_data->quirks & DDCCI_QUIRK_WRITE_BYTEWISE)) {
+ /* second read to clear buffers, needed on some devices */
+ __ddcci_read(client, addr, true, drv_data->quirks, recvbuf, 1);
+ }
+ return ret;
+}
+
+/* Request the capability string for a device and put it into buf */
+static int ddcci_get_caps(struct i2c_client *client, unsigned char addr,
+ unsigned char *buf, unsigned int len)
+{
+ int result = 0, counter = 0, offset = 0;
+ unsigned char cmd[3] = { DDCCI_COMMAND_CAPS, 0x00, 0x00 };
+ unsigned char *chunkbuf = kzalloc(35, GFP_KERNEL);
+
+ if (!chunkbuf)
+ return -ENOMEM;
+
+ do {
+ /* Send command */
+ result = ddcci_write(client, addr, true, cmd, sizeof(cmd));
+ if (result < 0)
+ goto err_free;
+ msleep(delay);
+ /* read result chunk */
+ result = ddcci_read(client, addr, true, chunkbuf,
+ (len > 32) ? 35 : len+3);
+ if (result < 0)
+ goto err_free;
+
+ if (result > 0) {
+ /* check chunk header */
+ if (chunkbuf[0] != DDCCI_REPLY_CAPS) {
+ result = -EIO;
+ goto err_free;
+ }
+ if (chunkbuf[1] != cmd[1] || chunkbuf[2] != cmd[2]) {
+ result = -EIO;
+ goto err_free;
+ }
+ if (result < 3) {
+ result = -EIO;
+ goto err_free;
+ }
+ memcpy(buf, chunkbuf+3, min((unsigned int)result-3, len));
+
+ counter++;
+ /* adjust offset, etc. */
+ offset += result-3;
+ len -= result-3;
+ buf += result-3;
+ cmd[1] = offset >> 8;
+ cmd[2] = offset & 0xFF;
+ /* Another superfluous read to make some devices happy... */
+ ddcci_read(client, addr, true, NULL, 2);
+ }
+ } while (result > 3 && counter < DDCCI_MAX_CAP_CHUNKS);
+
+ kfree(chunkbuf);
+ return offset+result-3;
+err_free:
+ kfree(chunkbuf);
+ return result;
+}
+
+/*
+ * Request the device identification and put it into buf.
+ *
+ * Also detects all communication quirks and sets the corresponding flags
+ * in the ddcci_bus_drv_data structure associated with client.
+ *
+ * The identification command will fail on most DDC devices, as it is optional
+ * to support, but even the "failed" response suffices to detect quirks.
+ */
+static int ddcci_identify_device(struct i2c_client *client, unsigned char addr,
+ unsigned char *buf, unsigned char len)
+{
+ int i, payload_len, ret = -ENODEV;
+ unsigned long quirks;
+ unsigned char cmd[1] = { DDCCI_COMMAND_ID };
+ unsigned char *buffer;
+ unsigned char xor = DDCCI_HOST_ADDR_EVEN;
+ struct ddcci_bus_drv_data *bus_drv_data;
+
+ bus_drv_data = i2c_get_clientdata(client);
+ quirks = bus_drv_data->quirks;
+ buffer = bus_drv_data->recv_buffer;
+
+ /* Send Identification command */
+ if (!(quirks & DDCCI_QUIRK_WRITE_BYTEWISE)) {
+ ret = __ddcci_write_block(client, addr, buffer, true, cmd, sizeof(cmd));
+ dev_dbg(&client->dev,
+ "[%02x:%02x] writing identification command in block mode: %d\n",
+ client->addr << 1, addr, ret);
+ if ((ret == -ENXIO)
+ && i2c_check_functionality(client->adapter,
+ I2C_FUNC_SMBUS_WRITE_BYTE)) {
+ quirks |= DDCCI_QUIRK_WRITE_BYTEWISE;
+ dev_info(&client->dev,
+ "DDC/CI bus quirk detected: writes must be done bytewise\n");
+ /* Some devices need writing twice after a failed blockwise write */
+ __ddcci_write_bytewise(client, addr, true, cmd, sizeof(cmd));
+ msleep(delay);
+ }
+ }
+ if (ret < 0 && (quirks & DDCCI_QUIRK_WRITE_BYTEWISE)) {
+ ret = __ddcci_write_bytewise(client, addr, true, cmd, sizeof(cmd));
+ dev_dbg(&client->dev,
+ "[%02x:%02x] writing identification command in bytewise mode: %d\n",
+ client->addr << 1, addr, ret);
+ }
+ if (ret < 0)
+ return -ENODEV;
+
+ /* Wait */
+ msleep(delay);
+
+ /* Receive response */
+ ret = i2c_master_recv(client, buffer, DDCCI_RECV_BUFFER_SIZE);
+ if (ret < 0) {
+ dev_dbg(&client->dev,
+ "[%02x:%02x] receiving identification response resulted in errno %d\n",
+ client->addr << 1, addr, ret);
+ return ret;
+ }
+
+ if (ret == 0) {
+ dev_dbg(&client->dev,
+ "[%02x:%02x] no identification response received\n",
+ client->addr << 1, addr);
+ return ret;
+ }
+
+ /* Skip first byte if quirk already active */
+ if (quirks & DDCCI_QUIRK_SKIP_FIRST_BYTE && ret > 1) {
+ dev_dbg(&client->dev,
+ "[%02x:%02x] doubled first byte quirk in effect\n",
+ client->addr << 1, addr);
+ ret--;
+ buffer++;
+ }
+
+ /* If answer too short (= incomplete) break out */
+ if (ret < 3) {
+ dev_dbg(&client->dev,
+ "[%02x:%02x] identification response is too short (%d bytes)\n",
+ client->addr << 1, addr, ret);
+ return -EIO;
+ }
+
+ /* validate first byte */
+ if (buffer[0] != addr) {
+ dev_dbg(&client->dev,
+ "[%02x:%02x] identification response: %*ph\n",
+ client->addr << 1, addr, (ret > 32 ? 32 : ret), buffer);
+
+ dev_dbg(&client->dev,
+ "[%02x:%02x] identification response invalid (expected first byte %02x, got %02x)\n",
+ client->addr << 1, addr, addr, buffer[0]);
+ return -ENODEV;
+ }
+
+ /* Check if first byte is doubled (QUIRK_SKIP_FIRST_BYTE) */
+ if (!(quirks & DDCCI_QUIRK_SKIP_FIRST_BYTE)) {
+ if (buffer[0] == buffer[1]) {
+ quirks |= DDCCI_QUIRK_SKIP_FIRST_BYTE;
+ dev_info(&client->dev,
+ "DDC/CI bus quirk detected: doubled first byte on read\n");
+ ret--;
+ buffer++;
+ if (ret < 3)
+ return -EIO;
+ }
+ }
+
+ /* validate second byte (protocol flag) */
+ if ((buffer[1] & 0x80) != 0x80 && !(quirks & DDCCI_QUIRK_NO_PFLAG)) {
+ dev_info(&client->dev,
+ "DDC/CI bus quirk detected: device omits protocol flag on responses\n");
+ quirks |= DDCCI_QUIRK_NO_PFLAG;
+ }
+
+ /* get and check payload length */
+ payload_len = buffer[1] & 0x7F;
+ if (3+payload_len > ret) {
+ dev_dbg(&client->dev,
+ "[%02x:%02x] identification response: %*ph ...\n",
+ client->addr << 1, addr, ret, buffer);
+ dev_dbg(&client->dev,
+ "[%02x:%02x] identification response was truncated (expected %d bytes, got %d)\n",
+ client->addr << 1, addr, 3+payload_len, ret);
+ return -EBADMSG;
+ }
+
+ dev_dbg(&client->dev,
+ "[%02x:%02x] identification response: %*ph\n",
+ client->addr << 1, addr, 3+payload_len, buffer);
+
+ /* calculate checksum */
+ for (i = 0; i < 3+payload_len; i++)
+ xor ^= buffer[i];
+
+ /* verify checksum */
+ if (xor != 0) {
+ dev_err(&client->dev,
+ "[%02x:%02x] invalid DDC/CI response, corrupted data - xor is 0x%02x, length 0x%02x\n",
+ client->addr << 1, addr, xor, payload_len);
+ return -EBADMSG;
+ }
+
+ /* save quirks */
+ bus_drv_data->quirks = quirks;
+
+ /* return result */
+ if (payload_len <= len) {
+ ret = payload_len;
+ memcpy(buf, &buffer[2], payload_len);
+ } else {
+ ret = -EMSGSIZE;
+ memcpy(buf, &buffer[2], len);
+ }
+ return ret;
+}
+
+/* Character device */
+
+/* Data structure for an open file handle */
+struct ddcci_fp_data {
+ struct ddcci_device *dev;
+ bool exclusive;
+ unsigned char buffer[129];
+};
+
+/* Called when the character device is opened */
+static int ddcci_cdev_open(struct inode *inode, struct file *filp)
+{
+ struct ddcci_device *dev = container_of(inode->i_cdev,
+ struct ddcci_device, cdev);
+ struct ddcci_fp_data *fp_data = NULL;
+
+ fp_data = kzalloc(sizeof(struct ddcci_fp_data), GFP_KERNEL);
+
+ if (!fp_data)
+ return -ENOMEM;
+
+ fp_data->exclusive = filp->f_flags & O_EXCL;
+
+ if (fp_data->exclusive) {
+ if (down_write_trylock(&dev->cdev_sem) == 0) {
+ kfree(fp_data);
+ return -EBUSY;
+ }
+ } else {
+ if (down_read_trylock(&dev->cdev_sem) == 0) {
+ kfree(fp_data);
+ return -EBUSY;
+ }
+ }
+
+ fp_data->dev = dev;
+ filp->private_data = fp_data;
+
+ return 0;
+}
+
+/* Called when the character device is closed */
+static int ddcci_cdev_close(struct inode *inode, struct file *filp)
+{
+ struct ddcci_fp_data *fp_data = filp->private_data;
+ struct ddcci_device *dev = fp_data->dev;
+
+ if (fp_data->exclusive)
+ up_write(&dev->cdev_sem);
+ else
+ up_read(&dev->cdev_sem);
+
+ filp->private_data = NULL;
+ kfree(fp_data);
+ return 0;
+}
+
+/* Called when reading from the character device */
+static ssize_t ddcci_cdev_read(struct file *filp, char __user *buffer,
+ size_t length, loff_t *offset)
+{
+ struct ddcci_fp_data *fp_data = filp->private_data;
+ struct ddcci_device *dev = fp_data->dev;
+ unsigned char *buf = fp_data->buffer;
+ const bool nonblocking = (filp->f_flags & O_NONBLOCK) != 0;
+ int ret = 0;
+
+ if ((filp->f_mode & FMODE_READ) == 0)
+ return -EBADF;
+
+ /* Lock mutex */
+ if (nonblocking) {
+ if (down_trylock(&dev->bus_drv_data->sem))
+ return -EAGAIN;
+ } else {
+ if (down_interruptible(&dev->bus_drv_data->sem))
+ return -ERESTARTSYS;
+ }
+
+ /* Execute read */
+ ret = ddcci_read(dev->bus_drv_data->i2c_dev, dev->inner_addr, true, buf,
+ length);
+
+ if (ret > 0) {
+ /* Copy data from user space */
+ if (copy_to_user(buffer, buf, ret)) {
+ ret = -EFAULT;
+ goto out;
+ }
+ }
+
+out:
+ up(&dev->bus_drv_data->sem);
+ return ret;
+}
+
+/* Called when writing to the character device */
+static ssize_t ddcci_cdev_write(struct file *filp, const char __user *buffer,
+ size_t count, loff_t *offset)
+{
+ struct ddcci_fp_data *fp_data = filp->private_data;
+ struct ddcci_device *dev = fp_data->dev;
+ unsigned char *buf = fp_data->buffer;
+ const bool nonblocking = (filp->f_flags & O_NONBLOCK) != 0;
+ int ret = 0;
+
+ if ((filp->f_mode & FMODE_WRITE) == 0)
+ return -EBADF;
+
+ if (count > 127)
+ return -EINVAL;
+
+ /* Lock mutex */
+ if (nonblocking) {
+ if (down_trylock(&dev->bus_drv_data->sem))
+ return -EAGAIN;
+ } else {
+ if (down_interruptible(&dev->bus_drv_data->sem))
+ return -ERESTARTSYS;
+ }
+
+ if (count > 0) {
+ /* Copy data from user space */
+ if (copy_from_user(buf, buffer, count)) {
+ ret = -EFAULT;
+ goto err_out;
+ }
+
+ /* Execute write */
+ ret = ddcci_write(dev->bus_drv_data->i2c_dev, dev->inner_addr,
+ true, buf, count);
+ }
+
+ if (ret >= 0) {
+ msleep(delay);
+ up(&dev->bus_drv_data->sem);
+ return count;
+ }
+
+err_out:
+ up(&dev->bus_drv_data->sem);
+ return ret;
+}
+
+/* Called when seeking the character device */
+static loff_t ddcci_cdev_seek(struct file *filp, loff_t offset, int anchor)
+{
+ return -EINVAL;
+}
+
+static const struct file_operations ddcci_fops = {
+ .owner = THIS_MODULE,
+ .read = ddcci_cdev_read,
+ .write = ddcci_cdev_write,
+ .open = ddcci_cdev_open,
+ .release = ddcci_cdev_close,
+ .llseek = ddcci_cdev_seek
+};
+
+/* Set up the character device for a DDC/CI device */
+static int ddcci_setup_char_device(struct ddcci_device *device)
+{
+ int ret = -EINVAL;
+
+ /* Check if free minor exists */
+ if (ddcci_cdev_next == ddcci_cdev_end) {
+ dev_err(&device->dev, "no free major/minor\n");
+ ret = -ENFILE;
+ goto out;
+ }
+
+ /* Initialize rwsem */
+ init_rwsem(&device->cdev_sem);
+
+ /* Initialize character device node */
+ cdev_init(&device->cdev, &ddcci_fops);
+ device->cdev.owner = THIS_MODULE;
+
+ /* Publish char device */
+ device->dev.devt = ddcci_cdev_next;
+ ret = cdev_add(&device->cdev, ddcci_cdev_next, 1);
+ if (ret) {
+ device->dev.devt = 0;
+ goto out;
+ }
+
+ ddcci_cdev_next++;
+out:
+ return ret;
+}
+
+/* sysfs attributes */
+
+static ssize_t ddcci_attr_capabilities_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct ddcci_device *device = ddcci_verify_device(dev);
+ ssize_t ret = -ENOENT;
+ size_t len;
+
+ if (likely(device != NULL)) {
+ len = device->capabilities_len;
+ if (unlikely(len > PAGE_SIZE))
+ len = PAGE_SIZE;
+ if (len == 0) {
+ ret = len;
+ } else {
+ memcpy(buf, device->capabilities, len);
+ if (likely(len < PAGE_SIZE)) {
+ buf[len] = '\n';
+ ret = len+1;
+ }
+ }
+ }
+
+ return ret;
+}
+
+static ssize_t ddcci_attr_prot_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct ddcci_device *device = ddcci_verify_device(dev);
+ ssize_t ret = -ENOENT;
+ size_t len;
+
+ if (likely(device != NULL)) {
+ len = strnlen(device->prot, sizeof(device->prot));
+ strncpy(buf, device->prot, PAGE_SIZE);
+ if (len == 0) {
+ ret = len;
+ } else if (likely(len < PAGE_SIZE)) {
+ buf[len] = '\n';
+ ret = len+1;
+ } else {
+ ret = PAGE_SIZE;
+ }
+ }
+ return ret;
+}
+
+static ssize_t ddcci_attr_type_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct ddcci_device *device = ddcci_verify_device(dev);
+ ssize_t ret = -ENOENT;
+ size_t len;
+
+ if (likely(device != NULL)) {
+ len = strnlen(device->type, sizeof(device->type));
+ strncpy(buf, device->type, PAGE_SIZE);
+ if (len == 0) {
+ ret = len;
+ } else if (likely(len < PAGE_SIZE)) {
+ buf[len] = '\n';
+ ret = len+1;
+ } else {
+ ret = PAGE_SIZE;
+ }
+ }
+ return ret;
+}
+
+static ssize_t ddcci_attr_model_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct ddcci_device *device = ddcci_verify_device(dev);
+ ssize_t ret = -ENOENT;
+ size_t len;
+
+ if (likely(device != NULL)) {
+ len = strnlen(device->model, sizeof(device->model));
+ strncpy(buf, device->model, PAGE_SIZE);
+ if (len == 0) {
+ ret = len;
+ } else if (likely(len < PAGE_SIZE)) {
+ buf[len] = '\n';
+ ret = len+1;
+ } else {
+ ret = PAGE_SIZE;
+ }
+ }
+ return ret;
+}
+
+static ssize_t ddcci_attr_vendor_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct ddcci_device *device = ddcci_verify_device(dev);
+ ssize_t ret = -ENOENT;
+ size_t len;
+
+ if (likely(device != NULL)) {
+ len = strnlen(device->vendor, sizeof(device->vendor));
+ strncpy(buf, device->vendor, PAGE_SIZE);
+ if (len == 0) {
+ ret = len;
+ } else if (likely(len < PAGE_SIZE)) {
+ buf[len] = '\n';
+ ret = len+1;
+ } else {
+ ret = PAGE_SIZE;
+ }
+ }
+ return ret;
+}
+
+static ssize_t ddcci_attr_module_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct ddcci_device *device = ddcci_verify_device(dev);
+ ssize_t ret = -ENOENT;
+ size_t len;
+
+ if (likely(device != NULL)) {
+ len = strnlen(device->module, sizeof(device->module));
+ strncpy(buf, device->module, PAGE_SIZE);
+ if (len == 0) {
+ ret = len;
+ } else if (likely(len < PAGE_SIZE)) {
+ buf[len] = '\n';
+ ret = len+1;
+ } else {
+ ret = PAGE_SIZE;
+ }
+ }
+ return ret;
+}
+
+static ssize_t ddcci_attr_serial_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct ddcci_device *device = ddcci_verify_device(dev);
+ ssize_t ret = -ENOENT;
+
+ if (likely(device != NULL))
+ ret = scnprintf(buf, PAGE_SIZE, "%d\n", device->device_number);
+
+ return ret;
+}
+
+static ssize_t ddcci_attr_modalias_show(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ struct ddcci_device *device = ddcci_verify_device(dev);
+ ssize_t ret = -ENOENT;
+ char model[ARRAY_SIZE(device->model)];
+ char vendor[ARRAY_SIZE(device->model)];
+ char module[ARRAY_SIZE(device->model)];
+
+ if (likely(device != NULL)) {
+ memcpy(model, device->model, sizeof(model));
+ memcpy(vendor, device->vendor, sizeof(vendor));
+ memcpy(module, device->module, sizeof(module));
+ ddcci_modalias_clean(model, sizeof(model), '_');
+ ddcci_modalias_clean(vendor, sizeof(vendor), '_');
+ ddcci_modalias_clean(module, sizeof(module), '_');
+
+ ret = scnprintf(buf, PAGE_SIZE, "%s%s-%s-%s-%s-%s\n",
+ DDCCI_MODULE_PREFIX,
+ device->prot,
+ device->type,
+ model,
+ vendor,
+ module
+ );
+ }
+ return ret;
+}
+
+static DEVICE_ATTR(capabilities, 0444, ddcci_attr_capabilities_show, NULL);
+static DEVICE_ATTR(idProt, 0444, ddcci_attr_prot_show, NULL);
+static DEVICE_ATTR(idType, 0444, ddcci_attr_type_show, NULL);
+static DEVICE_ATTR(idModel, 0444, ddcci_attr_model_show, NULL);
+static DEVICE_ATTR(idVendor, 0444, ddcci_attr_vendor_show, NULL);
+static DEVICE_ATTR(idModule, 0444, ddcci_attr_module_show, NULL);
+static DEVICE_ATTR(idSerial, 0444, ddcci_attr_serial_show, NULL);
+static DEVICE_ATTR(modalias, 0444, ddcci_attr_modalias_show, NULL);
+
+static struct attribute *ddcci_char_device_attrs[] = {
+ &dev_attr_capabilities.attr,
+ &dev_attr_idProt.attr,
+ &dev_attr_idType.attr,
+ &dev_attr_idModel.attr,
+ &dev_attr_idVendor.attr,
+ &dev_attr_idModule.attr,
+ &dev_attr_idSerial.attr,
+ &dev_attr_modalias.attr,
+ NULL,
+};
+ATTRIBUTE_GROUPS(ddcci_char_device);
+
+/* DDC/CI bus */
+
+static int ddcci_device_uevent(struct device *dev, struct kobj_uevent_env *env)
+{
+ struct ddcci_device *device = to_ddcci_device(dev);
+ char model[ARRAY_SIZE(device->model)];
+ char vendor[ARRAY_SIZE(device->vendor)];
+ char module[ARRAY_SIZE(device->module)];
+
+ memcpy(model, device->model, sizeof(model));
+ memcpy(vendor, device->vendor, sizeof(vendor));
+ memcpy(module, device->module, sizeof(module));
+ ddcci_modalias_clean(model, sizeof(model), '_');
+ ddcci_modalias_clean(vendor, sizeof(vendor), '_');
+ ddcci_modalias_clean(module, sizeof(module), '_');
+
+ if (add_uevent_var(env, "MODALIAS=%s%s-%s-%s-%s-%s",
+ DDCCI_MODULE_PREFIX,
+ device->prot,
+ device->type,
+ model,
+ vendor,
+ module
+ ))
+ return -ENOMEM;
+
+ if (device->prot[0])
+ if (add_uevent_var(env, "DDCCI_PROT=%s", device->prot))
+ return -ENOMEM;
+
+ if (device->type[0])
+ if (add_uevent_var(env, "DDCCI_TYPE=%s", device->type))
+ return -ENOMEM;
+
+ if (device->model[0])
+ if (add_uevent_var(env, "DDCCI_MODEL=%s", device->model))
+ return -ENOMEM;
+
+ if (device->vendor[0]) {
+ if (add_uevent_var(env, "DDCCI_VENDOR=%s", device->vendor))
+ return -ENOMEM;
+
+ if (add_uevent_var(env, "DDCCI_MODULE=%s", device->module))
+ return -ENOMEM;
+
+ if (add_uevent_var(env, "DDCCI_UNIQ=%d", device->device_number))
+ return -ENOMEM;
+ }
+
+ return 0;
+}
+
+static void ddcci_device_release(struct device *dev)
+{
+ struct ddcci_device *device = to_ddcci_device(dev);
+ struct ddcci_driver *driver;
+
+ /* Notify driver */
+ if (dev->driver) {
+ driver = to_ddcci_driver(dev->driver);
+ if (driver->remove)
+ driver->remove(device);
+ }
+
+ /* Teardown chardev */
+ if (dev->devt) {
+ down(&core_lock);
+ if (device->cdev.dev == ddcci_cdev_next-1)
+ ddcci_cdev_next--;
+ cdev_del(&device->cdev);
+ up(&core_lock);
+ }
+
+ /* Free capability string */
+ if (device->capabilities) {
+ device->capabilities_len = 0;
+ kfree(device->capabilities);
+ }
+ /* Free device */
+ kfree(device);
+}
+
+static char *ddcci_devnode(struct device *dev,
+ umode_t *mode, kuid_t *uid, kgid_t *gid)
+{
+ struct ddcci_device *device;
+
+ device = to_ddcci_device(dev);
+ return kasprintf(GFP_KERNEL, "bus/ddcci/%d/display",
+ device->i2c_client->adapter->nr);
+}
+
+static char *ddcci_dependent_devnode(struct device *dev,
+ umode_t *mode, kuid_t *uid, kgid_t *gid)
+{
+ struct ddcci_device *device;
+
+ device = to_ddcci_device(dev);
+ if (device->flags & DDCCI_FLAG_EXTERNAL) {
+ if (device->outer_addr == device->inner_addr)
+ return kasprintf(GFP_KERNEL, "bus/ddcci/%d/e%02x",
+ device->i2c_client->adapter->nr,
+ device->outer_addr);
+ else
+ return kasprintf(GFP_KERNEL, "bus/ddcci/%d/e%02x%02x",
+ device->i2c_client->adapter->nr,
+ device->outer_addr, device->inner_addr);
+ } else {
+ return kasprintf(GFP_KERNEL, "bus/ddcci/%d/i%02x",
+ device->i2c_client->adapter->nr,
+ device->inner_addr);
+ }
+}
+
+/* Device type for main DDC/CI devices*/
+static struct device_type ddcci_device_type = {
+ .name = "ddcci-device",
+ .uevent = ddcci_device_uevent,
+ .groups = ddcci_char_device_groups,
+ .release = ddcci_device_release,
+ .devnode = ddcci_devnode
+};
+
+/* Device type for dependent DDC/CI devices*/
+static struct device_type ddcci_dependent_type = {
+ .name = "ddcci-dependent-device",
+ .uevent = ddcci_device_uevent,
+ .groups = ddcci_char_device_groups,
+ .release = ddcci_device_release,
+ .devnode = ddcci_dependent_devnode
+};
+
+/**
+ * ddcci_verify_device - return parameter as ddcci_device, or NULL
+ * @dev: device, probably from some driver model iterator
+ */
+struct ddcci_device *ddcci_verify_device(struct device *dev)
+{
+ if (unlikely(!dev))
+ return NULL;
+ return (dev->type == &ddcci_device_type
+ || dev->type == &ddcci_dependent_type)
+ ? to_ddcci_device(dev)
+ : NULL;
+}
+EXPORT_SYMBOL(ddcci_verify_device);
+
+/**
+ * ddcci_quirks - Get quirks for DDC/CI device
+ * @dev: Target DDC/CI device
+ */
+unsigned long ddcci_quirks(struct ddcci_device *dev)
+{
+ if (unlikely(WARN_ON(!dev)))
+ return ~0L;
+ if (unlikely(WARN_ON(!dev->bus_drv_data)))
+ return ~0L;
+ return dev->bus_drv_data->quirks;
+}
+EXPORT_SYMBOL(ddcci_quirks);
+
+/**
+ * ddcci_register_driver - register DDC/CI driver
+ * @owner: the owning module
+ * @driver: the driver to register
+ */
+int ddcci_register_driver(struct module *owner, struct ddcci_driver *driver)
+{
+ int ret;
+
+ /* Can't register until after driver model init */
+ if (unlikely(WARN_ON(!ddcci_bus_type.p)))
+ return -EAGAIN;
+
+ pr_debug("registering driver [%s]\n", driver->driver.name);
+
+ /* add the driver to the list of ddcci drivers in the driver core */
+ driver->driver.owner = owner;
+ driver->driver.bus = &ddcci_bus_type;
+
+ /* When registration returns, the driver core
+ * will have called probe() for all matching-but-unbound devices.
+ */
+ ret = driver_register(&driver->driver);
+ if (ret)
+ return ret;
+
+ pr_debug("driver [%s] registered\n", driver->driver.name);
+
+ return 0;
+}
+EXPORT_SYMBOL(ddcci_register_driver);
+
+/**
+ * ddcci_del_driver - unregister DDC/CI driver
+ * @driver: the driver being unregistered
+ */
+void ddcci_del_driver(struct ddcci_driver *driver)
+{
+ driver_unregister(&driver->driver);
+ pr_debug("driver [%s] unregistered\n", driver->driver.name);
+}
+EXPORT_SYMBOL(ddcci_del_driver);
+
+/**
+ * ddcci_device_write - Write a message to a DDC/CI device
+ * @dev: Target DDC/CI device
+ * @p_flag: Protocol flag, true for standard control messages
+ * @data: Data that will be written to the device
+ * @length: How many bytes to write
+ *
+ * Writes the message to the device and sleeps (see module parameter 'delay')
+ */
+int ddcci_device_write(struct ddcci_device *dev, bool p_flag,
+ unsigned char *data, unsigned char length)
+{
+ int ret;
+
+ if (down_interruptible(&dev->bus_drv_data->sem))
+ return -EAGAIN;
+
+ ret = ddcci_write(dev->bus_drv_data->i2c_dev, dev->inner_addr, p_flag, data, length);
+ msleep(delay);
+ up(&dev->bus_drv_data->sem);
+ return ret;
+}
+EXPORT_SYMBOL(ddcci_device_write);
+
+/**
+ * ddcci_device_read - Read a response from a DDC/CI device
+ * @dev: Target DDC/CI device
+ * @p_flag: Protocol flag, must match the corresponding write
+ * @buffer: Where to store data read from the device
+ * @length: Buffer size
+ */
+int ddcci_device_read(struct ddcci_device *dev, bool p_flag,
+ unsigned char *buffer, unsigned char length)
+{
+ int ret;
+
+ if (down_interruptible(&dev->bus_drv_data->sem))
+ return -EAGAIN;
+
+ ret = ddcci_read(dev->bus_drv_data->i2c_dev, dev->inner_addr, p_flag, buffer, length);
+ up(&dev->bus_drv_data->sem);
+ return ret;
+}
+EXPORT_SYMBOL(ddcci_device_read);
+
+/**
+ * ddcci_device_writeread - Write a message to a device and read the response
+ * @dev: Target DDC/CI device
+ * @p_flag: Protocol flag, true for standard control messages
+ * @buffer: Buffer used for write and read
+ * @length: How many bytes to write
+ * @maxlength: Buffer size on read
+ *
+ * Writing, sleeping and reading are done without releasing the DDC/CI bus.
+ * This provides atomicity in respect to other DDC/CI accesses on the same bus.
+ */
+int ddcci_device_writeread(struct ddcci_device *dev, bool p_flag,
+ unsigned char *buffer, unsigned char length,
+ unsigned char maxlength)
+{
+ int ret;
+
+ if (down_interruptible(&dev->bus_drv_data->sem))
+ return -EAGAIN;
+
+ ret = ddcci_write(dev->bus_drv_data->i2c_dev, dev->inner_addr, p_flag, buffer, length);
+ if (ret < 0)
+ goto err;
+ msleep(delay);
+ ret = ddcci_read(dev->bus_drv_data->i2c_dev, dev->inner_addr, p_flag, buffer, maxlength);
+err:
+ up(&dev->bus_drv_data->sem);
+ return ret;
+}
+EXPORT_SYMBOL(ddcci_device_writeread);
+
+#define IS_ANY_ID(x) (((x)[0] == -1) && ((x)[7] == -1))
+
+/* Check if any device id in the array matches the device and return the matching id */
+static const struct ddcci_device_id *ddcci_match_id(const struct ddcci_device_id *id,
+ const struct ddcci_device *device)
+{
+ while (id->prot[0] || id->type[0] || id->model[0] || id->vendor[0] || id->module[0]) {
+ if ((IS_ANY_ID(id->prot) || (strcmp(device->prot, id->prot) == 0))
+ && (IS_ANY_ID(id->type) || (strcmp(device->type, id->type) == 0))
+ && (IS_ANY_ID(id->model) || (strcmp(device->model, id->model) == 0))
+ && (IS_ANY_ID(id->vendor) || (strcmp(device->vendor, id->vendor) == 0))
+ && (IS_ANY_ID(id->module) || (strcmp(device->module, id->module) == 0))) {
+ return id;
+ }
+ id++;
+ }
+ return NULL;
+}
+
+static int ddcci_device_match(struct device *dev, struct device_driver *drv)
+{
+ struct ddcci_device *device = ddcci_verify_device(dev);
+ struct ddcci_driver *driver;
+
+ if (!device)
+ return 0;
+
+ driver = to_ddcci_driver(drv);
+ /* match on an id table if there is one */
+ if (driver->id_table)
+ return ddcci_match_id(driver->id_table, device) != NULL;
+
+ return 0;
+}
+
+static int ddcci_device_probe(struct device *dev)
+{
+ struct ddcci_device *device = ddcci_verify_device(dev);
+ struct ddcci_driver *driver;
+ const struct ddcci_device_id *id;
+ int ret = 0;
+
+ if (!device)
+ return -EINVAL;
+ driver = to_ddcci_driver(dev->driver);
+
+ id = ddcci_match_id(driver->id_table, device);
+ if (!id)
+ return -ENODEV;
+
+ if (driver->probe)
+ ret = driver->probe(device, id);
+
+ return ret;
+}
+
+static int ddcci_device_remove(struct device *dev)
+{
+ struct ddcci_device *device = ddcci_verify_device(dev);
+ struct ddcci_driver *driver;
+ int ret = 0;
+
+ if (!device)
+ return -EINVAL;
+ driver = to_ddcci_driver(dev->driver);
+
+ if (driver->remove)
+ ret = driver->remove(device);
+
+ return ret;
+}
+
+static void ddcci_device_remove_void(struct device *dev)
+{
+ ddcci_device_remove(dev);
+}
+
+/**
+ * DDCCI bus type structure
+ */
+struct bus_type ddcci_bus_type = {
+ .name = "ddcci",
+ .match = ddcci_device_match,
+ .probe = ddcci_device_probe,
+ .remove = ddcci_device_remove_void
+};
+
+/* Main I2C driver */
+
+/* Get a pointer to the closing parenthesis */
+static char *ddcci_capstr_tok(const char *s, int depth)
+{
+ const char *ptr = s;
+ char *end;
+
+ if (s == NULL || s[0] == '\0')
+ return NULL;
+
+ while ((end = strpbrk(ptr, "()"))) {
+ if (!end || depth == INT_MAX)
+ return NULL;
+ if (*end == '(')
+ depth++;
+ else if (depth > 0)
+ depth--;
+ else
+ break;
+ ptr = end+1;
+ }
+ return end;
+}
+
+/**
+ * ddcci_find_capstr_item - Search capability string for a tag
+ * @capabilities: Capability string to search
+ * @tag: Tag to find
+ * @length: Buffer for the length of the found tag value (optional)
+ *
+ * Return a pointer to the start of the tag value (directly after the '(') on
+ * success and write the length of the value (excluding the ')') into `length`.
+ *
+ * If the tag is not found or another error occurs, an ERR_PTR is returned
+ * and `length` stays untouched.
+ */
+const char *ddcci_find_capstr_item(const char *capabilities,
+ const char *__restrict tag,
+ size_t *length)
+{
+ const char *src = capabilities, *ptr;
+ ptrdiff_t len;
+ int taglen = strnlen(tag, 1024);
+
+ /* Check length of requested tag */
+ if (unlikely(taglen <= 0 || taglen > 1023))
+ return ERR_PTR(-EINVAL);
+
+ /* Find tag */
+ while (src && (strncmp(src+1, tag, taglen) != 0 || src[1+taglen] != '('))
+ src = ddcci_capstr_tok(src+1, -1);
+ if (!src || src[0] == '\0')
+ return ERR_PTR(-ENOENT);
+
+ /* Locate end of value */
+ src += taglen+2;
+ ptr = ddcci_capstr_tok(src, 0);
+ if (unlikely(!ptr))
+ return ERR_PTR(-EOVERFLOW);
+
+ /* Check length of tag data */
+ len = ptr-src;
+ if (unlikely(len < 0 || len > 65535))
+ return ERR_PTR(-EMSGSIZE);
+
+ /* Return pointer and length */
+ if (likely(length != NULL))
+ *length = (size_t)len;
+ return src;
+}
+EXPORT_SYMBOL(ddcci_find_capstr_item);
+
+/* Search the capability string for a tag and copy the value to dest */
+static int ddcci_cpy_capstr_item(char *dest, const char *src,
+ const char *__restrict tag, size_t maxlen)
+{
+ const char *ptr;
+ size_t len;
+
+ /* Find tag */
+ ptr = ddcci_find_capstr_item(src, tag, &len);
+ if (IS_ERR(ptr))
+ return PTR_ERR(ptr);
+
+ /* Copy value */
+ memcpy(dest, ptr, min(len, maxlen));
+ return 0;
+}
+
+/* Fill fields in device by parsing the capability string */
+static int ddcci_parse_capstring(struct ddcci_device *device)
+{
+ const char *capstr = device->capabilities;
+ int ret = 0;
+
+ if (!capstr)
+ return -EINVAL;
+
+ /* capability string start with a paren */
+ if (capstr[0] != '(')
+ return -EINVAL;
+
+ /* get prot(...) */
+ ret = ddcci_cpy_capstr_item(device->prot, capstr, "prot", sizeof(device->prot)-1);
+ if (ret) {
+ if (ret == -ENOENT) {
+ dev_warn(&device->dev, "malformed capability string: no protocol tag");
+ memset(device->prot, 0, sizeof(device->prot)-1);
+ } else {
+ return ret;
+ }
+ }
+
+ /* get type(...) */
+ ret = ddcci_cpy_capstr_item(device->type, capstr, "type", sizeof(device->type)-1);
+ if (ret) {
+ if (ret == -ENOENT) {
+ dev_warn(&device->dev, "malformed capability string: no type tag");
+ memset(device->type, 0, sizeof(device->type)-1);
+ } else {
+ return ret;
+ }
+ }
+
+ /* and then model(...) */
+ ret = ddcci_cpy_capstr_item(device->model, capstr, "model", sizeof(device->model)-1);
+ if (ret) {
+ if (ret == -ENOENT) {
+ dev_warn(&device->dev, "malformed capability string: no model tag");
+ memset(device->model, 0, sizeof(device->model)-1);
+ } else {
+ return ret;
+ }
+ }
+
+ /* if there is no protocol tag */
+ if (!device->prot[0]) {
+ /* and no type tag: give up. */
+ if (!device->type[0])
+ return -ENOENT;
+
+ /* Assume protocol "monitor" if type is "LCD" or "CRT" */
+ if (strncasecmp(device->type, "LCD", sizeof(device->type)-1) == 0
+ || strncasecmp(device->type, "CRT", sizeof(device->type)-1) == 0) {
+ memcpy(device->prot, "monitor", 7);
+ }
+ }
+
+ /* skip the rest for now */
+
+ return 0;
+}
+
+/* Probe for a device on an inner address and create a ddcci_device for it */
+static int ddcci_detect_device(struct i2c_client *client, unsigned char addr,
+ int dependent)
+{
+ int ret;
+ unsigned char outer_addr = client->addr << 1;
+ unsigned char *buffer = NULL;
+ struct ddcci_bus_drv_data *drv_data = i2c_get_clientdata(client);
+ struct ddcci_device *device = NULL;
+
+ down(&drv_data->sem);
+
+ /* Allocate buffer big enough for any capability string */
+ buffer = kmalloc(16384, GFP_KERNEL);
+ if (!buffer) {
+ ret = -ENOMEM;
+ goto err_end;
+ }
+
+ /* Allocate device struct */
+ device = kzalloc(sizeof(struct ddcci_device), GFP_KERNEL);
+ if (!device) {
+ ret = -ENOMEM;
+ goto err_end;
+ }
+
+ /* Initialize device */
+ device_initialize(&device->dev);
+ device->dev.parent = &client->dev;
+ device->dev.bus = &ddcci_bus_type;
+ device->outer_addr = outer_addr;
+ device->inner_addr = addr;
+ device->bus_drv_data = drv_data;
+ device->i2c_client = client;
+
+ if (!dependent) {
+ device->dev.type = &ddcci_device_type;
+ ret = dev_set_name(&device->dev, "ddcci%d", client->adapter->nr);
+ } else if (outer_addr == dependent) {
+ /* Internal dependent device */
+ device->dev.type = &ddcci_dependent_type;
+ device->flags = DDCCI_FLAG_DEPENDENT;
+ ret = dev_set_name(&device->dev, "ddcci%di%02x", client->adapter->nr, addr);
+ } else if (outer_addr == addr) {
+ /* External dependent device */
+ device->dev.type = &ddcci_dependent_type;
+ device->flags = DDCCI_FLAG_DEPENDENT | DDCCI_FLAG_EXTERNAL;
+ ret = dev_set_name(&device->dev, "ddcci%de%02x", client->adapter->nr, addr);
+ } else {
+ /* Dependent device of external dependent device Just in case something like this exists */
+ device->dev.type = &ddcci_dependent_type;
+ device->flags = DDCCI_FLAG_DEPENDENT | DDCCI_FLAG_EXTERNAL;
+ ret = dev_set_name(&device->dev, "ddcci%de%02x%02x", client->adapter->nr, outer_addr, addr);
+ }
+
+ if (ret)
+ goto err_free;
+
+ /* Read identification and check for quirks */
+ ret = ddcci_identify_device(client, addr, buffer, 29);
+ if (ret < 0) {
+ if (!dependent && (ret == -EBADMSG || ret == -EMSGSIZE))
+ dev_warn(&device->dev, "DDC/CI main device sent broken response on identification. Trying to detect solely based on capability information.\n");
+ else
+ goto err_free;
+ }
+
+ if (ret == 29 && buffer[0] == DDCCI_REPLY_ID) {
+ memcpy(device->vendor, &buffer[7], 8);
+ memcpy(device->module, &buffer[17], 8);
+ device->device_number = be32_to_cpu(*(__force __be32 *)&buffer[18]);
+ }
+
+ /* Read capabilities */
+ ret = ddcci_get_caps(client, addr, buffer, 16384);
+ if (ret > 0) {
+ /*
+ * Fixup unparenthesized capability strings, but only if the first
+ * character is an ascii lower case letter.
+ * This should still allow an early exit for completely garbled
+ * data but helps detecting devices where only the parentheses are
+ * missing, as the second char must be the first character of a
+ * keyword.
+ */
+ if (ret > 2 && buffer[0] >= 'a' && buffer[0] <= 'z') {
+ dev_err(&device->dev, "DDC/CI device quirk detected: unparenthesized capability string\n");
+ device->capabilities = kzalloc(ret+3, GFP_KERNEL);
+ if (!device->capabilities) {
+ ret = -ENOMEM;
+ goto err_free;
+ }
+ device->capabilities_len = ret+2;
+ memcpy(&(device->capabilities[1]), buffer, ret);
+ device->capabilities[0] = '(';
+ device->capabilities[ret+1] = ')';
+ } else {
+ /* Standard case: simply copy the received string */
+ device->capabilities = kzalloc(ret+1, GFP_KERNEL);
+ if (!device->capabilities) {
+ ret = -ENOMEM;
+ goto err_free;
+ }
+ device->capabilities_len = ret;
+ memcpy(device->capabilities, buffer, ret);
+ }
+
+ ret = ddcci_parse_capstring(device);
+ if (ret) {
+ dev_err(&device->dev, "malformed capability string: \"%s\" errno %d\n", device->capabilities, ret);
+ ret = -EINVAL;
+ goto err_free;
+ }
+ }
+
+ /* Found a device if either identification or capabilities succeeded */
+ if (!device->capabilities && device->vendor[0] == '\0') {
+ dev_dbg(&client->dev,
+ "[%02x:%02x] got neither valid identification nor capability data\n",
+ client->addr << 1, addr);
+ ret = -ENODEV;
+ goto err_free;
+ }
+
+ /* Setup chardev */
+ down(&core_lock);
+ ret = ddcci_setup_char_device(device);
+ up(&core_lock);
+ if (ret)
+ goto err_free;
+
+ /* Release semaphore and add device to the tree */
+ up(&drv_data->sem);
+ pr_debug("found device at %d:%02x:%02x\n", client->adapter->nr, outer_addr, addr);
+ ret = device_add(&device->dev);
+ if (ret)
+ goto err_free;
+
+ goto end;
+err_free:
+ put_device(&device->dev);
+err_end:
+ up(&drv_data->sem);
+end:
+ kfree(buffer);
+ return ret;
+}
+
+/* I2C detect function: check if a main or external dependent device exists */
+static int ddcci_detect(struct i2c_client *client, struct i2c_board_info *info)
+{
+ int ret;
+ unsigned char outer_addr;
+ unsigned char inner_addr;
+ unsigned char buf[32];
+ unsigned char cmd_id[1] = { DDCCI_COMMAND_ID };
+ unsigned char cmd_caps[3] = { DDCCI_COMMAND_CAPS, 0x00, 0x00};
+ unsigned char *cmd;
+ unsigned int cmd_len;
+
+ /* Check for i2c_master_* functionality */
+ if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
+ pr_debug("i2c adapter %d unsuitable: no i2c_master functionality\n", client->adapter->nr);
+ return -ENODEV;
+ }
+
+ /* send Capabilities Request (for main) or Identification Request command (for dependent devices) */
+ outer_addr = client->addr << 1;
+ inner_addr = (outer_addr == DDCCI_DEFAULT_DEVICE_ADDR) ? DDCCI_HOST_ADDR_ODD : outer_addr | 1;
+ cmd = (outer_addr == DDCCI_DEFAULT_DEVICE_ADDR) ? cmd_caps : cmd_id;
+ cmd_len = (outer_addr == DDCCI_DEFAULT_DEVICE_ADDR) ? sizeof(cmd_caps) : sizeof(cmd_id);
+ pr_debug("detecting %d:%02x\n", client->adapter->nr, outer_addr);
+
+ ret = __ddcci_write_block(client, inner_addr, buf, true, cmd, cmd_len);
+
+ if (ret == -ENXIO || ret == -EIO) {
+ if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_WRITE_BYTE)) {
+ pr_debug("i2c write failed with ENXIO or EIO but bytewise writing is not supported\n");
+ return -ENODEV;
+ }
+ pr_debug("i2c write failed with ENXIO or EIO, trying bytewise writing\n");
+ ret = __ddcci_write_bytewise(client, inner_addr, true, cmd, cmd_len);
+ if (ret == 0) {
+ msleep(delay);
+ ret = __ddcci_write_bytewise(client, inner_addr, true, cmd, cmd_len);
+ }
+ }
+
+ if (ret < 0)
+ return -ENODEV;
+
+ /* wait for device */
+ msleep(delay);
+ /* receive answer */
+ ret = i2c_master_recv(client, buf, 32);
+ if (ret < 3) {
+ pr_debug("detection failed: no answer\n");
+ return -ENODEV;
+ }
+
+ /* check response starts with outer addr */
+ if (buf[0] != outer_addr) {
+ pr_debug("detection failed: invalid %s response (%02x != %02x)\n", (cmd == cmd_id) ? "identification" : "capabilities", buf[0], outer_addr);
+ pr_debug("received message was %*ph \n", ret, buf);
+ return -ENODEV;
+ }
+
+ pr_debug("detected %d:%02x\n", client->adapter->nr, outer_addr);
+
+ /* set device type */
+ strlcpy(info->type, (outer_addr == DDCCI_DEFAULT_DEVICE_ADDR) ? "ddcci" : "ddcci-dependent", I2C_NAME_SIZE);
+
+ return 0;
+}
+
+/* I2C probe function */
+static int ddcci_probe(struct i2c_client *client, const struct i2c_device_id *id)
+{
+ int i, ret = -ENODEV, tmp;
+ unsigned char main_addr, addr;
+ struct ddcci_bus_drv_data *drv_data;
+
+ /* Initialize driver data structure */
+ drv_data = devm_kzalloc(&client->dev, sizeof(struct ddcci_bus_drv_data), GFP_KERNEL);
+ if (!drv_data)
+ return -ENOMEM;
+ drv_data->i2c_dev = client;
+ sema_init(&drv_data->sem, 1);
+
+ /* Set i2c client data */
+ i2c_set_clientdata(client, drv_data);
+
+ if (id->driver_data == 0) {
+ /* Core device, probe at 0x6E */
+ main_addr = DDCCI_DEFAULT_DEVICE_ADDR;
+ dev_dbg(&client->dev, "probing core device [%02x]\n",
+ client->addr << 1);
+ ret = ddcci_detect_device(client, main_addr, 0);
+ if (ret) {
+ dev_info(&client->dev, "core device [%02x] probe failed: %d\n",
+ client->addr << 1, ret);
+ if (ret == -EIO)
+ ret = -ENODEV;
+ goto err_free;
+ }
+
+ /* Detect internal dependent devices */
+ dev_dbg(&client->dev, "probing internal dependent devices\n");
+ for (i = 0; i < autoprobe_addr_count; ++i) {
+ addr = (unsigned short)autoprobe_addrs[i];
+ if ((addr & 1) == 0 && addr != main_addr) {
+ tmp = ddcci_detect_device(client, addr, main_addr);
+ if (tmp < 0 && tmp != -ENODEV) {
+ dev_info(&client->dev, "internal dependent device [%02x:%02x] probe failed: %d\n",
+ client->addr << 1, addr, ret);
+ }
+ }
+ }
+ } else if (id->driver_data == 1) {
+ /* External dependent device */
+ main_addr = client->addr << 1;
+ dev_dbg(&client->dev, "probing external dependent device [%02x]\n", main_addr);
+ ret = ddcci_detect_device(client, main_addr, -1);
+ if (ret) {
+ dev_info(&client->dev, "external dependent device [%02x] probe failed: %d\n",
+ main_addr, ret);
+ if (ret == -EIO)
+ ret = -ENODEV;
+ goto err_free;
+ }
+ } else {
+ dev_warn(&client->dev,
+ "probe() called with invalid i2c device id\n");
+ ret = -EINVAL;
+ }
+
+ goto end;
+err_free:
+ devm_kfree(&client->dev, drv_data);
+end:
+ return ret;
+}
+
+/*
+ * Callback for bus_find_device() used in ddcci_remove()
+ *
+ * Find next device on i2c_client not flagged with
+ * DDCCI_FLAG_REMOVED and flag it.
+ */
+static int ddcci_remove_helper(struct device *dev, const void *p)
+{
+ struct ddcci_device *device;
+
+ device = ddcci_verify_device(dev);
+ if (!device || device->flags & DDCCI_FLAG_REMOVED)
+ return 0;
+
+ if (!p || (dev->parent == p)) {
+ device->flags |= DDCCI_FLAG_REMOVED;
+ /* Memory Barrier */
+ wmb();
+ return 1;
+ }
+
+ return 0;
+}
+
+/* I2C driver remove callback: unregister all subdevices */
+static int ddcci_remove(struct i2c_client *client)
+{
+ struct ddcci_bus_drv_data *drv_data = i2c_get_clientdata(client);
+ struct device *dev;
+
+ down(&drv_data->sem);
+ while (1) {
+ dev = bus_find_device(&ddcci_bus_type, NULL, client,
+ ddcci_remove_helper);
+ if (!dev)
+ break;
+ device_unregister(dev);
+ put_device(dev);
+ }
+ up(&drv_data->sem);
+ return 0;
+}
+
+/*
+ * I2C driver device identification table.
+ */
+static const struct i2c_device_id ddcci_idtable[] = {
+ { "ddcci", 0 },
+ { "ddcci-dependent", 1 },
+ {}
+};
+MODULE_DEVICE_TABLE(i2c, ddcci_idtable);
+
+/*
+ * I2C driver description structure
+ */
+static struct i2c_driver ddcci_driver = {
+ .driver = {
+ .name = "ddcci",
+ .owner = THIS_MODULE,
+ },
+
+ .id_table = ddcci_idtable,
+ .probe = ddcci_probe,
+ .remove = ddcci_remove,
+ .class = I2C_CLASS_DDC,
+ .detect = ddcci_detect,
+ .address_list = I2C_ADDRS(
+ DDCCI_DEFAULT_DEVICE_ADDR>>1
+ ),
+};
+
+/*
+ * Module initialization function. Called when the module is inserted or
+ * (if builtin) at boot time.
+ */
+static int __init ddcci_module_init(void)
+{
+ int ret;
+
+ pr_debug("initializing ddcci driver\n");
+ /* Allocate a device number region for the character devices */
+ ret = alloc_chrdev_region(&ddcci_cdev_first, 0, 128, DEVICE_NAME);
+ if (ret < 0) {
+ pr_err("failed to register device region: error %d\n", ret);
+ goto err_chrdevreg;
+ }
+ ddcci_cdev_next = ddcci_cdev_first;
+ ddcci_cdev_end = MKDEV(MAJOR(ddcci_cdev_first), MINOR(ddcci_cdev_first)+128);
+
+ /* Register bus */
+ ret = bus_register(&ddcci_bus_type);
+ if (ret) {
+ pr_err("failed to register bus 'ddcci'\n");
+ goto err_busreg;
+ }
+
+ /* Register I2C driver */
+ ret = i2c_add_driver(&ddcci_driver);
+ if (ret) {
+ pr_err("failed to register i2c driver\n");
+ goto err_drvreg;
+ }
+
+ pr_debug("ddcci driver initialized\n");
+
+ return 0;
+
+err_drvreg:
+ bus_unregister(&ddcci_bus_type);
+err_busreg:
+ unregister_chrdev_region(ddcci_cdev_first, 128);
+err_chrdevreg:
+ return ret;
+}
+
+/*
+ * Module clean-up function. Called when the module is removed.
+ */
+static void __exit ddcci_module_exit(void)
+{
+ struct device *dev;
+
+ while (1) {
+ dev = bus_find_device(&ddcci_bus_type, NULL, NULL, ddcci_remove_helper);
+ if (!dev)
+ break;
+ device_unregister(dev);
+ put_device(dev);
+ }
+
+ i2c_del_driver(&ddcci_driver);
+ bus_unregister(&ddcci_bus_type);
+ unregister_chrdev_region(ddcci_cdev_first, 128);
+}
+
+/* Let the kernel know the calls for module init and exit */
+module_init(ddcci_module_init);
+module_exit(ddcci_module_exit);
+
+/* Module parameter description */
+module_param(delay, uint, 0644);
+MODULE_PARM_DESC(delay, "default delay after bus writes (in ms, default 60)");
+module_param_array(autoprobe_addrs, ushort, &autoprobe_addr_count, 0644);
+MODULE_PARM_DESC(autoprobe_addrs, "internal dependent device addresses to autoprobe");
+
+/* Module description */
+MODULE_AUTHOR("Christoph Grenz");
+MODULE_DESCRIPTION("DDC/CI bus driver");
+MODULE_VERSION("0.4.2");
+MODULE_LICENSE("GPL");
diff --git a/include/linux/ddcci.h b/include/linux/ddcci.h
new file mode 100644
index 000000000000..a219f031e584
--- /dev/null
+++ b/include/linux/ddcci.h
@@ -0,0 +1,164 @@
+/*
+ * DDC/CI bus driver
+ *
+ * Copyright (c) 2015 Christoph Grenz
+ */
+
+/*
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the Free
+ * Software Foundation; either version 2 of the License, or (at your option)
+ * any later version.
+ */
+
+#ifndef _DDCCI_H
+#define _DDCCI_H
+
+#include <linux/mod_devicetable.h>
+#include <linux/device.h>
+#include <linux/cdev.h>
+
+#define DDCCI_MODULE_PREFIX "ddcci:"
+
+/* Special addresses */
+
+/* default device address (even) */
+#define DDCCI_DEFAULT_DEVICE_ADDR 0x6E
+/* receiving host address for communication with default device address */
+#define DDCCI_HOST_ADDR_EVEN 0x50
+/* sending host address for communication with default device address */
+#define DDCCI_HOST_ADDR_ODD 0x51
+
+/* Command codes */
+
+/* Identification Request */
+#define DDCCI_COMMAND_ID 0xf1
+/* Identification Reply */
+#define DDCCI_REPLY_ID 0xe1
+/* Capabilities Request */
+#define DDCCI_COMMAND_CAPS 0xf3
+/* Capabilities Reply */
+#define DDCCI_REPLY_CAPS 0xe3
+
+/* Quirks */
+
+/* Device always responds with unset protocol flag */
+#define DDCCI_QUIRK_NO_PFLAG BIT(1)
+/* Device needs writing one byte at a time */
+#define DDCCI_QUIRK_WRITE_BYTEWISE BIT(2)
+/* Device repeats first byte on read */
+#define DDCCI_QUIRK_SKIP_FIRST_BYTE BIT(3)
+
+/* Flags */
+
+#define DDCCI_FLAG_REMOVED BIT(1)
+#define DDCCI_FLAG_DEPENDENT BIT(2)
+#define DDCCI_FLAG_EXTERNAL BIT(3)
+
+extern struct bus_type ddcci_bus_type;
+
+struct ddcci_bus_drv_data;
+
+/* struct ddcci_device_id - identifies DDC/CI devices for probing */
+struct ddcci_device_id {
+ char prot[9];
+ char type[9];
+ char model[9];
+ char vendor[9];
+ char module[9];
+ kernel_ulong_t driver_data; /* Data private to the driver */
+};
+#define DDCCI_ANY_ID "\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF"
+
+/**
+ * struct ddcci_device - represent an DDC/CI device
+ * @outer_addr: Outer device address (I2C address << 1).
+ * @inner_addr: Inner device address.
+ * @flags: Device flags.
+ * @capabilities: Device capability string.
+ * @capabilities_len: Length of capability string.
+ * @i2c_client: Parent I2C device.
+ * @bus_drv_data: Driver internal data structure.
+ * @dev: Driver model device node for the slave.
+ * @cdev: Character device structure
+ * @cdev_sem: RW semaphore for exclusive access on character device.
+ * @prot: Device class ("protocol", from capability string)
+ * @type: Device subclass ("type", from capability string)
+ * @model: Device model (from capability string)
+ * @vendor: Device vendor (from identification command response)
+ * @module: Device module (from identification command response)
+ * @device_number: Device serial (from identification command response)
+ */
+struct ddcci_device {
+ unsigned short outer_addr;
+ unsigned short inner_addr;
+ int flags;
+ char *capabilities;
+ size_t capabilities_len;
+ struct i2c_client *i2c_client;
+ struct ddcci_bus_drv_data *bus_drv_data;
+ struct device dev;
+ struct cdev cdev;
+ struct rw_semaphore cdev_sem;
+ char prot[9];
+ char type[9];
+ char model[9];
+ char vendor[9];
+ char module[9];
+ int device_number;
+};
+#define to_ddcci_device(d) container_of(d, struct ddcci_device, dev)
+
+/**
+ * struct ddcci_driver - represent an DDC/CI device driver
+ * @probe: Callback for device binding
+ * @remove: Callback for device unbinding
+ * @driver: Device driver model driver
+ * @id_table: List of DDC/CI devices supported by this driver
+ *
+ * The driver.owner field should be set to the module owner of this driver.
+ * The driver.name field should be set to the name of this driver.
+ */
+struct ddcci_driver {
+ int (*probe)(struct ddcci_device *, const struct ddcci_device_id *);
+ int (*remove)(struct ddcci_device *);
+ struct device_driver driver;
+ struct ddcci_device_id *id_table;
+};
+#define to_ddcci_driver(d) container_of(d, struct ddcci_driver, driver)
+
+int ddcci_register_driver(struct module *owner, struct ddcci_driver *driver);
+#define ddcci_add_driver(driver) \
+ ddcci_register_driver(THIS_MODULE, driver)
+void ddcci_del_driver(struct ddcci_driver *driver);
+
+struct ddcci_device *ddcci_verify_device(struct device *dev);
+
+#define module_ddcci_driver(__ddcci_driver) \
+ module_driver(__ddcci_driver, ddcci_add_driver, \
+ ddcci_del_driver)
+
+int ddcci_device_write(struct ddcci_device *, bool p_flag, unsigned char *data,
+ unsigned char length);
+int ddcci_device_read(struct ddcci_device *, bool p_flag, unsigned char *buffer,
+ unsigned char length);
+int ddcci_device_writeread(struct ddcci_device *, bool p_flag,
+ unsigned char *buffer, unsigned char length,
+ unsigned char maxlength);
+
+static inline void *ddcci_get_drvdata(const struct ddcci_device *dev)
+{
+ return dev_get_drvdata(&dev->dev);
+}
+
+static inline void ddcci_set_drvdata(struct ddcci_device *dev, void *data)
+{
+ dev_set_drvdata(&dev->dev, data);
+}
+
+unsigned long ddcci_quirks(struct ddcci_device *dev);
+
+const char *ddcci_find_capstr_item(const char *capabilities, const char *tag,
+ size_t *length);
+
+#endif
--
2.25.1
On Fri, Feb 25, 2022 at 08:04:29PM -0800, Yusuf Khan wrote:
> This patch upstreams the DDCCI driver by Christoph Grenz into
> the kernel. The original gitlab page is loacted at https://gitlab
> .com/ddcci-driver-linux/ddcci-driver-linux/-/tree/master.
>
> Signed-off-by: Yusuf Khan <[email protected]>
> ---
> drivers/Kconfig | 2 +
> drivers/Makefile | 1 +
> drivers/ddcci/Kconfig | 5 +
> drivers/ddcci/Makefile | 3 +
> drivers/ddcci/ddcci-backlight.c | 411 +++++++
> drivers/ddcci/ddcci.c | 1887 +++++++++++++++++++++++++++++++
> include/linux/ddcci.h | 164 +++
> 7 files changed, 2473 insertions(+)
> create mode 100644 drivers/ddcci/Kconfig
> create mode 100644 drivers/ddcci/Makefile
> create mode 100644 drivers/ddcci/ddcci-backlight.c
> create mode 100644 drivers/ddcci/ddcci.c
> create mode 100644 include/linux/ddcci.h
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/SubmittingPatches for what needs to be done
here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
On Fri, Feb 25, 2022 at 08:04:29PM -0800, Yusuf Khan wrote:
> This patch upstreams the DDCCI driver by Christoph Grenz into
> the kernel. The original gitlab page is loacted at https://gitlab
> .com/ddcci-driver-linux/ddcci-driver-linux/-/tree/master.
>
> Signed-off-by: Yusuf Khan <[email protected]>
> ---
> drivers/Kconfig | 2 +
> drivers/Makefile | 1 +
> drivers/ddcci/Kconfig | 5 +
> drivers/ddcci/Makefile | 3 +
> drivers/ddcci/ddcci-backlight.c | 411 +++++++
> drivers/ddcci/ddcci.c | 1887 +++++++++++++++++++++++++++++++
> include/linux/ddcci.h | 164 +++
Also, you create a lot of sysfs files here, yet document none of them in
Documentation/ABI/ which will make tools like scripts/get_abi.pl
unhappy. Please fix that in your next submission.
thanks,
greg k-h
Hi Yusuf,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linux/master]
[also build test WARNING on staging/staging-testing linus/master v5.17-rc5]
[cannot apply to next-20220225]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Yusuf-Khan/drivers-ddcci-upstream-DDCCI-driver/20220226-120531
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2c271fe77d52a0555161926c232cd5bc07178b39
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220226/[email protected]/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/7eb8029b70584acc0e9ce82dfdcff13c5496f544
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yusuf-Khan/drivers-ddcci-upstream-DDCCI-driver/20220226-120531
git checkout 7eb8029b70584acc0e9ce82dfdcff13c5496f544
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/ddcci/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All warnings (new ones prefixed by >>):
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:5: warning: "O_CREAT" redefined
5 | #define O_CREAT 01000 /* not fcntl */
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:24: note: this is the location of the previous definition
24 | #define O_CREAT 00000100 /* not fcntl */
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:6: warning: "O_TRUNC" redefined
6 | #define O_TRUNC 02000 /* not fcntl */
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:33: note: this is the location of the previous definition
33 | #define O_TRUNC 00001000 /* not fcntl */
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:7: warning: "O_EXCL" redefined
7 | #define O_EXCL 04000 /* not fcntl */
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:27: note: this is the location of the previous definition
27 | #define O_EXCL 00000200 /* not fcntl */
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:8: warning: "O_NOCTTY" redefined
8 | #define O_NOCTTY 010000 /* not fcntl */
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:30: note: this is the location of the previous definition
30 | #define O_NOCTTY 00000400 /* not fcntl */
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:10: warning: "O_NONBLOCK" redefined
10 | #define O_NONBLOCK 00004
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:39: note: this is the location of the previous definition
39 | #define O_NONBLOCK 00004000
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:11: warning: "O_APPEND" redefined
11 | #define O_APPEND 00010
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:36: note: this is the location of the previous definition
36 | #define O_APPEND 00002000
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:12: warning: "O_DSYNC" redefined
12 | #define O_DSYNC 040000 /* used to be O_SYNC, see below */
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:42: note: this is the location of the previous definition
42 | #define O_DSYNC 00010000 /* used to be O_SYNC, see below */
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:13: warning: "O_DIRECTORY" redefined
13 | #define O_DIRECTORY 0100000 /* must be a directory */
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:54: note: this is the location of the previous definition
54 | #define O_DIRECTORY 00200000 /* must be a directory */
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:14: warning: "O_NOFOLLOW" redefined
14 | #define O_NOFOLLOW 0200000 /* don't follow links */
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:57: note: this is the location of the previous definition
57 | #define O_NOFOLLOW 00400000 /* don't follow links */
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:15: warning: "O_LARGEFILE" redefined
15 | #define O_LARGEFILE 0400000 /* will be set by the kernel on every open */
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:51: note: this is the location of the previous definition
51 | #define O_LARGEFILE 00100000
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:16: warning: "O_DIRECT" redefined
16 | #define O_DIRECT 02000000 /* direct disk access - should check with OSF/1 */
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:48: note: this is the location of the previous definition
48 | #define O_DIRECT 00040000 /* direct disk access hint */
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:17: warning: "O_NOATIME" redefined
17 | #define O_NOATIME 04000000
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:60: note: this is the location of the previous definition
60 | #define O_NOATIME 01000000
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:18: warning: "O_CLOEXEC" redefined
18 | #define O_CLOEXEC 010000000 /* set close_on_exec */
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:63: note: this is the location of the previous definition
63 | #define O_CLOEXEC 02000000 /* set close_on_exec */
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:32: warning: "__O_SYNC" redefined
32 | #define __O_SYNC 020000000
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:80: note: this is the location of the previous definition
80 | #define __O_SYNC 04000000
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:35: warning: "O_PATH" redefined
35 | #define O_PATH 040000000
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:85: note: this is the location of the previous definition
85 | #define O_PATH 010000000
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:36: warning: "__O_TMPFILE" redefined
36 | #define __O_TMPFILE 0100000000
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:89: note: this is the location of the previous definition
89 | #define __O_TMPFILE 020000000
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:38: warning: "F_GETLK" redefined
38 | #define F_GETLK 7
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:106: note: this is the location of the previous definition
106 | #define F_GETLK 5
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:39: warning: "F_SETLK" redefined
39 | #define F_SETLK 8
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:107: note: this is the location of the previous definition
107 | #define F_SETLK 6
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:40: warning: "F_SETLKW" redefined
40 | #define F_SETLKW 9
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:108: note: this is the location of the previous definition
108 | #define F_SETLKW 7
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
>> arch/alpha/include/uapi/asm/fcntl.h:42: warning: "F_SETOWN" redefined
42 | #define F_SETOWN 5 /* for sockets. */
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:111: note: this is the location of the previous definition
111 | #define F_SETOWN 8 /* for sockets. */
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
arch/alpha/include/uapi/asm/fcntl.h:43: warning: "F_GETOWN" redefined
43 | #define F_GETOWN 6 /* for sockets. */
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:112: note: this is the location of the previous definition
112 | #define F_GETOWN 9 /* for sockets. */
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
arch/alpha/include/uapi/asm/fcntl.h:48: warning: "F_RDLCK" redefined
48 | #define F_RDLCK 1
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:166: note: this is the location of the previous definition
166 | #define F_RDLCK 0
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
arch/alpha/include/uapi/asm/fcntl.h:49: warning: "F_WRLCK" redefined
49 | #define F_WRLCK 2
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:167: note: this is the location of the previous definition
167 | #define F_WRLCK 1
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
arch/alpha/include/uapi/asm/fcntl.h:50: warning: "F_UNLCK" redefined
50 | #define F_UNLCK 8
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:168: note: this is the location of the previous definition
168 | #define F_UNLCK 2
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
arch/alpha/include/uapi/asm/fcntl.h:53: warning: "F_EXLCK" redefined
53 | #define F_EXLCK 16 /* or 3 */
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:173: note: this is the location of the previous definition
173 | #define F_EXLCK 4 /* or 3 */
|
In file included from include/uapi/linux/fcntl.h:5,
from include/linux/fcntl.h:6,
from include/linux/fs.h:26,
from drivers/ddcci/ddcci.c:20:
arch/alpha/include/uapi/asm/fcntl.h:54: warning: "F_SHLCK" redefined
54 | #define F_SHLCK 32 /* or 4 */
|
In file included from drivers/ddcci/ddcci.c:16:
include/uapi/asm-generic/fcntl.h:174: note: this is the location of the previous definition
174 | #define F_SHLCK 8 /* or 4 */
|
drivers/ddcci/ddcci.c: In function 'ddcci_modalias_clean':
drivers/ddcci/ddcci.c:76:17: error: expected '}' before 'else'
76 | else if (c < '0' || (c > '9' && c < 'A') || (c > 'Z' && c < 'a') || c > 'z')
| ^~~~
vim +/O_CREAT +5 arch/alpha/include/uapi/asm/fcntl.h
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 4
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @5 #define O_CREAT 01000 /* not fcntl */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @6 #define O_TRUNC 02000 /* not fcntl */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @7 #define O_EXCL 04000 /* not fcntl */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @8 #define O_NOCTTY 010000 /* not fcntl */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 9
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @10 #define O_NONBLOCK 00004
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @11 #define O_APPEND 00010
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 @12 #define O_DSYNC 040000 /* used to be O_SYNC, see below */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @13 #define O_DIRECTORY 0100000 /* must be a directory */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @14 #define O_NOFOLLOW 0200000 /* don't follow links */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @15 #define O_LARGEFILE 0400000 /* will be set by the kernel on every open */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @16 #define O_DIRECT 02000000 /* direct disk access - should check with OSF/1 */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @17 #define O_NOATIME 04000000
620b5e68ee89ba include/asm-alpha/fcntl.h Richard Henderson 2007-08-08 @18 #define O_CLOEXEC 010000000 /* set close_on_exec */
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 19 /*
76b7e0058d09f8 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-12-17 20 * Before Linux 2.6.33 only O_DSYNC semantics were implemented, but using
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 21 * the O_SYNC flag. We continue to use the existing numerical value
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 22 * for O_DSYNC semantics now, but using the correct symbolic name for it.
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 23 * This new value is used to request true Posix O_SYNC semantics. It is
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 24 * defined in this strange way to make sure applications compiled against
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 25 * new headers get at least O_DSYNC semantics on older kernels.
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 26 *
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 27 * This has the nice side-effect that we can simply test for O_DSYNC
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 28 * wherever we do not care if O_DSYNC or O_SYNC is used.
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 29 *
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 30 * Note: __O_SYNC must never be used directly.
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 31 */
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 @32 #define __O_SYNC 020000000
6b2f3d1f769be5 arch/alpha/include/asm/fcntl.h Christoph Hellwig 2009-10-27 33 #define O_SYNC (__O_SYNC|O_DSYNC)
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 34
5229645bdc35f1 arch/alpha/include/asm/fcntl.h Stephen Rothwell 2011-03-16 @35 #define O_PATH 040000000
bb458c644a59db arch/alpha/include/uapi/asm/fcntl.h Al Viro 2013-07-13 @36 #define __O_TMPFILE 0100000000
5229645bdc35f1 arch/alpha/include/asm/fcntl.h Stephen Rothwell 2011-03-16 37
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @38 #define F_GETLK 7
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @39 #define F_SETLK 8
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @40 #define F_SETLKW 9
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 41
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @42 #define F_SETOWN 5 /* for sockets. */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @43 #define F_GETOWN 6 /* for sockets. */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 44 #define F_SETSIG 10 /* for sockets. */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 45 #define F_GETSIG 11 /* for sockets. */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 46
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 47 /* for posix fcntl() and lockf() */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @48 #define F_RDLCK 1
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @49 #define F_WRLCK 2
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @50 #define F_UNLCK 8
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 51
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 52 /* for old implementation of bsd flock () */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @53 #define F_EXLCK 16 /* or 3 */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 @54 #define F_SHLCK 32 /* or 4 */
^1da177e4c3f41 include/asm-alpha/fcntl.h Linus Torvalds 2005-04-16 55
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
On Fri, Feb 25, 2022 at 08:04:29PM -0800, Yusuf Khan wrote:
> --- /dev/null
> +++ b/drivers/ddcci/Kconfig
> @@ -0,0 +1,5 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +menuconfig DDCCI
> + tristate "DDCCI display protocol support"
> + help
> + Say Y here if you want to have DDCCI
You need to explain what this is, what uses it, and why anyone would
want to enable it. We have no idea what this driver is supposed to do
:(
Hi Yusuf,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on staging/staging-testing linus/master v5.17-rc5]
[cannot apply to next-20220225]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Yusuf-Khan/drivers-ddcci-upstream-DDCCI-driver/20220226-120531
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2c271fe77d52a0555161926c232cd5bc07178b39
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220226/[email protected]/config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/7eb8029b70584acc0e9ce82dfdcff13c5496f544
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yusuf-Khan/drivers-ddcci-upstream-DDCCI-driver/20220226-120531
git checkout 7eb8029b70584acc0e9ce82dfdcff13c5496f544
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/ddcci/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All error/warnings (new ones prefixed by >>):
drivers/ddcci/ddcci.c: In function 'ddcci_modalias_clean':
>> drivers/ddcci/ddcci.c:76:17: error: expected '}' before 'else'
76 | else if (c < '0' || (c > '9' && c < 'A') || (c > 'Z' && c < 'a') || c > 'z')
| ^~~~
--
drivers/ddcci/ddcci-backlight.c: In function 'ddcci_monitor_next_vcp_item':
>> drivers/ddcci/ddcci-backlight.c:168:17: error: expected '}' before 'else'
168 | else if (depth > 0) {
| ^~~~
>> drivers/ddcci/ddcci-backlight.c:186:13: error: invalid storage class for function 'ddcci_monitor_find_vcp'
186 | static bool ddcci_monitor_find_vcp(unsigned char vcp, const char *s)
| ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/ddcci/ddcci-backlight.c:186:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
186 | static bool ddcci_monitor_find_vcp(unsigned char vcp, const char *s)
| ^~~~~~
>> drivers/ddcci/ddcci-backlight.c:212:12: error: invalid storage class for function 'ddcci_backlight_create_symlink'
212 | static int ddcci_backlight_create_symlink(struct ddcci_device *ddcci_dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/ddcci/ddcci-backlight.c:240:12: error: invalid storage class for function 'ddcci_backlight_remove_symlink'
240 | static int ddcci_backlight_remove_symlink(struct ddcci_device *ddcci_dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/ddcci/ddcci-backlight.c:274:12: error: invalid storage class for function 'ddcci_monitor_probe'
274 | static int ddcci_monitor_probe(struct ddcci_device *dev,
| ^~~~~~~~~~~~~~~~~~~
>> drivers/ddcci/ddcci-backlight.c:377:12: error: invalid storage class for function 'ddcci_monitor_remove'
377 | static int ddcci_monitor_remove(struct ddcci_device *dev)
| ^~~~~~~~~~~~~~~~~~~~
>> drivers/ddcci/ddcci-backlight.c:396:27: error: initializer element is not constant
396 | .probe = ddcci_monitor_probe,
| ^~~~~~~~~~~~~~~~~~~
drivers/ddcci/ddcci-backlight.c:396:27: note: (near initialization for 'ddcci_backlight_driver.probe')
drivers/ddcci/ddcci-backlight.c:397:27: error: initializer element is not constant
397 | .remove = ddcci_monitor_remove,
| ^~~~~~~~~~~~~~~~~~~~
drivers/ddcci/ddcci-backlight.c:397:27: note: (near initialization for 'ddcci_backlight_driver.remove')
In file included from include/linux/device.h:32,
from include/linux/backlight.h:12,
from drivers/ddcci/ddcci-backlight.c:16:
>> drivers/ddcci/ddcci-backlight.c:400:21: error: invalid storage class for function 'ddcci_backlight_driver_init'
400 | module_ddcci_driver(ddcci_backlight_driver);
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/device/driver.h:260:19: note: in definition of macro 'module_driver'
260 | static int __init __driver##_init(void) \
| ^~~~~~~~
drivers/ddcci/ddcci-backlight.c:400:1: note: in expansion of macro 'module_ddcci_driver'
400 | module_ddcci_driver(ddcci_backlight_driver);
| ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/backlight.h:12,
from drivers/ddcci/ddcci-backlight.c:16:
>> include/linux/module.h:131:49: error: invalid storage class for function '__inittest'
131 | static inline initcall_t __maybe_unused __inittest(void) \
| ^~~~~~~~~~
include/linux/device/driver.h:264:1: note: in expansion of macro 'module_init'
264 | module_init(__driver##_init); \
| ^~~~~~~~~~~
include/linux/ddcci.h:138:9: note: in expansion of macro 'module_driver'
138 | module_driver(__ddcci_driver, ddcci_add_driver, \
| ^~~~~~~~~~~~~
drivers/ddcci/ddcci-backlight.c:400:1: note: in expansion of macro 'module_ddcci_driver'
400 | module_ddcci_driver(ddcci_backlight_driver);
| ^~~~~~~~~~~~~~~~~~~
>> drivers/ddcci/ddcci-backlight.c:400:1: warning: 'alias' attribute ignored [-Wattributes]
In file included from include/linux/device.h:32,
from include/linux/backlight.h:12,
from drivers/ddcci/ddcci-backlight.c:16:
>> drivers/ddcci/ddcci-backlight.c:400:21: error: invalid storage class for function 'ddcci_backlight_driver_exit'
400 | module_ddcci_driver(ddcci_backlight_driver);
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/device/driver.h:265:20: note: in definition of macro 'module_driver'
265 | static void __exit __driver##_exit(void) \
| ^~~~~~~~
drivers/ddcci/ddcci-backlight.c:400:1: note: in expansion of macro 'module_ddcci_driver'
400 | module_ddcci_driver(ddcci_backlight_driver);
| ^~~~~~~~~~~~~~~~~~~
>> include/linux/device/driver.h:265:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
265 | static void __exit __driver##_exit(void) \
| ^~~~~~
include/linux/ddcci.h:138:9: note: in expansion of macro 'module_driver'
138 | module_driver(__ddcci_driver, ddcci_add_driver, \
| ^~~~~~~~~~~~~
drivers/ddcci/ddcci-backlight.c:400:1: note: in expansion of macro 'module_ddcci_driver'
400 | module_ddcci_driver(ddcci_backlight_driver);
| ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/backlight.h:12,
from drivers/ddcci/ddcci-backlight.c:16:
>> include/linux/module.h:139:49: error: invalid storage class for function '__exittest'
139 | static inline exitcall_t __maybe_unused __exittest(void) \
| ^~~~~~~~~~
include/linux/device/driver.h:269:1: note: in expansion of macro 'module_exit'
269 | module_exit(__driver##_exit);
| ^~~~~~~~~~~
include/linux/ddcci.h:138:9: note: in expansion of macro 'module_driver'
138 | module_driver(__ddcci_driver, ddcci_add_driver, \
| ^~~~~~~~~~~~~
drivers/ddcci/ddcci-backlight.c:400:1: note: in expansion of macro 'module_ddcci_driver'
400 | module_ddcci_driver(ddcci_backlight_driver);
| ^~~~~~~~~~~~~~~~~~~
>> drivers/ddcci/ddcci-backlight.c:400:1: warning: 'alias' attribute ignored [-Wattributes]
In file included from include/linux/module.h:22,
from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/backlight.h:12,
from drivers/ddcci/ddcci-backlight.c:16:
>> include/linux/moduleparam.h:409:45: error: invalid storage class for function '__check_convenience_symlink'
409 | static inline type __always_unused *__check_##name(void) { return(p); }
| ^~~~~~~~
include/linux/moduleparam.h:468:35: note: in expansion of macro '__param_check'
468 | #define param_check_bool(name, p) __param_check(name, p, bool)
| ^~~~~~~~~~~~~
include/linux/moduleparam.h:150:9: note: in expansion of macro 'param_check_bool'
150 | param_check_##type(name, &(value)); \
| ^~~~~~~~~~~~
include/linux/moduleparam.h:127:9: note: in expansion of macro 'module_param_named'
127 | module_param_named(name, name, type, perm)
| ^~~~~~~~~~~~~~~~~~
drivers/ddcci/ddcci-backlight.c:403:1: note: in expansion of macro 'module_param'
403 | module_param(convenience_symlink, bool, 0644);
| ^~~~~~~~~~~~
include/linux/moduleparam.h:409:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
409 | static inline type __always_unused *__check_##name(void) { return(p); }
| ^~~~~~
include/linux/moduleparam.h:468:35: note: in expansion of macro '__param_check'
468 | #define param_check_bool(name, p) __param_check(name, p, bool)
| ^~~~~~~~~~~~~
include/linux/moduleparam.h:150:9: note: in expansion of macro 'param_check_bool'
150 | param_check_##type(name, &(value)); \
| ^~~~~~~~~~~~
include/linux/moduleparam.h:127:9: note: in expansion of macro 'module_param_named'
127 | module_param_named(name, name, type, perm)
| ^~~~~~~~~~~~~~~~~~
drivers/ddcci/ddcci-backlight.c:403:1: note: in expansion of macro 'module_param'
403 | module_param(convenience_symlink, bool, 0644);
| ^~~~~~~~~~~~
include/linux/moduleparam.h:289:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
289 | static const char __param_str_##name[] = prefix #name; \
| ^~~~~~
include/linux/moduleparam.h:176:9: note: in expansion of macro '__module_param_call'
176 | __module_param_call(MODULE_PARAM_PREFIX, name, ops, arg, perm, -1, 0)
| ^~~~~~~~~~~~~~~~~~~
include/linux/moduleparam.h:151:9: note: in expansion of macro 'module_param_cb'
151 | module_param_cb(name, ¶m_ops_##type, &value, perm); \
| ^~~~~~~~~~~~~~~
include/linux/moduleparam.h:127:9: note: in expansion of macro 'module_param_named'
127 | module_param_named(name, name, type, perm)
| ^~~~~~~~~~~~~~~~~~
drivers/ddcci/ddcci-backlight.c:403:1: note: in expansion of macro 'module_param'
403 | module_param(convenience_symlink, bool, 0644);
| ^~~~~~~~~~~~
>> drivers/ddcci/ddcci-backlight.c:411:1: error: expected declaration or statement at end of input
411 | MODULE_ALIAS("ddcci:monitor-*-*-*-*");
| ^~~~~~~~~~~~
vim +76 drivers/ddcci/ddcci.c
65
66 /* Replace non-alphanumeric characters in a string (used for modalias) */
67 static void ddcci_modalias_clean(char *string, size_t n, char replacement)
68 {
69 int i;
70
71 for (i = 0; i < n; ++i) {
72 char c = string[i];
73
74 if (c == 0) {
75 return;
> 76 else if (c < '0' || (c > '9' && c < 'A') || (c > 'Z' && c < 'a') || c > 'z')
77 string[i] = replacement;
78 }
79 }
80
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]