2022-02-27 10:26:12

by Yixuan Cao

Subject: [PATCH] mm/vmalloc.c: fix a comment

Dear Sir/Madam,

The sentence
"but the mempolcy want to alloc memory by interleaving"
should be rephrased with
"but the mempolicy wants to alloc memory by interleaving"
where "mempolicy" is a struct name.

Thanks and best regards,
Yixuan Cao

Signed-off-by: Yixuan Cao <[email protected]>
---
mm/vmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index b454cf1a261f..89d48d8eb20c 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -2905,7 +2905,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid,
/* memory allocation should consider mempolicy, we can't
* wrongly use nearest node when nid == NUMA_NO_NODE,
* otherwise memory may be allocated in only one node,
- * but mempolcy want to alloc memory by interleaving.
+ * but mempolicy want to alloc memory by interleaving.
*/
if (IS_ENABLED(CONFIG_NUMA) && nid == NUMA_NO_NODE)
nr = alloc_pages_bulk_array_mempolicy(bulk_gfp,
--
2.31.1

2022-02-27 17:22:40

by Randy Dunlap

Subject: Re: [PATCH] mm/vmalloc.c: fix a comment

On 2/27/22 00:45, Yixuan Cao wrote:
> Dear Sir/Madam,
>
> The sentence
> "but the mempolcy want to alloc memory by interleaving"
> should be rephrased with
> "but the mempolicy wants to alloc memory by interleaving"
> where "mempolicy" is a struct name.
>
> Thanks and best regards,
> Yixuan Cao
>
> Signed-off-by: Yixuan Cao <[email protected]>
> ---
> mm/vmalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index b454cf1a261f..89d48d8eb20c 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -2905,7 +2905,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid,
> /* memory allocation should consider mempolicy, we can't
> * wrongly use nearest node when nid == NUMA_NO_NODE,
> * otherwise memory may be allocated in only one node,
> - * but mempolcy want to alloc memory by interleaving.
> + * but mempolicy want to alloc memory by interleaving.

s/want/wants/
as in your commentary above.

> */
> if (IS_ENABLED(CONFIG_NUMA) && nid == NUMA_NO_NODE)
> nr = alloc_pages_bulk_array_mempolicy(bulk_gfp,

thanks.
--
~Randy