This patchset helps in resolving dtc warnings for arm pl022 bindings.
Fixing requires updation to clock and clock-names properties.
One more dts fix is required to eliminate all warnings which will be
sent from other tree.
Please note, this patch is based on top of
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git, for-next
Kuldeep Singh (3):
dt-bindings: spi: Update clocks property for ARM pl022
dt-bindings: spi: Update clock-names property for ARM pl022
dt-bindings: spi: Add spiclk to clock-names property in pl022
.../devicetree/bindings/spi/spi-pl022.yaml | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
--
2.25.1
Fix below dtc warning by making necessary addition of "spiclk" in
clock-names property.
arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dt.yaml: spi@190000:
clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk']
From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml
arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dt.yaml: spi@66190000:
clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk']
From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml
Signed-off-by: Kuldeep Singh <[email protected]>
---
Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
index 5f6926a58b15..fb3075a0c7fd 100644
--- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
@@ -45,6 +45,7 @@ properties:
- enum:
- sspclk
- SSPCLK
+ - spiclk
- const: apb_pclk
pl022,autosuspend-delay:
--
2.25.1
Below are the possibilities of pl022 clock-names property:
- apb_pclk
- [sspclk, SSPCLK, spiclk], apb_pclk
The current schema refers to second case and does not consider first
one. Hence, resolve the below dtc warnings by updating clock properties:
arch/arm64/boot/dts/lg/lg1313-ref.dt.yaml: spi@fe900000: clock-names:0:
'apb_pclk' is not one of ['SSPCLK', 'sspclk']
From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml
Signed-off-by: Kuldeep Singh <[email protected]>
---
Documentation/devicetree/bindings/spi/spi-pl022.yaml | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
index 7d36e15db5b3..5f6926a58b15 100644
--- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
@@ -38,11 +38,14 @@ properties:
maxItems: 2
clock-names:
- items:
+ oneOf:
- enum:
- - SSPCLK
- - sspclk
- - const: apb_pclk
+ - apb_pclk
+ - items:
+ - enum:
+ - sspclk
+ - SSPCLK
+ - const: apb_pclk
pl022,autosuspend-delay:
description: delay in ms following transfer completion before the
--
2.25.1
Add missing minItems property to clocks in ARM pl022 bindings.
This also helps in resolving below dtc warnings:
arch/arm64/boot/dts/amd/amd-overdrive.dt.yaml: spi@e1020000: clocks: [[4]] is too short
From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml
arch/arm64/boot/dts/amd/amd-overdrive.dt.yaml: spi@e1020000: clock-names: ['apb_pclk'] is too short
From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml
Signed-off-by: Kuldeep Singh <[email protected]>
---
Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
index 6d633728fc2b..7d36e15db5b3 100644
--- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
@@ -34,6 +34,7 @@ properties:
maxItems: 1
clocks:
+ minItems: 1
maxItems: 2
clock-names:
--
2.25.1