2022-02-28 20:03:23

by Sebastian Krzyszkowiak

Subject: [PATCH] input: keyboard: snvs_pwrkey: Fix SNVS_HPVIDR1 register address

Both i.MX6 and i.MX8 reference manuals list 0xBF8 as SNVS_HPVIDR1
(chapters 57.9 and 6.4.5 respectively).

Fixes: 1a26c920717a ("Input: snvs_pwrkey - send key events for i.MX6 S, DL and Q")
Signed-off-by: Sebastian Krzyszkowiak <[email protected]>
---
drivers/input/keyboard/snvs_pwrkey.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/snvs_pwrkey.c
index 65286762b02a..ad8660be0127 100644
--- a/drivers/input/keyboard/snvs_pwrkey.c
+++ b/drivers/input/keyboard/snvs_pwrkey.c
@@ -20,7 +20,7 @@
#include <linux/mfd/syscon.h>
#include <linux/regmap.h>

-#define SNVS_HPVIDR1_REG 0xF8
+#define SNVS_HPVIDR1_REG 0xBF8
#define SNVS_LPSR_REG 0x4C /* LP Status Register */
#define SNVS_LPCR_REG 0x38 /* LP Control Register */
#define SNVS_HPSR_REG 0x14
--
2.35.1

2022-03-01 17:09:24

by Martin Kepplinger

Subject: Re: [PATCH] input: keyboard: snvs_pwrkey: Fix SNVS_HPVIDR1 register address

Am Montag, dem 28.02.2022 um 19:46 +0100 schrieb Sebastian
Krzyszkowiak:
> Both i.MX6 and i.MX8 reference manuals list 0xBF8 as SNVS_HPVIDR1
> (chapters 57.9 and 6.4.5 respectively).
>
> Fixes: 1a26c920717a ("Input: snvs_pwrkey - send key events for i.MX6
> S, DL and Q")
> Signed-off-by: Sebastian Krzyszkowiak
> <[email protected]>

Tested-by: Martin Kepplinger <[email protected]>

using evemu-record. Because the commit message doesn't describe it:
Without this, when "pressing" power key, events "1" and "0" together
would be delivered in one. With this fix, it's only "1", and when
"releasing" we see the "0" event as expected.

thank you,
martin


> ---
>  drivers/input/keyboard/snvs_pwrkey.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/snvs_pwrkey.c
> b/drivers/input/keyboard/snvs_pwrkey.c
> index 65286762b02a..ad8660be0127 100644
> --- a/drivers/input/keyboard/snvs_pwrkey.c
> +++ b/drivers/input/keyboard/snvs_pwrkey.c
> @@ -20,7 +20,7 @@
>  #include <linux/mfd/syscon.h>
>  #include <linux/regmap.h>
>  
> -#define SNVS_HPVIDR1_REG       0xF8
> +#define SNVS_HPVIDR1_REG       0xBF8
>  #define SNVS_LPSR_REG          0x4C    /* LP Status Register */
>  #define SNVS_LPCR_REG          0x38    /* LP Control Register */
>  #define SNVS_HPSR_REG          0x14