2022-03-01 01:45:28

by Ilya Lipnitskiy

Subject: [PATCH] MIPS: ralink: mt7621: use bitwise NOT instead of logical

It was the intention to reverse the bits, not make them all zero by
using logical NOT operator.

Fixes: cc19db8b312a ("MIPS: ralink: mt7621: do memory detection on KSEG1")
Suggested-by: Chuanhong Guo <[email protected]>
Signed-off-by: Ilya Lipnitskiy <[email protected]>
---
arch/mips/ralink/mt7621.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/ralink/mt7621.c b/arch/mips/ralink/mt7621.c
index 12c8808e0dea..fb0565bc34fd 100644
--- a/arch/mips/ralink/mt7621.c
+++ b/arch/mips/ralink/mt7621.c
@@ -69,7 +69,7 @@ static bool __init mt7621_addr_wraparound_test(phys_addr_t size)
__raw_writel(MT7621_MEM_TEST_PATTERN, dm);
if (__raw_readl(dm) != __raw_readl(dm + size))
return false;
- __raw_writel(!MT7621_MEM_TEST_PATTERN, dm);
+ __raw_writel(~MT7621_MEM_TEST_PATTERN, dm);
return __raw_readl(dm) == __raw_readl(dm + size);
}

--
2.35.1

2022-03-01 08:50:43

by Sergio Paracuellos

Subject: Re: [PATCH] MIPS: ralink: mt7621: use bitwise NOT instead of logical

Hi Ilya,

On Tue, Mar 1, 2022 at 2:49 AM Ilya Lipnitskiy
<[email protected]> wrote:
>
> It was the intention to reverse the bits, not make them all zero by
> using logical NOT operator.
>
> Fixes: cc19db8b312a ("MIPS: ralink: mt7621: do memory detection on KSEG1")
> Suggested-by: Chuanhong Guo <[email protected]>
> Signed-off-by: Ilya Lipnitskiy <[email protected]>
> ---
> arch/mips/ralink/mt7621.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Sergio Paracuellos <[email protected]>

Thanks,
Sergio Paracuellos

2022-03-01 10:39:16

by Thomas Bogendoerfer

Subject: Re: [PATCH] MIPS: ralink: mt7621: use bitwise NOT instead of logical

On Mon, Feb 28, 2022 at 05:15:07PM -0800, Ilya Lipnitskiy wrote:
> It was the intention to reverse the bits, not make them all zero by
> using logical NOT operator.
>
> Fixes: cc19db8b312a ("MIPS: ralink: mt7621: do memory detection on KSEG1")
> Suggested-by: Chuanhong Guo <[email protected]>
> Signed-off-by: Ilya Lipnitskiy <[email protected]>
> ---
> arch/mips/ralink/mt7621.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ralink/mt7621.c b/arch/mips/ralink/mt7621.c
> index 12c8808e0dea..fb0565bc34fd 100644
> --- a/arch/mips/ralink/mt7621.c
> +++ b/arch/mips/ralink/mt7621.c
> @@ -69,7 +69,7 @@ static bool __init mt7621_addr_wraparound_test(phys_addr_t size)
> __raw_writel(MT7621_MEM_TEST_PATTERN, dm);
> if (__raw_readl(dm) != __raw_readl(dm + size))
> return false;
> - __raw_writel(!MT7621_MEM_TEST_PATTERN, dm);
> + __raw_writel(~MT7621_MEM_TEST_PATTERN, dm);
> return __raw_readl(dm) == __raw_readl(dm + size);
> }
>
> --
> 2.35.1

applied to mips-fixes

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]