2022-03-01 09:36:57

by Souptick Joarder

[permalink] [raw]

Subject: [PATCH] power: supply: ab8500: Remove unused variable

---

From: "Souptick Joarder (HPE)" <[email protected]>

Kernel test robot reported below warning ->
drivers/power/supply/ab8500_chargalg.c:790:13: warning:
variable 'delta_i_ua' set but not used [-Wunused-but-set-variable]

Remove unused variable delta_i_ua.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Souptick Joarder (HPE) <[email protected]>
---
drivers/power/supply/ab8500_chargalg.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/power/supply/ab8500_chargalg.c b/drivers/power/supply/ab8500_chargalg.c
index b5a3096e78a1..f73d29c09caf 100644
--- a/drivers/power/supply/ab8500_chargalg.c
+++ b/drivers/power/supply/ab8500_chargalg.c
@@ -793,13 +793,10 @@ static void init_maxim_chg_curr(struct ab8500_chargalg *di)
*/
static enum maxim_ret ab8500_chargalg_chg_curr_maxim(struct ab8500_chargalg *di)
{
- int delta_i_ua;

if (!di->bm->maxi->ena_maxi)
return MAXIM_RET_NOACTION;

- delta_i_ua = di->ccm.original_iset_ua - di->batt_data.inst_curr_ua;
-
if (di->events.vbus_collapsed) {
dev_dbg(di->dev, "Charger voltage has collapsed %d\n",
di->ccm.wait_cnt);
--
2.25.1

2022-03-04 21:58:55

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH] power: supply: ab8500: Remove unused variable

---

Hi,

On Tue, Mar 01, 2022 at 10:58:50AM +0530, Souptick Joarder wrote:
> From: "Souptick Joarder (HPE)" <[email protected]>
>
> Kernel test robot reported below warning ->
> drivers/power/supply/ab8500_chargalg.c:790:13: warning:
> variable 'delta_i_ua' set but not used [-Wunused-but-set-variable]
>
> Remove unused variable delta_i_ua.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Souptick Joarder (HPE) <[email protected]>
> ---

Thanks, queued.

-- Sebastian

> drivers/power/supply/ab8500_chargalg.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/power/supply/ab8500_chargalg.c b/drivers/power/supply/ab8500_chargalg.c
> index b5a3096e78a1..f73d29c09caf 100644
> --- a/drivers/power/supply/ab8500_chargalg.c
> +++ b/drivers/power/supply/ab8500_chargalg.c
> @@ -793,13 +793,10 @@ static void init_maxim_chg_curr(struct ab8500_chargalg *di)
> */
> static enum maxim_ret ab8500_chargalg_chg_curr_maxim(struct ab8500_chargalg *di)
> {
> - int delta_i_ua;
>
> if (!di->bm->maxi->ena_maxi)
> return MAXIM_RET_NOACTION;
>
> - delta_i_ua = di->ccm.original_iset_ua - di->batt_data.inst_curr_ua;
> -
> if (di->events.vbus_collapsed) {
> dev_dbg(di->dev, "Charger voltage has collapsed %d\n",
> di->ccm.wait_cnt);
> --
> 2.25.1
>

---

Attachments:

(No filename) (1.32 kB)
signature.asc (849.00 B)
Download all attachments