2022-03-02 18:20:46

by Yihao Han

Subject: [PATCH] mfd: hi6421-spmi-pmic: fix platform_get_irq.cocci warning

Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Signed-off-by: Yihao Han <[email protected]>
---
drivers/misc/hi6421v600-irq.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/misc/hi6421v600-irq.c b/drivers/misc/hi6421v600-irq.c
index 1c763796cf1f..babb85364aa9 100644
--- a/drivers/misc/hi6421v600-irq.c
+++ b/drivers/misc/hi6421v600-irq.c
@@ -244,10 +244,8 @@ static int hi6421v600_irq_probe(struct platform_device *pdev)
pmic_pdev = container_of(pmic_dev, struct platform_device, dev);

priv->irq = platform_get_irq(pmic_pdev, 0);
- if (priv->irq < 0) {
- dev_err(dev, "Error %d when getting IRQs\n", priv->irq);
+ if (priv->irq < 0)
return priv->irq;
- }

platform_set_drvdata(pdev, priv);

--
2.17.1

2022-03-18 16:30:59

by Greg Kroah-Hartman

Subject: Re: [PATCH] mfd: hi6421-spmi-pmic: fix platform_get_irq.cocci warning

On Tue, Mar 01, 2022 at 10:56:29PM -0800, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Signed-off-by: Yihao Han <[email protected]>
> ---
> drivers/misc/hi6421v600-irq.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Subject line is wrong :(