2022-03-03 00:02:34

by Aashish Sharma

Subject: [PATCH] drm: Fix no previous prototype error in drm_nomodeset.c

Fix this kernel test robot error:

drivers/gpu/drm/drm_nomodeset.c:8:6: error:
no previous prototype for 'drm_firmware_drivers_only'

Including drm_drv.h in drm_nomodeset.c which contains
drm_firmware_drivers_only's declaration.

Signed-off-by: Aashish Sharma <[email protected]>
---
drivers/gpu/drm/drm_nomodeset.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/drm_nomodeset.c b/drivers/gpu/drm/drm_nomodeset.c
index f3978d5bd3a1..9402deb4985f 100644
--- a/drivers/gpu/drm/drm_nomodeset.c
+++ b/drivers/gpu/drm/drm_nomodeset.c
@@ -2,6 +2,7 @@

#include <linux/module.h>
#include <linux/types.h>
+#include <drm/drm_drv.h>

static bool drm_nomodeset;

--
2.35.1.574.g5d30c73bfb-goog

2022-03-03 06:33:33

by Guenter Roeck

Subject: Re: [PATCH] drm: Fix no previous prototype error in drm_nomodeset.c

On Wed, Mar 02, 2022 at 10:39:02PM +0530, Aashish Sharma wrote:
> Fix this kernel test robot error:
>
> drivers/gpu/drm/drm_nomodeset.c:8:6: error:
> no previous prototype for 'drm_firmware_drivers_only'
>
> Including drm_drv.h in drm_nomodeset.c which contains
> drm_firmware_drivers_only's declaration.
>
> Signed-off-by: Aashish Sharma <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> drivers/gpu/drm/drm_nomodeset.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_nomodeset.c b/drivers/gpu/drm/drm_nomodeset.c
> index f3978d5bd3a1..9402deb4985f 100644
> --- a/drivers/gpu/drm/drm_nomodeset.c
> +++ b/drivers/gpu/drm/drm_nomodeset.c
> @@ -2,6 +2,7 @@
>
> #include <linux/module.h>
> #include <linux/types.h>
> +#include <drm/drm_drv.h>
>
> static bool drm_nomodeset;
>
> --
> 2.35.1.574.g5d30c73bfb-goog
>