2022-03-03 17:33:01

by José Expósito

[permalink] [raw]
Subject: [PATCH drm-misc-next 0/2] Use default drm_plane_funcs.format_mod_supported

Hi everyone,

This series is a follow up to [1]. Some of the patches were merged
in "drm-misc-next", however a couple of them, included in this
series, are pending.

I rebased the pending patches on top of "drm-misc-next" and added the reviewed
by tags.

Thanks,
José Expósito

[1] https://lore.kernel.org/dri-devel/[email protected]/

José Expósito (2):
drm/simple-kms: Drop format_mod_supported function
drm: mxsfb: Drop format_mod_supported function

drivers/gpu/drm/drm_simple_kms_helper.c | 8 --------
drivers/gpu/drm/mxsfb/mxsfb_kms.c | 8 --------
2 files changed, 16 deletions(-)

--
2.25.1


2022-03-03 17:41:04

by José Expósito

[permalink] [raw]
Subject: [PATCH drm-misc-next 1/2] drm/simple-kms: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of
the default implementation.

Signed-off-by: José Expósito <[email protected]>
Reviewed-by: Simon Ser <[email protected]>
---
drivers/gpu/drm/drm_simple_kms_helper.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drivers/gpu/drm/drm_simple_kms_helper.c
index 72989ed1baba..2c6aa67c6956 100644
--- a/drivers/gpu/drm/drm_simple_kms_helper.c
+++ b/drivers/gpu/drm/drm_simple_kms_helper.c
@@ -284,13 +284,6 @@ static void drm_simple_kms_plane_cleanup_fb(struct drm_plane *plane,
pipe->funcs->cleanup_fb(pipe, state);
}

-static bool drm_simple_kms_format_mod_supported(struct drm_plane *plane,
- uint32_t format,
- uint64_t modifier)
-{
- return modifier == DRM_FORMAT_MOD_LINEAR;
-}
-
static const struct drm_plane_helper_funcs drm_simple_kms_plane_helper_funcs = {
.prepare_fb = drm_simple_kms_plane_prepare_fb,
.cleanup_fb = drm_simple_kms_plane_cleanup_fb,
@@ -339,7 +332,6 @@ static const struct drm_plane_funcs drm_simple_kms_plane_funcs = {
.reset = drm_simple_kms_plane_reset,
.atomic_duplicate_state = drm_simple_kms_plane_duplicate_state,
.atomic_destroy_state = drm_simple_kms_plane_destroy_state,
- .format_mod_supported = drm_simple_kms_format_mod_supported,
};

/**
--
2.25.1

2022-03-04 02:40:47

by José Expósito

[permalink] [raw]
Subject: [PATCH drm-misc-next 2/2] drm: mxsfb: Drop format_mod_supported function

The "drm_plane_funcs.format_mod_supported" can be removed in favor of
the default implementation.

Signed-off-by: José Expósito <[email protected]>
Reviewed-by: Simon Ser <[email protected]>
---
drivers/gpu/drm/mxsfb/mxsfb_kms.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
index 0655582ae8ed..df32e1c3cc5d 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
@@ -554,13 +554,6 @@ static void mxsfb_plane_overlay_atomic_update(struct drm_plane *plane,
writel(ctrl, mxsfb->base + LCDC_AS_CTRL);
}

-static bool mxsfb_format_mod_supported(struct drm_plane *plane,
- uint32_t format,
- uint64_t modifier)
-{
- return modifier == DRM_FORMAT_MOD_LINEAR;
-}
-
static const struct drm_plane_helper_funcs mxsfb_plane_primary_helper_funcs = {
.atomic_check = mxsfb_plane_atomic_check,
.atomic_update = mxsfb_plane_primary_atomic_update,
@@ -572,7 +565,6 @@ static const struct drm_plane_helper_funcs mxsfb_plane_overlay_helper_funcs = {
};

static const struct drm_plane_funcs mxsfb_plane_funcs = {
- .format_mod_supported = mxsfb_format_mod_supported,
.update_plane = drm_atomic_helper_update_plane,
.disable_plane = drm_atomic_helper_disable_plane,
.destroy = drm_plane_cleanup,
--
2.25.1