2022-03-04 20:41:41

by Horatiu Vultur

Subject: [PATCH net-next] net: sparx5: Fix initialization of variables on stack

The variables 'res' inside the functions sparx5_ptp_get_1ppm and
sparx5_ptp_get_nominal_value was not initialized. So in case of the default
case of the switch after, it would return an uninitialized variable.
This makes also the clang builds to failed.

Fixes: 0933bd04047c3b ("net: sparx5: Add support for ptp clocks")
Signed-off-by: Horatiu Vultur <[email protected]>
---
drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c b/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c
index fa377f6e7e08..cd110c31e5a4 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_ptp.c
@@ -32,7 +32,7 @@ static u64 sparx5_ptp_get_1ppm(struct sparx5 *sparx5)
* (1/1000000)/((2^-59)/X)
*/

- u64 res;
+ u64 res = 0;

switch (sparx5->coreclock) {
case SPX5_CORE_CLOCK_250MHZ:
@@ -54,7 +54,7 @@ static u64 sparx5_ptp_get_1ppm(struct sparx5 *sparx5)

static u64 sparx5_ptp_get_nominal_value(struct sparx5 *sparx5)
{
- u64 res;
+ u64 res = 0;

switch (sparx5->coreclock) {
case SPX5_CORE_CLOCK_250MHZ:
--
2.33.0

2022-03-05 05:23:46

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: sparx5: Fix initialization of variables on stack

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Fri, 4 Mar 2022 15:09:18 +0100 you wrote:
> The variables 'res' inside the functions sparx5_ptp_get_1ppm and
> sparx5_ptp_get_nominal_value was not initialized. So in case of the default
> case of the switch after, it would return an uninitialized variable.
> This makes also the clang builds to failed.
>
> Fixes: 0933bd04047c3b ("net: sparx5: Add support for ptp clocks")
> Signed-off-by: Horatiu Vultur <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] net: sparx5: Fix initialization of variables on stack
https://git.kernel.org/netdev/net-next/c/349fa2796e52

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html