Hi,
Changes since v1:
1. Patch 3: remove unneeded parenthesis and module alias change (Jiri).
2. Patch 3: move unrelated "constify" bits to patch 6.
3. Patch 5: fix typo.
4. Add review tags.
Best regards,
Krzysztof
Krzysztof Kozlowski (7):
tty: serial: samsung: embed s3c24xx_uart_info in parent structure
tty: serial: samsung: embed s3c2410_uartcfg in parent structure
tty: serial: samsung: constify s3c24xx_serial_drv_data
tty: serial: samsung: constify UART name
tty: serial: samsung: constify s3c24xx_serial_drv_data members
tty: serial: samsung: constify variables and pointers
tty: serial: samsung: simplify getting OF match data
drivers/tty/serial/samsung_tty.c | 225 +++++++++++++++----------------
1 file changed, 109 insertions(+), 116 deletions(-)
--
2.32.0
The driver data (struct s3c24xx_serial_drv_data) is never modified, so
also its members can be made const. Except code style this has no
impact because the structure itself is always a const.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Jiri Slaby <[email protected]>
---
drivers/tty/serial/samsung_tty.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index 7025306f76b7..b9783d8fb440 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -85,9 +85,9 @@ struct s3c24xx_uart_info {
};
struct s3c24xx_serial_drv_data {
- struct s3c24xx_uart_info info;
- struct s3c2410_uartcfg def_cfg;
- unsigned int fifosize[CONFIG_SERIAL_SAMSUNG_UARTS];
+ const struct s3c24xx_uart_info info;
+ const struct s3c2410_uartcfg def_cfg;
+ const unsigned int fifosize[CONFIG_SERIAL_SAMSUNG_UARTS];
};
struct s3c24xx_uart_dma {
--
2.32.0
Hi Krzysztof
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:[email protected]]
>Sent: Monday, March 7, 2022 1:38 PM
>To: Krzysztof Kozlowski <[email protected]>; Alim Akhtar
><[email protected]>; Greg Kroah-Hartman
><[email protected]>; Jiri Slaby <[email protected]>; linux-arm-
>[email protected]; [email protected]; linux-
>[email protected]; [email protected]
>Subject: [PATCH v2 0/7] tty: serial: samsung: minor fixes/cleanups
>
>Hi,
>
>Changes since v1:
>1. Patch 3: remove unneeded parenthesis and module alias change (Jiri).
>2. Patch 3: move unrelated "constify" bits to patch 6.
>3. Patch 5: fix typo.
>4. Add review tags.
>
>Best regards,
>Krzysztof
>
>Krzysztof Kozlowski (7):
> tty: serial: samsung: embed s3c24xx_uart_info in parent structure
> tty: serial: samsung: embed s3c2410_uartcfg in parent structure
> tty: serial: samsung: constify s3c24xx_serial_drv_data
> tty: serial: samsung: constify UART name
> tty: serial: samsung: constify s3c24xx_serial_drv_data members
> tty: serial: samsung: constify variables and pointers
> tty: serial: samsung: simplify getting OF match data
>
> drivers/tty/serial/samsung_tty.c | 225 +++++++++++++++----------------
> 1 file changed, 109 insertions(+), 116 deletions(-)
>
For this series feel free to add
Reviewed-by: Alim Akhtar <[email protected]>
Sanity tested on Exynos7 Espresso board, boot log and other console prints
after boot looks fine, so
Tested-by: Alim Akhtar <[email protected]>
>--
>2.32.0