2022-03-07 14:29:55

by Krishna Yarlagadda

Subject: [PATCH v2] reset: ACPI reset support

Some of the IO devices like I2C or SPI require reset at runtime to
recover from an error condition without changing the power state of
the system. Added check for ACPI handle and a call to method '__RST'
if supported. Devices using device tree method are unaffected by this.

Signed-off-by: Krishna Yarlagadda <[email protected]>
---
v2:
- add error checks.

drivers/reset/core.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index 61e688882643..45749d623f36 100644
--- a/drivers/reset/core.c
+++ b/drivers/reset/core.c
@@ -12,6 +12,7 @@
#include <linux/kref.h>
#include <linux/module.h>
#include <linux/of.h>
+#include <linux/acpi.h>
#include <linux/reset.h>
#include <linux/reset-controller.h>
#include <linux/slab.h>
@@ -1100,13 +1101,23 @@ EXPORT_SYMBOL_GPL(__devm_reset_control_bulk_get);
*
* Convenience wrapper for __reset_control_get() and reset_control_reset().
* This is useful for the common case of devices with single, dedicated reset
- * lines.
+ * lines. _RST firmware method will be called for devices with ACPI.
*/
int __device_reset(struct device *dev, bool optional)
{
struct reset_control *rstc;
int ret;

+ acpi_handle handle = ACPI_HANDLE(dev);
+
+ if (handle) {
+ if (!acpi_has_method(handle, "_RST"))
+ return optional ? 0 : -ENOENT;
+ if (ACPI_FAILURE(acpi_evaluate_object(handle, "_RST", NULL,
+ NULL)))
+ return -EIO;
+ }
+
rstc = __reset_control_get(dev, NULL, 0, 0, optional, true);
if (IS_ERR(rstc))
return PTR_ERR(rstc);
--
2.17.1

2022-04-05 03:22:16

by Philipp Zabel

Subject: Re: [PATCH v2] reset: ACPI reset support

On Mo, 2022-03-07 at 19:26 +0530, Krishna Yarlagadda wrote:
> Some of the IO devices like I2C or SPI require reset at runtime to
> recover from an error condition without changing the power state of
> the system. Added check for ACPI handle and a call to method '__RST'
> if supported. Devices using device tree method are unaffected by
> this.
>
> Signed-off-by: Krishna Yarlagadda <[email protected]>
> ---
> v2:
> - add error checks.

Thank you, applied to reset/next.

regards
Philipp