An issue[1] related to how the V4L2_FWNODE_BUS_TYPE_PARALLEL flag is mis-used
was found in recent addition to the anx7625 driver.
In order to not introduce this issue into the ABI, let's revert the changes
to the anx7625 dt-binding related to this.
[1] https://lore.kernel.org/all/[email protected]/
Robert Foss (2):
Revert "dt-bindings:drm/bridge:anx7625:add vendor define"
Revert "arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI
endpoint"
.../display/bridge/analogix,anx7625.yaml | 65 +------------------
.../dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 -
2 files changed, 2 insertions(+), 65 deletions(-)
--
2.32.0
This reverts commit 32568ae37596b529628ac09b875f4874e614f63f.
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
index e8f133dc96b95..8f7bf33f607da 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
@@ -171,8 +171,6 @@ port@0 {
anx7625_in: endpoint {
remote-endpoint = <&dsi_out>;
- bus-type = <5>;
- data-lanes = <0 1 2 3>;
};
};
--
2.32.0
Hi Rob,
Thank you for the patch.
On Mon, Mar 07, 2022 at 04:45:56PM +0100, Robert Foss wrote:
> An issue[1] related to how the V4L2_FWNODE_BUS_TYPE_PARALLEL flag is mis-used
> was found in recent addition to the anx7625 driver.
>
> In order to not introduce this issue into the ABI, let's revert the changes
> to the anx7625 dt-binding related to this.
>
> [1] https://lore.kernel.org/all/[email protected]/
>
> Robert Foss (2):
> Revert "dt-bindings:drm/bridge:anx7625:add vendor define"
> Revert "arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI
> endpoint"
If this is enough to avoid the wrong bus-type becoming an ABI, even if
the corresponding driver support isn't reverted, then, for the whole
series,
Reviewed-by: Laurent Pinchart <[email protected]>
> .../display/bridge/analogix,anx7625.yaml | 65 +------------------
> .../dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 -
> 2 files changed, 2 insertions(+), 65 deletions(-)
--
Regards,
Laurent Pinchart
This reverts commit a43661e7e819b100e1f833a35018560a1d9abb39.
---
.../display/bridge/analogix,anx7625.yaml | 65 +------------------
1 file changed, 2 insertions(+), 63 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
index 1d3e88daca041..ab48ab2f4240d 100644
--- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
@@ -43,70 +43,14 @@ properties:
vdd33-supply:
description: Regulator that provides the supply 3.3V power.
- analogix,lane0-swing:
- $ref: /schemas/types.yaml#/definitions/uint8-array
- minItems: 1
- maxItems: 20
- description:
- an array of swing register setting for DP tx lane0 PHY.
- Registers 0~9 are Swing0_Pre0, Swing1_Pre0, Swing2_Pre0,
- Swing3_Pre0, Swing0_Pre1, Swing1_Pre1, Swing2_Pre1, Swing0_Pre2,
- Swing1_Pre2, Swing0_Pre3, they are for [Boost control] and
- [Swing control] setting.
- Registers 0~9, bit 3:0 is [Boost control], these bits control
- post cursor manual, increase the [Boost control] to increase
- Pre-emphasis value.
- Registers 0~9, bit 6:4 is [Swing control], these bits control
- swing manual, increase [Swing control] setting to add Vp-p value
- for each Swing, Pre.
- Registers 10~19 are Swing0_Pre0, Swing1_Pre0, Swing2_Pre0,
- Swing3_Pre0, Swing0_Pre1, Swing1_Pre1, Swing2_Pre1, Swing0_Pre2,
- Swing1_Pre2, Swing0_Pre3, they are for [R select control] and
- [R Termination control] setting.
- Registers 10~19, bit 4:0 is [R select control], these bits are
- compensation manual, increase it can enhance IO driven strength
- and Vp-p.
- Registers 10~19, bit 5:6 is [R termination control], these bits
- adjust 50ohm impedance of DP tx termination. 00:55 ohm,
- 01:50 ohm(default), 10:45 ohm, 11:40 ohm.
-
- analogix,lane1-swing:
- $ref: /schemas/types.yaml#/definitions/uint8-array
- minItems: 1
- maxItems: 20
- description:
- an array of swing register setting for DP tx lane1 PHY.
- DP TX lane1 swing register setting same with lane0
- swing, please refer lane0-swing property description.
-
- analogix,audio-enable:
- type: boolean
- description: let the driver enable audio HDMI codec function or not.
-
ports:
$ref: /schemas/graph.yaml#/properties/ports
properties:
port@0:
- $ref: /schemas/graph.yaml#/$defs/port-base
- unevaluatedProperties: false
+ $ref: /schemas/graph.yaml#/properties/port
description:
- MIPI DSI/DPI input.
-
- properties:
- endpoint:
- $ref: /schemas/media/video-interfaces.yaml#
- type: object
- additionalProperties: false
-
- properties:
- remote-endpoint: true
-
- bus-type:
- enum: [1, 5]
- default: 1
-
- data-lanes: true
+ Video port for MIPI DSI input.
port@1:
$ref: /schemas/graph.yaml#/properties/port
@@ -143,9 +87,6 @@ examples:
vdd10-supply = <&pp1000_mipibrdg>;
vdd18-supply = <&pp1800_mipibrdg>;
vdd33-supply = <&pp3300_mipibrdg>;
- analogix,audio-enable;
- analogix,lane0-swing = /bits/ 8 <0x14 0x54 0x64 0x74>;
- analogix,lane1-swing = /bits/ 8 <0x14 0x54 0x64 0x74>;
ports {
#address-cells = <1>;
@@ -155,8 +96,6 @@ examples:
reg = <0>;
anx7625_in: endpoint {
remote-endpoint = <&mipi_dsi>;
- bus-type = <5>;
- data-lanes = <0 1 2 3>;
};
};
--
2.32.0