2022-03-09 00:06:51

by Nava kishore Manne

Subject: [PATCH 0/6]fpga: fix for coding style and kernel-doc issues

This patch series fixes the coding style and kernel-doc issues
exists in the fpga framework, zynq and ZynqMP drivers.

Nava kishore Manne (6):
fpga: zynq: Fix incorrect variable type
fpga: zynqmp: Initialized variables before using it
fpga: fpga-mgr: fix for coding style issues
fpga: fpga-mgr: Add missing kernel-doc description
fpga: Use tab instead of spaces for indentation
fpga: fpga-region: Add missing kernel-doc description

drivers/fpga/Makefile | 6 +++---
drivers/fpga/fpga-mgr.c | 8 ++++++--
drivers/fpga/of-fpga-region.c | 18 ++++++++++--------
drivers/fpga/zynq-fpga.c | 2 +-
drivers/fpga/zynqmp-fpga.c | 2 +-
5 files changed, 21 insertions(+), 15 deletions(-)

--
2.25.1

2022-03-09 00:13:00

by Nava kishore Manne

Subject: [PATCH 1/6] fpga: zynq: Fix incorrect variable type

zynq_fpga_has_sync () API is expecting "u8 *" but the
formal parameter that was passed is of type "const char *".
To fix this issue cast the const char pointer to u8 pointer.

Signed-off-by: Nava kishore Manne <[email protected]>
---
drivers/fpga/zynq-fpga.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
index 426aa34c6a0d..12f644e79e91 100644
--- a/drivers/fpga/zynq-fpga.c
+++ b/drivers/fpga/zynq-fpga.c
@@ -275,7 +275,7 @@ static int zynq_fpga_ops_write_init(struct fpga_manager *mgr,

/* don't globally reset PL if we're doing partial reconfig */
if (!(info->flags & FPGA_MGR_PARTIAL_RECONFIG)) {
- if (!zynq_fpga_has_sync(buf, count)) {
+ if (!zynq_fpga_has_sync((u8 *)buf, count)) {
dev_err(&mgr->dev,
"Invalid bitstream, could not find a sync word. Bitstream must be a byte swapped .bin file\n");
err = -EINVAL;
--
2.25.1