2022-03-08 19:35:56

by Paolo Abeni

Subject: Re: [PATCH] drivers: vxlan: fix returnvar.cocci warning

Hello,

On Tue, 2022-03-08 at 18:00 +0800, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
>
> drivers/net/vxlan/vxlan_core.c:2995:5-8:
> Unneeded variable: "ret". Return "0" on line 3004.
>
> Signed-off-by: Guo Zhengkui <[email protected]>

Please specify a target tree (likely net-next) in the patch subj.
Additionally, this looks worthy a "Fixes" tag, likely:

Fixes: f9c4bb0b245c ("vxlan: vni filtering support on collect metadata device")

Thanks,

Paolo

2022-03-09 00:49:29

by Guo Zhengkui

Subject: [PATCH linux-next v2] drivers: vxlan: fix returnvar.cocci warning

Fix the following coccicheck warning:

drivers/net/vxlan/vxlan_core.c:2995:5-8:
Unneeded variable: "ret". Return "0" on line 3004.

Fixes: f9c4bb0b245c ("vxlan: vni filtering support on collect metadata device")
Signed-off-by: Guo Zhengkui <[email protected]>
---
drivers/net/vxlan/vxlan_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index b3cbd37c4b93..e06158a42823 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -2992,7 +2992,6 @@ static void vxlan_flush(struct vxlan_dev *vxlan, bool do_all)
static int vxlan_stop(struct net_device *dev)
{
struct vxlan_dev *vxlan = netdev_priv(dev);
- int ret = 0;

vxlan_multicast_leave(vxlan);

@@ -3001,7 +3000,7 @@ static int vxlan_stop(struct net_device *dev)
vxlan_flush(vxlan, false);
vxlan_sock_release(vxlan);

- return ret;
+ return 0;
}

/* Stub, nothing needs to be done. */
--
2.20.1

2022-03-10 07:24:36

by patchwork-bot+netdevbpf

Subject: Re: [PATCH linux-next v2] drivers: vxlan: fix returnvar.cocci warning

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Tue, 8 Mar 2022 21:43:09 +0800 you wrote:
> Fix the following coccicheck warning:
>
> drivers/net/vxlan/vxlan_core.c:2995:5-8:
> Unneeded variable: "ret". Return "0" on line 3004.
>
> Fixes: f9c4bb0b245c ("vxlan: vni filtering support on collect metadata device")
> Signed-off-by: Guo Zhengkui <[email protected]>
>
> [...]

Here is the summary with links:
- [linux-next,v2] drivers: vxlan: fix returnvar.cocci warning
https://git.kernel.org/netdev/net-next/c/e58bc864630f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html