2022-03-09 15:28:55

by Xiongwei Song

Subject: [PATCH 1/2] mm: slab: Delete unused SLAB_DEACTIVATED flag

From: Xiongwei Song <[email protected]>

Since commit 9855609bde03 ("mm: memcg/slab: use a single set of
kmem_caches for all accounted allocations") deletes all SLAB_DEACTIVATED
users, therefore this flag is not needed any more, let's delete it.

Signed-off-by: Xiongwei Song <[email protected]>
---
include/linux/slab.h | 3 ---
1 file changed, 3 deletions(-)

diff --git a/include/linux/slab.h b/include/linux/slab.h
index 37bde99b74af..b6b3eed6c7c4 100644
--- a/include/linux/slab.h
+++ b/include/linux/slab.h
@@ -117,9 +117,6 @@
#define SLAB_RECLAIM_ACCOUNT ((slab_flags_t __force)0x00020000U)
#define SLAB_TEMPORARY SLAB_RECLAIM_ACCOUNT /* Objects are short-lived */

-/* Slab deactivation flag */
-#define SLAB_DEACTIVATED ((slab_flags_t __force)0x10000000U)
-
/*
* ZERO_SIZE_PTR will be returned for zero sized kmalloc requests.
*
--
2.30.2

2022-03-09 19:16:56

by David Rientjes

Subject: Re: [PATCH 1/2] mm: slab: Delete unused SLAB_DEACTIVATED flag

On Wed, 9 Mar 2022, [email protected] wrote:

> From: Xiongwei Song <[email protected]>
>
> Since commit 9855609bde03 ("mm: memcg/slab: use a single set of
> kmem_caches for all accounted allocations") deletes all SLAB_DEACTIVATED
> users, therefore this flag is not needed any more, let's delete it.
>
> Signed-off-by: Xiongwei Song <[email protected]>

Acked-by: David Rientjes <[email protected]>

2022-03-10 01:47:33

by Xiongwei Song

Subject: Re: [PATCH 1/2] mm: slab: Delete unused SLAB_DEACTIVATED flag

On Thu, Mar 10, 2022 at 1:14 AM David Rientjes <[email protected]> wrote:
>
> On Wed, 9 Mar 2022, [email protected] wrote:
>
> > From: Xiongwei Song <[email protected]>
> >
> > Since commit 9855609bde03 ("mm: memcg/slab: use a single set of
> > kmem_caches for all accounted allocations") deletes all SLAB_DEACTIVATED
> > users, therefore this flag is not needed any more, let's delete it.
> >
> > Signed-off-by: Xiongwei Song <[email protected]>
>
> Acked-by: David Rientjes <[email protected]>

Thank you!

2022-03-10 10:46:43

by Roman Gushchin

Subject: Re: [PATCH 1/2] mm: slab: Delete unused SLAB_DEACTIVATED flag

On Wed, Mar 09, 2022 at 10:50:51PM +0800, [email protected] wrote:
> From: Xiongwei Song <[email protected]>
>
> Since commit 9855609bde03 ("mm: memcg/slab: use a single set of
> kmem_caches for all accounted allocations") deletes all SLAB_DEACTIVATED
> users, therefore this flag is not needed any more, let's delete it.

Indeed! Thank!

Reviewed-by: Roman Gushchin <[email protected]>