tree: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/rcar
head: 9775965dbae50a04f12879179d6d6fb58f240d6b
commit: 9775965dbae50a04f12879179d6d6fb58f240d6b [2/2] PCI: rcar: Use PCI_SET_ERROR_RESPONSE after read which triggered an exception
config: arm-randconfig-c002-20220307 (https://download.01.org/0day-ci/archive/20220309/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?id=9775965dbae50a04f12879179d6d6fb58f240d6b
git remote add lpieralisi-pci https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
git fetch --no-tags lpieralisi-pci pci/rcar
git checkout 9775965dbae50a04f12879179d6d6fb58f240d6b
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
>> drivers/pci/controller/pcie-rcar-host.c:139:3: error: instruction requires: data-barriers
__rcar_pci_rw_reg_workaround("str")
^
drivers/pci/controller/pcie-rcar-host.c:120:4: note: expanded from macro '__rcar_pci_rw_reg_workaround'
"2: isb\n" \
^
<inline asm>:2:4: note: instantiated into assembly here
2: isb
^
drivers/pci/controller/pcie-rcar-host.c:153:3: error: instruction requires: data-barriers
__rcar_pci_rw_reg_workaround("ldr")
^
drivers/pci/controller/pcie-rcar-host.c:120:4: note: expanded from macro '__rcar_pci_rw_reg_workaround'
"2: isb\n" \
^
<inline asm>:2:4: note: instantiated into assembly here
2: isb
^
2 errors generated.
vim +139 drivers/pci/controller/pcie-rcar-host.c
132
133 static int rcar_pci_write_reg_workaround(struct rcar_pcie *pcie, u32 val,
134 unsigned int reg)
135 {
136 int error = PCIBIOS_SUCCESSFUL;
137 #ifdef CONFIG_ARM
138 asm volatile(
> 139 __rcar_pci_rw_reg_workaround("str")
140 : "+r"(error):"r"(val), "r"(pcie->base + reg) : "memory");
141 #else
142 rcar_pci_write_reg(pcie, val, reg);
143 #endif
144 return error;
145 }
146
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
On Wed, Mar 09, 2022 at 05:04:28PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/rcar
> head: 9775965dbae50a04f12879179d6d6fb58f240d6b
> commit: 9775965dbae50a04f12879179d6d6fb58f240d6b [2/2] PCI: rcar: Use PCI_SET_ERROR_RESPONSE after read which triggered an exception
> config: arm-randconfig-c002-20220307 (https://download.01.org/0day-ci/archive/20220309/[email protected]/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm cross compiling tool for clang build
> # apt-get install binutils-arm-linux-gnueabi
> # https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?id=9775965dbae50a04f12879179d6d6fb58f240d6b
> git remote add lpieralisi-pci https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> git fetch --no-tags lpieralisi-pci pci/rcar
> git checkout 9775965dbae50a04f12879179d6d6fb58f240d6b
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> >> drivers/pci/controller/pcie-rcar-host.c:139:3: error: instruction requires: data-barriers
> __rcar_pci_rw_reg_workaround("str")
> ^
> drivers/pci/controller/pcie-rcar-host.c:120:4: note: expanded from macro '__rcar_pci_rw_reg_workaround'
> "2: isb\n" \
> ^
> <inline asm>:2:4: note: instantiated into assembly here
> 2: isb
> ^
> drivers/pci/controller/pcie-rcar-host.c:153:3: error: instruction requires: data-barriers
> __rcar_pci_rw_reg_workaround("ldr")
> ^
> drivers/pci/controller/pcie-rcar-host.c:120:4: note: expanded from macro '__rcar_pci_rw_reg_workaround'
> "2: isb\n" \
> ^
> <inline asm>:2:4: note: instantiated into assembly here
> 2: isb
> ^
> 2 errors generated.
I don't know how to fix this. We currently have these on Lorenzo's
pci/rcar branch:
9775965dbae5 ("PCI: rcar: Use PCI_SET_ERROR_RESPONSE after read which triggered an exception")
de6b5097f58b ("PCI: rcar: Finish transition to L1 state in rcar_pcie_config_access()")
To avoid this error, for now I have cherry-picked de6b5097f58b to a
local pci/host/rcar branch and dropped 9775965dbae5.
> vim +139 drivers/pci/controller/pcie-rcar-host.c
>
> 132
> 133 static int rcar_pci_write_reg_workaround(struct rcar_pcie *pcie, u32 val,
> 134 unsigned int reg)
> 135 {
> 136 int error = PCIBIOS_SUCCESSFUL;
> 137 #ifdef CONFIG_ARM
> 138 asm volatile(
> > 139 __rcar_pci_rw_reg_workaround("str")
> 140 : "+r"(error):"r"(val), "r"(pcie->base + reg) : "memory");
> 141 #else
> 142 rcar_pci_write_reg(pcie, val, reg);
> 143 #endif
> 144 return error;
> 145 }
> 146
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/[email protected]
On Thu, Mar 10, 2022 at 1:18 AM Nathan Chancellor <[email protected]> wrote:
> > To avoid this error, for now I have cherry-picked de6b5097f58b to a
> > local pci/host/rcar branch and dropped 9775965dbae5.
>
> FWIW, this is not clang specific, the same configuration blows up with
> GCC 11.2.0 as well:
>
> $ make -skj"$(nproc)" \
> ARCH=arm \
> CROSS_COMPILE=arm-linux-gnueabi- \
> olddefconfig drivers/pci/controller/pcie-rcar-host.o
> /tmp/ccz8ybtm.s: Assembler messages:
> /tmp/ccz8ybtm.s:742: Error: selected processor does not support `isb' in ARM mode
> /tmp/ccz8ybtm.s:812: Error: selected processor does not support `isb' in ARM mode
> make[4]: *** [scripts/Makefile.build:288: drivers/pci/controller/pcie-rcar-host.o] Error 1
>
> $ rg CONFIG_CPU_32 .config
> 289:CONFIG_CPU_32v4=y
>
> It does not look like isb can be used with this configuration, at least
> if I understand arch/arm/include/asm/barrier.h correctly.
My first thought was to amend the #ifdef to
#if IS_ENABLED(CONFIG_ARM) && IS_ENABLED(CONFIG_ARCH_RENESAS)
However, this is still broken because you can build a kernel that
enables the Renesas ARMv7 platform along with early ARMv6 (omap2 and
imx3) that do not support "isb" either.
What I think we want to do here instead is to add a ".arch armv7-a" in the
inline assembly.
Arnd
Hi Bjorn,
On Wed, Mar 09, 2022 at 05:09:50PM -0600, Bjorn Helgaas wrote:
> On Wed, Mar 09, 2022 at 05:04:28PM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git pci/rcar
> > head: 9775965dbae50a04f12879179d6d6fb58f240d6b
> > commit: 9775965dbae50a04f12879179d6d6fb58f240d6b [2/2] PCI: rcar: Use PCI_SET_ERROR_RESPONSE after read which triggered an exception
> > config: arm-randconfig-c002-20220307 (https://download.01.org/0day-ci/archive/20220309/[email protected]/config)
> > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # install arm cross compiling tool for clang build
> > # apt-get install binutils-arm-linux-gnueabi
> > # https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git/commit/?id=9775965dbae50a04f12879179d6d6fb58f240d6b
> > git remote add lpieralisi-pci https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> > git fetch --no-tags lpieralisi-pci pci/rcar
> > git checkout 9775965dbae50a04f12879179d6d6fb58f240d6b
> > # save the config file to linux build tree
> > mkdir build_dir
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <[email protected]>
> >
> > All errors (new ones prefixed by >>):
> >
> > >> drivers/pci/controller/pcie-rcar-host.c:139:3: error: instruction requires: data-barriers
> > __rcar_pci_rw_reg_workaround("str")
> > ^
> > drivers/pci/controller/pcie-rcar-host.c:120:4: note: expanded from macro '__rcar_pci_rw_reg_workaround'
> > "2: isb\n" \
> > ^
> > <inline asm>:2:4: note: instantiated into assembly here
> > 2: isb
> > ^
> > drivers/pci/controller/pcie-rcar-host.c:153:3: error: instruction requires: data-barriers
> > __rcar_pci_rw_reg_workaround("ldr")
> > ^
> > drivers/pci/controller/pcie-rcar-host.c:120:4: note: expanded from macro '__rcar_pci_rw_reg_workaround'
> > "2: isb\n" \
> > ^
> > <inline asm>:2:4: note: instantiated into assembly here
> > 2: isb
> > ^
> > 2 errors generated.
>
> I don't know how to fix this. We currently have these on Lorenzo's
> pci/rcar branch:
>
> 9775965dbae5 ("PCI: rcar: Use PCI_SET_ERROR_RESPONSE after read which triggered an exception")
> de6b5097f58b ("PCI: rcar: Finish transition to L1 state in rcar_pcie_config_access()")
>
> To avoid this error, for now I have cherry-picked de6b5097f58b to a
> local pci/host/rcar branch and dropped 9775965dbae5.
FWIW, this is not clang specific, the same configuration blows up with
GCC 11.2.0 as well:
$ make -skj"$(nproc)" \
ARCH=arm \
CROSS_COMPILE=arm-linux-gnueabi- \
olddefconfig drivers/pci/controller/pcie-rcar-host.o
/tmp/ccz8ybtm.s: Assembler messages:
/tmp/ccz8ybtm.s:742: Error: selected processor does not support `isb' in ARM mode
/tmp/ccz8ybtm.s:812: Error: selected processor does not support `isb' in ARM mode
make[4]: *** [scripts/Makefile.build:288: drivers/pci/controller/pcie-rcar-host.o] Error 1
$ rg CONFIG_CPU_32 .config
289:CONFIG_CPU_32v4=y
It does not look like isb can be used with this configuration, at least
if I understand arch/arm/include/asm/barrier.h correctly.
Cheers,
Nathan