2022-03-11 14:37:19

by Alexandre Bailon

Subject: [PATCH v2] mmc: mtk-sd: Silence delay phase calculation debug log

The driver prints the following log everytime data is written to RPMB:
mtk-msdc 11230000.mmc: phase: [map:ffffffff] [maxlen:32] [final:10]

dev_info is used to print that log but it seems that log is only
useful for debbuging. Use dev_dbg instead of dev_info.

Signed-off-by: Alexandre Bailon <[email protected]>
Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
---
drivers/mmc/host/mtk-sd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index d5a9c269d492..05c8b4de46f3 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1914,8 +1914,8 @@ static struct msdc_delay_phase get_best_delay(struct msdc_host *host, u32 delay)
final_phase = (start_final + len_final / 3) % PAD_DELAY_MAX;
else
final_phase = (start_final + len_final / 2) % PAD_DELAY_MAX;
- dev_info(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
- delay, len_final, final_phase);
+ dev_dbg(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
+ delay, len_final, final_phase);

delay_phase.maxlen = len_final;
delay_phase.start = start_final;
--
2.34.1

2022-03-16 07:05:53

by Ulf Hansson

Subject: Re: [PATCH v2] mmc: mtk-sd: Silence delay phase calculation debug log

On Fri, 11 Mar 2022 at 11:33, Alexandre Bailon <[email protected]> wrote:
>
> The driver prints the following log everytime data is written to RPMB:
> mtk-msdc 11230000.mmc: phase: [map:ffffffff] [maxlen:32] [final:10]
>
> dev_info is used to print that log but it seems that log is only
> useful for debbuging. Use dev_dbg instead of dev_info.
>
> Signed-off-by: Alexandre Bailon <[email protected]>
> Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/mtk-sd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index d5a9c269d492..05c8b4de46f3 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1914,8 +1914,8 @@ static struct msdc_delay_phase get_best_delay(struct msdc_host *host, u32 delay)
> final_phase = (start_final + len_final / 3) % PAD_DELAY_MAX;
> else
> final_phase = (start_final + len_final / 2) % PAD_DELAY_MAX;
> - dev_info(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
> - delay, len_final, final_phase);
> + dev_dbg(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
> + delay, len_final, final_phase);
>
> delay_phase.maxlen = len_final;
> delay_phase.start = start_final;
> --
> 2.34.1
>