2022-03-11 21:40:23

by Dominique Martinet

[permalink] [raw]
Subject: [PATCH] fscache_aquire_cache: error instead of asserting name is set

name comes straight from the cachefilesd config file, so return an error that
the daemon handles and reports instead of printing a kernel stack in dmesg

Signed-off-by: Dominique Martinet <[email protected]>
---
fs/fscache/cache.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/fscache/cache.c b/fs/fscache/cache.c
index 2749933852a9..6115b974585d 100644
--- a/fs/fscache/cache.c
+++ b/fs/fscache/cache.c
@@ -150,7 +150,9 @@ struct fscache_cache *fscache_acquire_cache(const char *name)
{
struct fscache_cache *cache;

- ASSERT(name);
+ if (!name)
+ return ERR_PTR(-EINVAL);
+
cache = fscache_lookup_cache(name, true);
if (IS_ERR(cache))
return cache;
--
2.35.1